Gaetan Craig-Riou
be78c2ac41
Fix system admin adjustment spec
2025-01-27 11:02:50 +11:00
Gaetan Craig-Riou
900b751559
Revert change from d58aa2b14f44fa15b67a18cf3457eccaaca5a56c
...
Turns out there seem to be a legitimate use for this code, see
spec/system/admin/adjustments_spec.rb ie, adding a manual discount to an
order using an adjustment.
2025-01-27 11:02:50 +11:00
Gaetan Craig-Riou
cd7e92c6ca
Fix various spec
2025-01-27 11:02:41 +11:00
Gaetan Craig-Riou
6b7373e4cf
Clean up spec syntax
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
6e8eb443c1
Consolidate .adjust specs
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
42df158669
Fix TaxRate#compute_amount
...
Remove the code path that can create a tax refund, it is unlikely to
happen with the configuration our instances are using. Instead return 0
do that no adjustment gets created
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
5e42a9be55
Fix TaxRate spec to work with the zone changes
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
d4a060c6a2
Fix Zone system spec
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
a953e3dde3
Fix Spree::Zone spec and factory
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
75c0752340
Sree::Zone, require at least one member
...
Add validations and specs
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
bcb4525cdd
Clean up spec, use describe instead of context
...
Although `describe` and `context` are functionally equivalent, they
don't convey the same message
2025-01-27 11:01:07 +11:00
Konrad
01036e6321
Merge pull request #13087 from mkllnk/stock-location
...
Remove class Spree::StockLocation
2025-01-25 12:41:37 +01:00
David Cook
09fe6d7542
Merge pull request #13091 from mkllnk/flaky-ship
...
Fix flaky spec of order shipment
2025-01-24 15:02:19 +11:00
David Cook
e38d305ca1
Merge pull request #13089 from mkllnk/haml-up-remove
...
Remove unneeded HAML upgrade script
2025-01-24 14:23:56 +11:00
Filipe
5d360730c7
Merge pull request #13023 from rioug/12907-fix-checkout-shipping-fee
...
[Checkout] Shipping fees update, remove order callback
2025-01-23 18:50:31 -06:00
Konrad
0b8807146e
Merge pull request #13058 from mkllnk/currency-config
...
Remove unused app config options
2025-01-22 11:27:12 +01:00
Maikel
c258bee44d
Merge pull request #13065 from mkllnk/dfc-amend-nothing
...
Admin updates can trigger new backorders until the order cycle is closed
2025-01-22 16:32:23 +11:00
Maikel Linke
c975a2c8c4
Fix flaky spec of order shipment
...
I found that a delay in the reflex handling the request could fail the
spec. Added a sleep in the reflex to reproduce the fail. The I added
expectations for the page content to wait until the page was updated and
that fixed the specs.
2025-01-22 15:34:09 +11:00
Maikel Linke
64608beaa8
Remove DefaultStockLocation created in setup
2025-01-22 12:01:57 +11:00
Maikel Linke
70ebe7b964
Remove stock location from specs
2025-01-22 11:52:25 +11:00
Maikel Linke
f098327808
Remove now useless wrapper method
2025-01-22 11:31:27 +11:00
Maikel Linke
d5ff1f5c71
Remove StockItem#stock_location
2025-01-22 11:20:05 +11:00
Maikel Linke
87d20877ad
Remove Shipment#stock_location
2025-01-22 11:20:05 +11:00
Maikel Linke
33c6f3b94f
Remove StockLocation#stock_item
2025-01-22 11:20:05 +11:00
Maikel Linke
aa9daed66e
Remove unused StockLocation#stock_items
...
And the reverse association.
2025-01-22 11:20:05 +11:00
Maikel Linke
450576a938
Remove unused StockLocation#count_on_hand
2025-01-22 11:20:04 +11:00
Maikel Linke
1650ccd55a
Remove unused StockLocation#backorderable?
2025-01-22 11:20:04 +11:00
Maikel Linke
531c068347
Remove StockLocation#fill_status, now on Variant
2025-01-22 11:20:04 +11:00
Maikel Linke
a4b92f289c
Move fill_status spec to prepare removal from StockLocation
2025-01-22 11:20:04 +11:00
Maikel Linke
68a0f8df1f
Remove detour via StockLocation updating stock
2025-01-22 11:20:04 +11:00
Maikel Linke
248110cfb3
Make stock location association optional
...
Prepare for removal
2025-01-22 11:20:04 +11:00
Maikel Linke
917e0ff01a
Remove unnecessary storage of currency
2025-01-21 20:11:05 +01:00
Maikel Linke
ed926e9e26
Remove unnecessary storage of checkout zone
2025-01-21 20:11:05 +01:00
Maikel
229ee7028c
Merge pull request #13064 from mkllnk/negative-stock
...
Don't show stock for on-demand inventory items
2025-01-21 11:05:50 +11:00
Gaetan Craig-Riou
fcd366cc06
Fix spec
...
Payment needs to be linked to the order, in order for the payment
callback to update `order.payment_total`
2025-01-21 10:52:32 +11:00
Gaetan Craig-Riou
0ca164a354
Fix spec
...
Use a completed payment, instead of trying to complete a payment
2025-01-21 10:51:08 +11:00
Gaetan Craig-Riou
d7ae91c23e
Per review, specify the actual expected value
2025-01-20 16:21:19 +11:00
Gaetan Craig-Riou
17e7f7d26d
Small linting fix
2025-01-20 16:16:00 +11:00
Gaetan Craig-Riou
c71ae35685
Fix payment_total calculation
...
For payment that complete during the checkout (Paypal, Stripe) the
amount was recorded twice against `order.payment_total`. This is because
the `payment_total` gets updated in an afer_save Payment callback when a
payment is completed, and then once more when we process payment in
`Spree::Order#process_each_payment`.
This is an existing issue on master, but it was hidden by the
`update_shipping_fees!` callback, it trigerred an update of the order's
total, which then updated `order.payment_total` with the correct value.
Now that we removed the callback, the bug showed up.
Note, I updated the stripe specs for consistency even though they are
currently disabled.
2025-01-20 16:07:32 +11:00
Filipe
a472f3e4f5
Merge pull request #13068 from vishaldeepak/variant-with-tax
...
New variants should inherit tax category in UI
2025-01-17 10:57:22 -06:00
Filipe
ace3bfa2a5
Merge pull request #13061 from kernal053/add-voucher-label-to-edit-cart-page
...
Add 'Voucher:' before voucher code on edit cart page
2025-01-16 22:51:57 -06:00
Maikel Linke
06d9d96f54
Fix error on removed product from catalog
2025-01-17 12:21:28 +11:00
Filipe
3c1dd10219
Merge pull request #13047 from mkllnk/spree-roles
...
Clarify that our only user role is "admin" and simplify code
2025-01-16 18:06:49 -06:00
Gaetan Craig-Riou
1afa7fe5c0
Per review, small improvment
2025-01-15 15:44:24 -06:00
Gaetan Craig-Riou
a8d1d0c591
Update spec to properly update line items on an order
...
User Order::Contents#update_item to update line item on an order, it
ensures the order is properly updated
2025-01-15 15:44:24 -06:00
Gaetan Craig-Riou
9e7e40a5a8
Update spec to properly test shipping fee update
2025-01-15 15:44:24 -06:00
Gaetan Craig-Riou
f9bd720341
Add spec for #update_shipping_fees!
...
And update related specs
2025-01-15 15:44:24 -06:00
Gaetan Craig-Riou
20df5c23e8
Remove before save callback to update shipping fees
...
It should be handled in the controller, it's currently handled in
`Spree::OrderContents#remove`. As long as we don't manually remove line
item from an order we should be good.
Currently it gets trigerred each time the order is saved, which seems to
happen mutiple time when we finalize an order. It's a bit useless to
recalculated the fees over and over
Context, it was added here : 217eda8362
2025-01-15 15:44:24 -06:00
Maikel Linke
c9eed4f5b8
Trigger new backorder only when user checks out
...
When an admin creates an order, then AmendBackorderJob is called which
can also trigger a new backorder if needed.
This means that we are not creating backorders via subscriptions any
more. It has never been requested and we can bring that back if needed.
2025-01-15 15:52:57 +11:00
Maikel Linke
18ec97992d
Remove unneeded HAML upgrade script
...
We updated a long time ago and I now copied those scripts to a Gist to
share with others:
* https://gist.github.com/mkllnk/bab2d474d686a2e3b88914129aee63e1
2025-01-15 12:55:13 +11:00
