zanetagebka
a2a670c848
Fix cops StringConcatenation
2024-06-11 15:17:32 +10:00
Filipe
5872515a35
Merge pull request #12515 from isidzukuri/12503_skip_saving_of_unchanged_products
...
Do not commit to db unchanged products in bulk save
2024-06-05 18:01:59 +02:00
Ana Nunes da Silva
a7dc243db9
Sanitize product description using rails default sanitizer
2024-06-03 11:45:49 +01:00
David Cook
35c2297d55
Detect changes in price
...
Price is actually an association with lots of custom methods to make it look like a field, and so changes were ignored.
Now this issue is fixed, perhaps it should be moved to a concern..
Note, there are other delegated fields: product name and description may be assigned from the variant. But there's no hooks to save the prroduct, so I didn't include it when checking for changes.
2024-05-28 12:00:04 +10:00
Maikel Linke
bc27e4bbdd
Re-instate spec which uses invalid mocking
...
I removed it because it needed a complete rewrite and I didn't think it
was valuable enough to do so. But now that I deactivated RSpecs
validating mocks again, this spec passes and we can do that work another
time.
2024-05-10 08:56:06 +10:00
Maikel Linke
6317fe1b71
Disable RSpec monkey patching
2024-05-09 12:24:41 +10:00
Maikel Linke
d6318b7194
Remove mocking of deleted Order methods
2024-05-09 11:14:13 +10:00
Maikel Linke
9320ed0559
And less stubbing is better.
...
[skip ci]
2024-05-09 11:14:13 +10:00
Anthony Musyoki
0d03cdf815
Fix Rubocop: Delete dependent stock_movements
2024-04-23 13:13:26 +03:00
Anthony Musyoki
4f851bbe1f
Fix Rubocop: Do not delete dependent stock_movements
2024-04-23 12:31:43 +03:00
Anthony Musyoki
1ec453df4d
Fix Rubocop issue: Do not delete addresses having shipments
...
The reasoning is that we should not delete an address that has
ever received a shipment
2024-04-23 12:31:43 +03:00
Konrad
27a4202fa4
Merge pull request #12357 from mkllnk/fix-invoice-order
...
Fix: preserve order of invoices in bulk print
2024-04-11 12:47:14 +02:00
Maikel
082b1f9411
Merge pull request #12300 from mkllnk/checkout-steps
...
Remove unnecessary method checkout_steps
2024-04-11 15:57:45 +10:00
Maikel Linke
c2c7910357
Reset I18n.local for each spec
...
This avoids a locale setting leaking from one spec to another. It also
means that we don't have to reset the locale in individual specs.
Also:
- `cookies` is reset automatically and we don't need to do that.
- Removed some unused code (German number format and helper methods).
2024-04-11 10:14:52 +10:00
Ahmed Ejaz
b2172ef8d8
12332 - Add around block to apply default_locale on specs
2024-04-11 10:14:52 +10:00
Ahmed Ejaz
693b9bd171
12332 - Fix rubocop Rails/I18nLocaleAssignment errors
...
- use I18n.with_locale method rather than direct locale assignment
2024-04-11 10:13:50 +10:00
Maikel Linke
48b447500f
Move selection of invoicable orders to database
...
It's more efficient and should allow for further optimisations.
2024-04-10 16:52:56 +10:00
Ana Nunes da Silva
939605cb7a
Fix offense constant definition in block in models/spree/preferences/preferable_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
b18fe8ce35
Fix offense constant definition in block in models/spree/preferences/configuration_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
fc3d7f8496
Fix offense constant definition in block in models/spree/gateway_spec.rb
2024-04-08 11:16:38 +01:00
Ana Nunes da Silva
3bd6c85f3b
Fix offense constant definition in block in models/spree/ability_spec.rb
2024-04-08 11:16:38 +01:00
Maikel
cf9414a352
Merge pull request #12329 from openfoodfoundation/dependabot/bundler/rubocop-rspec-2.28.0
...
chore(deps-dev): bump rubocop-rspec from 2.27.1 to 2.28.0
2024-04-04 13:43:02 +11:00
David Cook
6cff5c81fe
Fix RSpecRails/NegationBeValid
...
Another cop that only supports not_to instead of to_not.
2024-04-04 09:41:05 +11:00
David Cook
af2e3ca703
Merge pull request #12326 from filipefurtad0/deletes_connected_accounts_after_specs
...
Removes Stripe accounts created for testing purposes
2024-04-03 10:37:17 +11:00
Matt-Yorkley
d3e62c4390
Add test for persisting taxon on variant during product creation
2024-04-02 09:43:24 +11:00
Matt-Yorkley
8a364a5f48
Fix product touch spec
2024-04-02 09:43:24 +11:00
Matt-Yorkley
d9899e8af6
Update more specs
2024-04-02 09:27:36 +11:00
filipefurtad0
c611754272
Removes connected account
...
Re-records relevant VCR-cassette on stripe_sca_spec
2024-04-01 11:36:51 +01:00
Maikel
4c1268b3ce
Merge pull request #12274 from mkllnk/dfc-product-import
...
Import products from DFC catalog
2024-03-22 09:25:02 +11:00
Maikel Linke
54738fc552
Remove unnecessary method checkout_steps
...
It allowed introspection of a dynamic state machine. But the only two
usages of this method only referred to the first state which is always
the same. Our complicated checkout logic needs more clarity and
introducing some hardcoded state names here can only help.
2024-03-21 13:43:54 +11:00
Feruz Oripov
9d919938f3
Group Order && OrderCycle related services and specs
2024-03-16 19:07:08 +05:00
Maikel Linke
d47d3eba8f
Add SemanticLink model for variants
...
We want to link variants/products to external DFC SuppliedProducts to
trigger supplier orders when local stock is exhausted. This is the first
step to enable the link.
2024-03-15 16:46:41 +11:00
Maikel Linke
bd6b0ddbf3
Enforce RSpec expect(..).not_to over to_not
2024-03-07 16:57:54 +11:00
David Cook
250f7be8a0
Re-organise spec
2024-02-23 12:36:42 +11:00
David Cook
b758bf0735
Fix spec
2024-02-23 12:36:10 +11:00
David Cook
2107aeded1
Un-safely autocorrect RSpec/ExpectChange
2024-02-23 12:17:09 +11:00
Maikel Linke
07a8617143
Store OIDC account data in new model
2024-02-22 10:15:07 +11:00
Gaetan Craig-Riou
848767d50f
Per review, clean up test set up
2024-02-19 10:58:31 +11:00
Gaetan Craig-Riou
89236f4c2f
Per review, create a Stripe account
...
It's better to avoid hard coded stripe entities
2024-02-19 10:58:31 +11:00
Gaetan Craig-Riou
657f71c357
Further refactor payment specs
...
- remove any stub_request
- use intance_double of ActiveMerchant::Billing::Response
2024-02-19 10:58:31 +11:00
Gaetan Craig-Riou
8832f2fef6
Refactor #credit spec
...
Model spec shouldn't know about the undelying call to stripe. Replaced
request stubs by payment method stubs.
Consolidate #credit spec in one `describe` block
2024-02-19 10:58:31 +11:00
Gaetan Craig-Riou
0af9ccd17a
Add test for #credit
...
it uses ActiveMerchant::Billing::StripePaymentIntentsGateway#refund,
we covering the last scenario that previously used the decorator.
2024-02-19 10:58:31 +11:00
Gaetan Craig-Riou
549610bc35
Finally remove StripePaymentIntentsGateway decorator
...
Add spec for Spree::Gateway::StripeSCA#void
It also partially fix 11670, refund of Stripe payment should now work
for complete order
2024-02-19 10:58:31 +11:00
filipefurtad0
edae56345b
Removes unnecessary Stripe api key / secret declaration
2024-02-08 14:53:48 +00:00
Konrad
ca12eab4bb
Merge pull request #11985 from chahmedejaz/task/11768-add-voucher-in-enterprise-fees-with-tax-by-order-report
...
Include vouchers in report: Enterprise Fees With Tax Report By Order
2024-01-24 22:57:48 +01:00
Konrad
ec4bbe6241
Merge pull request #12038 from mkllnk/dfc-tax-category
...
Spec requiring tax category when creating products
2024-01-24 16:26:57 +01:00
Ahmed Ejaz
cb9c2963af
11768: add roundoff
...
- Fix lint issues
2024-01-19 01:52:24 +05:00
Ahmed Ejaz
a3592cb14a
11768: add specs
...
- For applied_voucher_rate method in order
2024-01-19 01:52:24 +05:00
binarygit
95a51159d7
send-shipment-email-optionally
2024-01-14 15:05:59 +05:45
Maikel Linke
95c6a56e2e
Simplify loading of default tax category
...
The logic doesn't change but I simplified it and added more detailed
specs.
2024-01-12 17:06:24 +11:00
