Ahmed Ejaz
fb07794cf3
12398: add slide-out animation
2024-05-28 01:10:30 +05:00
David Cook
e0c60aad48
Display red border around invalid selects
...
I developed this while going down a slightly different path. I tested it visually, but the case I tested doesn't exist. I'm confident it will work if we ever have an error on another select though.
2024-05-16 14:21:44 +10:00
Ahmed Ejaz
269e69852c
11060: add style rule for the small gap
2024-05-07 14:59:14 +02:00
Ahmed Ejaz
2fdaa8b9ec
11060 - implement the scenario 2 and 3
2024-05-07 14:59:14 +02:00
David Cook
508ebab75b
Add loading spinner to turbo frame
...
That was surprisingly easy. Note that it's still shared with SR.
It hides a bit early though: when the web response returns, but before the DOM has been rendered. Something to optimise in the future.
2024-04-17 15:17:59 +10:00
David Cook
9d6ef2f730
Avoid style issues with Turbo
...
But the filter dropdowns still get duplicated. So weird..
2024-04-17 15:17:59 +10:00
David Cook
2c71f7f1ed
Discard changes by reloading the page
...
Now there's a popup asking to confirm, which I think is worth keeping!
2024-04-10 15:17:56 +01:00
David Cook
6291cce5d1
Fix style for empty popout button
...
There's still an odd 1px height change on hover that I can't track down. I think it would be better to just give new variants a default of 1 (blank is not valid anyway).
2024-03-27 17:35:09 +11:00
David Cook
e589605e3c
Rename popout style classes
2024-03-27 17:35:08 +11:00
David Cook
e94fddb0f8
Style label in popout
...
And tweaked global style as per design.
And cleanup unused classes.
2024-03-27 14:34:31 +11:00
David Cook
4f7d50ca4b
Refactor CSS to reduce scope
...
We don't want the fields inside the popout to be naked, so need to be more specific.
2024-03-27 14:34:31 +11:00
David Cook
f13f2cfa2f
Move values to variables
...
I didn't end up using these, but it's probably worth keeping for consistency.
2024-03-27 14:34:31 +11:00
David Cook
29d3b34776
Increase dropdown height
2024-03-06 17:12:15 +11:00
David Cook
8612f7baab
Only add extra padding on alignment edge
...
Saves a few precious pixels on the other edge.
2024-03-06 14:10:54 +11:00
David Cook
e770f10f2b
Tomselect has minimum width
2024-03-06 14:10:54 +11:00
David Cook
cbcf388acc
Ensure gap between fields wrapped over a line
2024-03-06 14:10:51 +11:00
David Cook
bfd6319cf2
Mark tom-select as changed
...
Thankfully I was able to use basic DOM features, so there's no coupling of the logic with tom-select.
It wasn't going to be simple to get tom-select to listen for the 'changed' class on the original select, so I found a simple solution with a CSS sibling selector instead.
2024-03-06 13:41:22 +11:00
David Cook
af748158aa
Hide chevron until hover to allow a bit more space for text
2024-03-06 13:41:22 +11:00
David Cook
864b876a9a
Add tom-select with naked style
...
The rem units are converted to em to make the padding relative to the chevron size. This means different font sizes will Just Work.
2024-03-06 13:41:22 +11:00
David Cook
8f0e9c9f5c
Remove unnecessary selector
...
I can't see any reason that fieldsets, which are containers, should share styles with inputs. Maybe font styles, but everything looks fine still.
2024-03-06 13:01:44 +11:00
David Cook
958288b223
Move input styles to form stylesheet
...
A better way to arrange it, and as a bonus it makes the selectors simpler, yay!
2024-03-06 13:01:44 +11:00
David Cook
5cfac3d2c7
Add comments
2024-02-29 10:10:57 +11:00
cyrillefr
f62b32a3b9
Requested changes after review
...
- modified css to increase clicking area
- modified spec to more straightfoward and more user oriented link
2024-02-28 08:15:34 +01:00
cyrillefr
884d6f15ff
Replace a divs controller by an html details one
...
- checked_controller close details element on checkboxes
- dropdown_controller.js is to rebuild controller from many divs
to be hidden and visible to an html detail elmnt one
- details html element styling
2024-02-25 16:43:57 +01:00
David Cook
7e186091ff
Ensure un-changed field error state shows
...
When there is a required field that can't be empty. I knew these complex styles would come back to bite me.
◉ Best viewed with whitespace ignored
2024-02-15 10:36:45 +11:00
David Cook
c65771eac6
Add new 'naked' button
...
I couldn't think of a better name.
2024-02-15 10:36:45 +11:00
David Cook
50b325c944
Annotate and arrange scss
2024-02-15 10:36:45 +11:00
Rachel Arnould
164bac63e0
Merge pull request #12130 from dacook/buu/modal-styles-11065
...
[BUU] Image modal styles
2024-02-14 16:12:32 +01:00
David Cook
5e4dd3864f
Update image and modal size
...
Using a new 'fit' modal size.
On smaller screens, we need to allow the image to shrink. That's a good general rule, but I was hesitant to make it a global rule..
2024-02-07 12:48:44 +11:00
David Cook
6189feadaa
Prevent modal covered by scrollbar
...
Using units relative to the document, rather than the screen.
I don't think that remaining min-height should be there at all, but reveal-modal is used a lot so I don't know for sure.
2024-02-06 14:56:39 +11:00
David Cook
8c6d3a27ec
Move modal action styles to parent component
...
They were already being shared with a HelpModalComponent in fact.
2024-02-06 14:34:36 +11:00
David Cook
262823bddd
Ensure On Demand field doesn't overflow following cell
2024-02-01 11:56:40 +11:00
David Cook
3d941dcc1f
Adjust popout position
...
Now it's lined up perfectly with the number input.
2024-02-01 11:18:15 +11:00
David Cook
ae1fabae38
Tweak padding according to design
2024-02-01 11:18:15 +11:00
David Cook
627863bdf7
Fix up button colour variables
2024-01-16 13:45:02 +11:00
David Cook
c67f0c52a2
Show edit button only when hover image
...
This required some branching in the haml, which would be nice to avoid. But we have more work to do here so we'll refactor at the end.
2024-01-16 13:45:02 +11:00
David Cook
137489f492
Refactor: move basic modal styles to generic parent component
...
The style was already being shared with a sibling component.
Now we can instantiate a plain old 'modal'.
2024-01-16 12:53:07 +11:00
David Cook
ca73a9ab62
Reduce space used by image
2024-01-16 12:53:07 +11:00
David Cook
1f61b03796
Add image with edit button
...
With a new 'mini' button style.
For now, it's just a shortcut to the image edit page.
2024-01-16 12:50:31 +11:00
Rachel Arnould
877a145874
Merge branch 'master' into buu-dropdown-tweaks-11518
2024-01-12 10:40:19 +01:00
Rachel Arnould
6ff2be17c6
Merge pull request #12023 from dacook/buu/sticky_table_header_and_saving_banner-2
...
[BUU] Sticky table header and saving banner - alternate solution
2024-01-11 15:23:06 +01:00
Konrad
19dd5b110c
Merge pull request #12009 from chahmedejaz/bugfix/11971-tos-position-issue
...
Fix ToS Position Issue
2024-01-10 19:36:57 +01:00
David Cook
0bb0e1674e
Remove unused rule
...
I forgot to remove this before.
2024-01-10 16:41:47 +11:00
David Cook
443b3134df
Tweak padding
...
I'm not sure why this requires extra padding here, but it looks good 🤷
Co-authored-by: Mario Carabotta <6696729+mariocarabotta@users.noreply.github.com >
2024-01-10 14:26:56 +11:00
David Cook
792dc2cb36
Add shadow
2024-01-10 14:15:10 +11:00
David Cook
c3e513e457
Move .form-actions into table, to allow sticky stacking
...
Unfortunately, it's not possible to stack two sticky elements that are inside different containers:
https://stackoverflow.com/questions/54689034/pure-css-multiple-stacked-position-sticky
So instead I've moved them under the same container. The .form-actions needs to cover up some of the table border.
I don't like the deep nesting of markup or class naming.. pls suggest if you have better ideas!
2024-01-10 12:33:41 +11:00
David Cook
47418d9873
Merge pull request #12014 from mkllnk/voucher-on
...
Remove feature toggle for vouchers, they are always on
2024-01-10 09:58:35 +11:00
David Cook
4f27bea02f
Make table header sticky
...
But it overlaps the .form-actions. how to make them sticky together..
todo: register the z-index in variables.scss
2024-01-09 17:07:37 +11:00
David Cook
e48d009668
Hide #sort section instead of covering it
...
Before, the .form-actions was overlaying it, to avoid making the table below jump. But if the .form-actions and #sort are the same height, it won't jump when we swap them.
It does make the table jump in the case of a multi-line .form-actions message, but that only happens after submit anyway.
This is needed for the next commit..
2024-01-09 13:11:49 +11:00
David Cook
2defc4afa7
Ensure form-actions content uses available space
...
Using pre-defined colunms was a hacky short term solution, this way is more flexible.
2024-01-09 12:34:05 +11:00
