Matt-Yorkley
525cb4826f
Code review refactoring
2018-02-07 10:41:53 +11:00
Matt-Yorkley
9248ac05ac
Adjustments for failing specs
2018-02-07 10:41:53 +11:00
Matt-Yorkley
4d11485283
Use receives_notifications flag for enterprise contact
2018-02-07 10:41:53 +11:00
Matt-Yorkley
15b781b271
Update enterprise managers and contact role
2018-02-07 10:41:52 +11:00
Matt-Yorkley
ba98c7e2c5
Rewrite enterprise contact functionality
2018-02-07 10:41:52 +11:00
Matt-Yorkley
22eae753fe
Remove enterprise confirmations
2018-02-07 10:41:52 +11:00
Pierre de Lacroix
eb1c598a6c
Fix tests
2018-02-07 10:41:51 +11:00
Matt-Yorkley
969b6caa96
Code cleanup
2018-02-07 10:41:51 +11:00
Pierre de Lacroix
dbbc2ddb1c
Add confirmable email to user model
2018-02-07 10:41:51 +11:00
Pau Pérez Fabregat
99729457cc
Merge pull request #2063 from coopdevs/autocorrect-cop
...
Autocorrect rubocop Layout/BlockEndNewline cop
2018-02-05 08:50:58 +01:00
Pau Perez
6cb038c362
Autocorrect rubocop Layout/BlockEndNewline cop
2018-02-01 09:52:53 +01:00
Pau Perez
f57661b13f
Fix payment_method_decorator boot-time warning
...
Removes the annoying message "warning: already initialized constant
Spree::PaymentMethod::DISPLAY" that appears 4 times when booting the
app.
We are declaring said constant exactly as our Spree version does so
there's no point on repeating work.
2018-01-15 12:50:05 +01:00
Enrico Stano
660d3f326f
Remove unused Enterprise scopes
2017-12-20 16:00:35 +11:00
Enrico Stano
01b0a033fd
Merge pull request #1904 from oeoeaio/spree-test-config
...
Use Spree's approach for preventing config caching when testing
2017-12-04 15:57:11 +11:00
Pierre de Lacroix
a49c21cfd1
Add instance switch to enable number localization
2017-12-01 13:37:24 +11:00
Pierre de Lacroix
2cd570383f
Use localize_number in models
2017-12-01 13:37:24 +11:00
Rob Harrington
9052b1c3db
A few updates to spec where 'be true' and 'be false' didn't cut it
2017-11-10 08:47:12 +11:00
Rob Harrington
cd6d7c76f6
Fix spec that requires preference persistence
2017-11-02 17:43:04 +11:00
Rob Harrington
d42dc2b286
Fix #1902 : ensure correct payment state when failed payments are present
...
Problem: order payments didn't seem to be loaded in any particular order,
and OrderUpdater#update_payment_state was relying on payment order to de-
termine payment state.
Strategy: Adapt a version of this method from a future version of Spree.
I tried to select a version where I would have to make the absolute mini-
mum number of changes to get it to work. See comments in code for justif-
ications of the changes that I did make.
2017-10-20 15:21:59 +11:00
Rob Harrington
b7976a2356
Do not update finalized fee adjustments
2017-10-19 16:54:39 +11:00
Rob Harrington
f96502c369
Add unit specs for CheckoutController#restart_checkout
2017-10-13 12:53:35 +11:00
Rob Harrington
c031b0e52b
Clear shipments and payments after failed payment at checkout
2017-10-13 12:53:35 +11:00
Duende13
e5fb8712d7
Simplify Product Edit Screen removing fields and adding 2 new menu options for seo and group buy ( #1741 )
2017-10-13 11:37:57 +11:00
Rob Harrington
f2ad087be5
Change inheritance of StripeAccountsController
2017-10-13 07:57:16 +11:00
Rob Harrington
75ec77dc31
Remove the 'confirm' step from the order checkout flow
...
This step is not being responded to anyway, since we are not rending a page for each checkout step
It was causing an issue whereby an order in the 'confirm' state was not able to progress through the
checkout controller because it was expecting to only redirect to paypal from the 'payment' state.
figured it was easiest to just remove the step, seeing as it wasn't being used in any meaningful way.
It should be fine to bring the 'confirm' step back in the future if we need it, we will just have to
make sure paypal the paypal issue is resolved.
2017-09-23 15:15:06 +10:00
Rob Harrington
a09a54e4cb
Set transaction fee adjustments to ineligible if payment is invalid or failed
2017-09-23 15:15:06 +10:00
Rob Harrington
db5503dd80
Allow destruction of StripeAccounts even if deauthorise request fails
...
Log deauthorise failures to Bugsnag
2017-09-23 14:58:35 +10:00
Rob Harrington
ba61f94906
Expose Stripe token creation error messages in Checkout
2017-09-23 14:58:35 +10:00
Rob Harrington
7c82fa3d44
Show more helpful payment processing error in checkout
2017-09-23 14:58:35 +10:00
Rob Harrington
098afc62c1
Fix rubocop issues
2017-09-23 14:58:34 +10:00
Rob Harrington
a74c502fd9
Refactor logic for creating a payment profile from a Stripe token into a service object
2017-09-23 14:58:34 +10:00
Rob Harrington
4464a85a74
Add missing controller specs for CreditCardController #destroy
2017-09-23 14:58:34 +10:00
Rob Harrington
ca1987fc87
Prevent Stripe payment methods without account owners from being saved
2017-09-23 14:58:34 +10:00
Rob Harrington
ecef905444
Allow Stripe-based payments to be voided (refunded)
2017-09-23 14:58:34 +10:00
Maikel Linke
5b7e2f7ca8
Apply style guide
2017-09-23 14:58:34 +10:00
stveep
da5c907e0f
Add/remove comments from PR feedback
2017-09-23 14:58:33 +10:00
Rob Harrington
98317e96d0
Remove unused stripe action abilities
2017-09-23 14:58:33 +10:00
Rob Harrington
3b78179dea
Ask customer about saving card details used in checkout
2017-09-23 14:58:33 +10:00
Rob Harrington
8901af897a
Store card details submitted via checkout
2017-09-23 14:58:33 +10:00
Rob Harrington
576e4db9be
Authorize StripeAccount#status using the account object
...
Rather than the enterprise
2017-09-23 14:58:33 +10:00
Rob Harrington
ce65a9d063
Bump stripe gem version to 3.0.1
...
Allows us to use the stripe gem's built-in OAuth wrappers, rather than our own
2017-09-23 14:58:33 +10:00
Rob Harrington
0e14704572
Kill empty space
2017-09-23 14:58:33 +10:00
Rob Harrington
e9d062a8c2
Use nested module/class definitions instead of compact style
2017-09-23 14:58:33 +10:00
Rob Harrington
f3af36deca
Disable rubocop Style/PredicateName check against override of Spree method
2017-09-23 14:58:32 +10:00
Rob Harrington
ecb78233d9
Use guard clauses where possible
2017-09-23 14:58:32 +10:00
Rob Harrington
42dd58426e
Auto-correct rubocop offences for stripe-connect
2017-09-23 14:58:32 +10:00
Rob Harrington
c83755f901
Clean up StripeConnect gateway
2017-09-23 14:58:32 +10:00
Rob Harrington
ae2d3d3fd9
Refactoring StripeHelper into service objects
2017-09-23 14:58:32 +10:00
Rob Harrington
01ce092ebc
Handle Stripe token creation request failure
2017-09-23 14:58:32 +10:00
Rob Harrington
6499d17cb1
Adding feature toggle config variable for Stripe Connect
2017-09-23 14:58:32 +10:00
