Rob Harrington
09b800672d
Fix specs to handle non-deterministic ordering
2018-02-09 14:44:15 +11:00
Rob Harrington
b7876ebfbf
Replace references to 'standing order' with 'subscription' (spec)
2018-02-09 14:44:14 +11:00
Rob Harrington
902802594f
Renaming standing order files (lib, spec)
2018-02-09 14:44:13 +11:00
Rob Harrington
e7eb02dfe3
Reduce cognitive complexity of VariantsController#search
2018-02-09 14:44:12 +11:00
Rob Harrington
ceab1fe16a
Reduce cognitive complexity of StandingOrderPaymentUpdater
2018-02-09 14:44:11 +11:00
Rob Harrington
8ba1a909ca
Use summarizer for standing order confirm job
2018-02-09 14:44:08 +11:00
Rob Harrington
b49c44f7ce
Generalise record_failure method to record_and_log_error
2018-02-09 14:44:08 +11:00
Rob Harrington
13d01df4d8
Add mail method and template for sending placement summary emails to shop owners
2018-02-09 14:44:08 +11:00
Rob Harrington
cf30b7c883
Add service objects for summarizing outcomes of standing order processing jobs
2018-02-09 14:44:08 +11:00
Rob Harrington
03f1980b1b
Auto-correct rubocop offences for standing-orders
2018-02-09 14:44:07 +11:00
Rob Harrington
26a325e6e0
Handle payment processing errors for standing orders
2018-02-09 14:44:07 +11:00
Rob Harrington
2576d10e49
Create a new payment when none is present
2018-02-09 14:44:07 +11:00
Rob Harrington
146348a4fe
Refactor proxy order syncer using direct sql query for increased speed
2018-02-09 14:44:06 +11:00
Rob Harrington
3aee0b5e70
Allow proxy order syncer to accept both ActiveRecord::Relation or StandingOrder
2018-02-09 14:44:06 +11:00
Rob Harrington
6d5c920a95
Split proxy order sync logic out into dedicated service object
2018-02-09 14:44:06 +11:00
Rob Harrington
dfe874cf3f
Attempt to add a credit card before processing payment
2018-02-09 14:44:04 +11:00
Rob Harrington
f4f6fb6a7a
Update and process standing order payments prior to confirmation
2018-02-09 14:44:04 +11:00
Rob Harrington
c5066bb613
Making AddressFinder a little more secure
...
Only allow search by email when a customer or user with matching email is also provided
2018-02-09 14:43:59 +11:00
Rob Harrington
4a0dab3608
Renaming LastUsedAddress as AddressFinder
2018-02-09 14:43:59 +11:00
Rob Harrington
1b72b7258d
Refactoring LastUsedAddress to take customers or users
2018-02-09 14:43:58 +11:00
Rob Harrington
6ea4aac361
WIP: Refactoring StandingOrderUpdater into StandingOrderForm
...
Update logic coupled to update action on controller rather than changes to the model
2018-02-09 14:43:38 +11:00
Rob Harrington
0b35cb6619
Standing Order Updater handles changes to line item quantities
2018-02-09 14:43:38 +11:00
Rob Harrington
9468dcb406
Adding lib class to maintain standing order orders
2018-02-09 14:43:38 +11:00
Rob Harrington
c18c1c67d1
Adding visibility permissions for standing orders
2018-02-09 14:43:32 +11:00
Matt-Yorkley
22eae753fe
Remove enterprise confirmations
2018-02-07 10:41:52 +11:00
Pau Perez
6cb038c362
Autocorrect rubocop Layout/BlockEndNewline cop
2018-02-01 09:52:53 +01:00
Enrico Stano
114ce3b764
Merge pull request #1940 from coopdevs/improve-readability-shop
...
Improve readability of shop's code
2017-12-20 16:28:53 +11:00
Pierre de Lacroix
f67a8c1f2d
Add tests
2017-12-01 13:37:24 +11:00
Rob Harrington
6c38997010
Fix 1664: product tag rules not working
...
Caused by a combination of: fe7bd5e2cd38d3b446cc
2017-11-15 10:26:24 +11:00
Rob Harrington
59578a73af
Changing all references to 'be_true' and 'be_false' to 'be true' and 'be false'
...
See next commit for changes where this substitution was broken
2017-11-10 08:47:12 +11:00
Pau Perez
84e4ebef08
Do not notify Bugsnag of a cache miss
...
It's not the responsibility of a error tracking software to track
neither cache misses nor logs. That is what log monitoring is for.
2017-11-09 10:22:31 +01:00
Pau Perez
98603c4042
Do not test private methods
2017-11-09 10:22:31 +01:00
Pau Perez
26a4ee0171
Do not stub object under test
2017-11-09 10:22:31 +01:00
Pau Perez
4f03a2d25c
Remove unnecessary require
2017-11-09 10:22:31 +01:00
Rob Harrington
01f9fd3232
Rename webhook handler status mappings
2017-10-12 22:47:51 +11:00
Rob Harrington
ed375a1e2c
Build Event object in controller instead of service object
2017-10-12 20:51:17 +11:00
Rob Harrington
4345285164
Allow more granularity in Stripe WebhookHandler responses
2017-10-12 20:51:17 +11:00
Rob Harrington
f22dd7513d
Add a service object for handling Stripe webhooks
2017-10-11 17:50:46 +11:00
Rob Harrington
665749d0c5
Refactor Stripe::AccountConnector
...
Connector now handles cancellation of the connection wizard by the user more elegantly
2017-09-23 14:58:35 +10:00
Rob Harrington
44ba499ad9
Stub rather than set Stripe api_key in specs
2017-09-23 14:58:33 +10:00
Rob Harrington
ce65a9d063
Bump stripe gem version to 3.0.1
...
Allows us to use the stripe gem's built-in OAuth wrappers, rather than our own
2017-09-23 14:58:33 +10:00
Rob Harrington
5b675cbaba
Make OAuth private methods actually private
2017-09-23 14:58:32 +10:00
Rob Harrington
42dd58426e
Auto-correct rubocop offences for stripe-connect
2017-09-23 14:58:32 +10:00
Rob Harrington
ae2d3d3fd9
Refactoring StripeHelper into service objects
2017-09-23 14:58:32 +10:00
Pau Perez
1f2820f6d4
Add #delivery? in ShippingMethod
2017-08-11 14:41:02 +10:00
Pau Perez
22f018f2bc
Fix all specs of LastUsedAddress
2017-08-11 14:41:02 +10:00
Julius Pabrinkis
974099747b
Fix failing specs after text extraction
2017-07-21 12:17:12 +10:00
Pau Perez
cee24dcca7
Use indented style for multiline method calls
...
This enables the Rubocop's Style/MultilineMethodCallIndentation cop with
indentend enforced style. Which makes you split multiline method calls like:
orders = Spree::Order
.an_scope
.another_scope
.where(id: list_of_ids)
It also autofixes the current violations and updates the
rubocop_todo.yml
2017-07-12 10:40:53 +02:00
Rob Harrington
28ea23965b
Rubocop: Correct Lint/AmbiguousOperator offences
2017-06-23 16:49:08 +10:00
Rob Harrington
b277ff03ea
Rubocop: Auto-correct Style/TrailingBlankLines offences
2017-06-23 16:49:07 +10:00
