Gaetan Craig-Riou
5371258125
Merge pull request #12366 from openfoodfoundation/dependabot/bundler/stripe-11.0.0
...
chore(deps): bump stripe from 10.15.0 to 11.0.0
2024-04-16 09:16:49 +10:00
Maikel Linke
d9ec6e2ca3
Wait longer for real Stripe responses
...
When we re-record cassettes, I noticed this spec failing. We may need to
add this parameter to more specs.
2024-04-12 12:34:26 +10:00
filipefurtad0
fd54a12bcb
Moves methods to end of the file
2024-04-11 12:36:47 +01:00
filipefurtad0
f4108e97c7
Improves regression spec after reviewer feedback
...
Removes shared_examples, defines a separate method
Removes pending to bring spec to green
2024-04-11 12:33:10 +01:00
Konrad
27a4202fa4
Merge pull request #12357 from mkllnk/fix-invoice-order
...
Fix: preserve order of invoices in bulk print
2024-04-11 12:47:14 +02:00
Maikel Linke
c2c7910357
Reset I18n.local for each spec
...
This avoids a locale setting leaking from one spec to another. It also
means that we don't have to reset the locale in individual specs.
Also:
- `cookies` is reset automatically and we don't need to do that.
- Removed some unused code (German number format and helper methods).
2024-04-11 10:14:52 +10:00
Ahmed Ejaz
693b9bd171
12332 - Fix rubocop Rails/I18nLocaleAssignment errors
...
- use I18n.with_locale method rather than direct locale assignment
2024-04-11 10:13:50 +10:00
David Cook
e78ef120f4
TODO
...
I think this case got lost.
2024-04-10 15:17:56 +01:00
David Cook
fd8be37a62
Use shared page controls on products screen
...
This has an auto submit and can potentially work with Turbo, like on the Orders screen.
2024-04-10 15:17:56 +01:00
David Cook
0fc3d39106
Ensure pagination is retained when saving or discarding
...
But we have more work to do.
2024-04-10 15:17:56 +01:00
David Cook
2c71f7f1ed
Discard changes by reloading the page
...
Now there's a popup asking to confirm, which I think is worth keeping!
2024-04-10 15:17:56 +01:00
David Cook
8696e05e66
Move index and bulk_update actions to good ol' HTTP requests
...
We've found that we just can't rely in StimulusReflex (and the underlying WebSockets stack) to guarantee a response to a request.
Because of this, there was intermittent issues when the server was overloaded with large requests, and the response never arrived, leaving an infinite loader, and a poor user wondering if anything was still happening.
2024-04-10 15:17:56 +01:00
Maikel Linke
16c877f7cb
Fix: preserve order of invoices in bulk print
2024-04-10 14:51:55 +10:00
Maikel Linke
1d8b942acd
Fix spec for invoice ordering
2024-04-10 14:03:25 +10:00
David Cook
d4da684f4a
Merge pull request #12349 from openfoodfoundation/dependabot/bundler/rubocop-1.63.0
...
chore(deps-dev): bump rubocop from 1.62.1 to 1.63.0
2024-04-10 10:32:32 +10:00
Maikel
c9c94fcaa5
Merge pull request #12337 from cyrillefr/FixRailsNegateIncludeRubocopIssue
...
Fix Rubocop Rails/NegateInclude issues
2024-04-09 10:40:47 +10:00
Gaetan Craig-Riou
103c6e7fc0
Remove debugging line
2024-04-09 10:30:46 +10:00
filipefurtad0
8ad4f885a0
Adds shared example for descending name ordering
2024-04-07 17:15:12 +01:00
filipefurtad0
f618ef1201
Adds regression spec for S2 bug #12340
2024-04-05 14:46:52 +01:00
cyrillefr
2877c793f8
Attempt to get rid of flaky spec #10027
2024-04-05 10:07:06 +02:00
David Cook
af2e3ca703
Merge pull request #12326 from filipefurtad0/deletes_connected_accounts_after_specs
...
Removes Stripe accounts created for testing purposes
2024-04-03 10:37:17 +11:00
Matt-Yorkley
a55931c081
Reinstate sorting by arbitrary list of product categories
2024-04-02 09:42:43 +11:00
Matt-Yorkley
2743a8183d
Disable sorting by user-defined product category order
2024-04-02 09:33:34 +11:00
Matt-Yorkley
d9899e8af6
Update more specs
2024-04-02 09:27:36 +11:00
filipefurtad0
66b98bd477
Removes connected account
...
Re-records relevant VCR-cassette on payments_stripe_spec
2024-04-01 11:36:09 +01:00
David Cook
266e94eba8
Fixup spec
2024-03-27 20:20:20 +11:00
David Cook
1d8ed67b0b
Handle unit scale changes
...
As discussed, this is the desired behaviour. The current screen appears to do this, but fails to save the changes.
2024-03-27 20:20:20 +11:00
David Cook
4ddb2ff1e9
Generate unit display with OptionValueNamer
2024-03-27 20:20:20 +11:00
David Cook
cf31d09ad8
Prevent submitting empty value
2024-03-27 20:20:20 +11:00
David Cook
49226ffdbc
Extract unit_value and unit_description values
...
Copied from display_as.js.coffee (ofn.admin.ofnDisplayAs.variantUnitProperties).
2024-03-27 20:20:20 +11:00
David Cook
436f733213
Add variant unit fields
...
Unfortunately we can't use an input[type=number] because you're allowed to type text for unit_description.
These fields will be conditionally shown/hidden in upcoming steps.
2024-03-27 14:34:31 +11:00
David Cook
189cd88848
Remove duplicate spec
...
Must have been an accident while merging conflicts
2024-03-27 14:33:32 +11:00
David Cook
9b040d87f6
Update spec
2024-03-27 14:33:32 +11:00
Maikel
4c1268b3ce
Merge pull request #12274 from mkllnk/dfc-product-import
...
Import products from DFC catalog
2024-03-22 09:25:02 +11:00
Anthony Musyoki
25e3f30f97
Fix Rubocop Rails issue: Rails/FindEach
2024-03-20 15:34:30 +03:00
David Cook
acb53a6ddc
Merge pull request #12273 from mkllnk/rubocop
...
Rubocop
2024-03-19 10:14:01 +11:00
Feruz Oripov
bdcb0856af
Fix failed specs
2024-03-16 19:23:17 +05:00
Feruz Oripov
9d919938f3
Group Order && OrderCycle related services and specs
2024-03-16 19:07:08 +05:00
Maikel Linke
3af7fa7521
Offer nice select box for enterprise id
2024-03-15 16:46:41 +11:00
Maikel Linke
30e8f9eb28
Importing products from DFC catalog
...
Technical demonstration of a complete product export-import roundtrip
which we could now do between OFN instances.
2024-03-15 16:46:41 +11:00
Maikel Linke
477336c660
Style RSpec/NotToNot
2024-03-15 12:17:48 +11:00
Maikel Linke
96ccea3691
Add controller to handle import of DFC products
...
It's not doing anything yet, but this is the basic setup.
2024-03-15 11:40:10 +11:00
Maikel
696559200f
Merge pull request #12267 from cyrillefr/BUU-Improve-Product-Search-Keywords
...
Add tests to the search product feature
2024-03-15 10:36:07 +11:00
Konrad
acc52cc45f
Merge pull request #11918 from abdellani/11896-prevent_bulk_printing_sending_when_ABN_not_set
...
Bulk printing/sending should show warning if ABN is required but not set.
2024-03-14 13:33:41 +01:00
cyrillefr
261cb2d81b
Requested changes: trimming number of examples
...
- to improve speed of testing
2024-03-14 10:55:09 +01:00
cyrillefr
43d13253e7
Add tests to the search product feature
2024-03-13 10:54:06 +01:00
Gaetan Craig-Riou
ff52a66e75
Merge pull request #12250 from mkllnk/not-to-not
...
Enforce RSpec expect(..).not_to over to_not
2024-03-12 10:35:16 +11:00
cyrillefr
7d99197dde
Requested changes: original fix moved up in code
...
- instead of selecting out unapplied tax rates in the total tax
method, did it in the query_result instead. Reverted the
total_excl_tax method to its initial state.
- spec and logic of testing affected also.
2024-03-11 10:13:46 +01:00
cyrillefr
62739c0458
Requested changes in spec
...
- use of new service instead of manually advancing an order
2024-03-11 10:13:46 +01:00
cyrillefr
7fdf1a110d
Fix incorrect results for multiple tax rates in report
...
- total_excl_tax would sum amounts and taxes without
knowledge if taxes rates were really applied or not
- spec shows use case described in issue 12066
2024-03-11 10:13:46 +01:00
