Matt-Yorkley
9f49a84e7f
Clarify use of access tokens used for viewing order details as a guest user
...
There are 4 or 5 different places in the app where we reference a :token and params[:token] for completely different purposes (they're not even vaguely the *same* token).
This is an attempt to clarify the places in the app where we use params[:token] in relation to *orders*, for allowing guest users (who are not logged in) to view details of an order they have placed (like after checkout completion), and differentiate it from the various other places where params[:token] can actually be used for something entirely different!
2021-12-16 13:35:55 +00:00
Matt-Yorkley
35e20fc179
Can sort orders via bill_address.lastname
...
We only need to check the orders sort
Fix ordering in api/v0/orders_controller_spec
2021-12-16 09:33:38 +01:00
Matt-Yorkley
45beefc533
Keep the order of passed argument
...
Do not retrieve the orders list sorted by completed_at but by the order_ids array itself
Add BulkInvoiceJob spec and cover sorting behaviour
2021-12-16 09:33:38 +01:00
Jean-Baptiste Bellet
7a48ffdd38
Add order.full_name as new column
...
+ add the linked sortable header via `bill_address_lastname`
2021-12-16 09:26:49 +01:00
Jean-Baptiste Bellet
9c280ee612
add new line
2021-12-16 09:26:49 +01:00
Matt-Yorkley
b77ff346a3
Replace #raise with #return in Checkout::StripeRedirect
...
The (potential) unhappy code path here was raising an error which would not be explicitly handled, and would in theory not return a useful message / response.
2021-12-15 21:20:58 +00:00
Matt-Yorkley
0fc4b851f2
Refactor payment gateway redirects handling
...
The checkout was holding a lot of responsibility for knowing which kinds of payment gateways are available and how to initiate the process of redirecting to the external payment page (if needed). This was being hidden somewhat by the way the logic was tucked away in services.
PaymentMethod objects now know whether or not they require an external payment process, and know how that process should be started and how to build the required URL.
So we can now *ask* any payment method if it requires external payment processing or not, and *tell* it to start the process and return the relevant URL (if needed).
2021-12-15 21:20:58 +00:00
Filipe
fd94f26765
Merge pull request #8557 from Matt-Yorkley/card-brand-formatting
...
Credit card brand formatting
2021-12-15 20:18:21 +00:00
Filipe
f6385215d3
Merge pull request #8568 from Matt-Yorkley/paypal-controller
...
Move paypal controller
2021-12-15 18:12:27 +00:00
Filipe
c4f4d67fc0
Merge pull request #8503 from jibees/split-checkout-payment-forms
...
Split checkout payment forms
2021-12-15 12:57:03 +00:00
Nihal M. Kelanthodika
44c3820a8f
Update units when variant unit name is edited
2021-12-15 12:30:10 +05:30
Maikel Linke
bc50a01953
Ensure deterministic query to avoid deadlocks
2021-12-14 11:33:16 +11:00
Maikel Linke
9b6c9bd773
Synchronise processing of proxy orders
2021-12-14 11:33:16 +11:00
Maikel Linke
ce0913758b
Bring initial proxy order processing closer
...
We want to make it one transaction soon.
2021-12-14 11:33:16 +11:00
Matt-Yorkley
3800eb0eef
Merge pull request #8610 from Matt-Yorkley/user-class
...
Remove Spree.user_class
2021-12-13 15:52:00 +00:00
Matt-Yorkley
aecdfee364
Reorganise :though associations on line_item and allow searching/filtering on product, supplier, order_cycle
2021-12-12 13:23:56 +00:00
Matt-Yorkley
1efaa7e726
Switch search filters from orders to line_items
2021-12-12 13:23:56 +00:00
Filipe
f7087842b4
Merge pull request #8556 from sinansonmez/8546-include-navigation-only-for-super-admins
...
Navigation is included only for super admin users
2021-12-11 16:34:10 +00:00
Sebastian Castro
e20a8122b1
Make the shop filter section always visible when scrolling
2021-12-10 20:53:47 +01:00
Sebastian Castro
8fe125bd1b
Adds thin-scroll-bar class
2021-12-10 20:53:47 +01:00
Matt-Yorkley
6d2521bf5f
Remove Spree.user_class
...
This construct was previously used in Spree to switch out the user class with a dummy class during certain tests. We don't use this any more, so it's just mess.
🔥
2021-12-10 18:18:20 +00:00
Matt-Yorkley
f101b06226
Update all references to paypal routes
2021-12-10 11:46:53 +00:00
Matt-Yorkley
0d620aac94
Move paypal_controller out of spree namespace
2021-12-10 11:46:52 +00:00
Maikel Linke
207cc8908a
Remove useless assignments
...
Rubocop highlighted this. The todo list actually contains these files
but somehow the cop still runs and reports these as violations.
2021-12-10 09:26:57 +11:00
Maikel Linke
64d25b2999
Remove dead code highlighted by Rubocop
...
The assignments here didn't actually do anything and `number` was
restricted to numbers only already. No whitespace to remove.
2021-12-10 09:26:57 +11:00
Jean-Baptiste Bellet
a80818d2b6
Fix rubocop warning
...
Extra empty line detected at module body end.
2021-12-09 11:30:57 +01:00
jibees
53e12fb5e5
Get rid of conditional branches with & operator
...
Co-authored-by: Maikel <maikel@email.org.au >
2021-12-09 11:12:23 +01:00
Sebastian Castro
bce9fc5b4e
Style all standard select as the text input
2021-12-09 10:09:39 +01:00
Sebastian Castro
18d966f0de
Closes #8441 Confirmation popup on shop change
2021-12-08 13:34:15 +01:00
Sebastian Castro
8624d11585
products-index: Hide html component with ng-cloak
2021-12-08 12:44:58 +01:00
Maikel
65e5291679
Merge pull request #8569 from Matt-Yorkley/dead-code-backordered
...
Remove dead code: Order#backordered?
2021-12-08 18:05:38 +11:00
Matt-Yorkley
83fafe9969
Fix stripe elements styling
...
The selectors are different now that we're not using Angular to build the stripe card element.
2021-12-07 16:46:42 +00:00
Matt-Yorkley
d22cb0e1e1
Add billing address name to card
2021-12-07 16:29:25 +00:00
Matt-Yorkley
6b8c91845e
Update strong params
2021-12-07 16:29:25 +00:00
Matt-Yorkley
2fe96c5f63
Update Stripe controller hidden fields
2021-12-07 16:29:25 +00:00
Matt-Yorkley
9979ecf8b4
Update view to use new Stimulus controller for Stripe card form
2021-12-07 16:29:25 +00:00
Matt-Yorkley
cbd7b37eb3
Change card field name
...
The order[card] field is already in use / needed for other data 👍
2021-12-07 16:29:25 +00:00
Matt-Yorkley
720d147421
Bring in stimulus controller for stripe elements
2021-12-07 16:29:25 +00:00
Matt-Yorkley
7f4b2cc00a
Tidy up checks on Enumerable objects
2021-12-07 16:29:25 +00:00
Matt-Yorkley
ce7fb1b4dc
Move select-options-formatting logic to helper
2021-12-07 16:29:25 +00:00
Matt-Yorkley
d85597fe4c
Rename stripe cards controller
2021-12-07 16:29:25 +00:00
Matt-Yorkley
8105f0ebf3
Simplify partial selecting and rename stripe_sca partial
2021-12-07 16:29:25 +00:00
Jean-Baptiste Bellet
33887e8b6e
Remove wrong min attribute on input
2021-12-07 16:27:22 +00:00
Jean-Baptiste Bellet
fd5ad7566a
Disabled all form elements that should not be sent to the controller
2021-12-07 16:27:22 +00:00
Jean-Baptiste Bellet
f7662947dc
Extract to a method that handle all the form elements
2021-12-07 16:27:22 +00:00
Jean-Baptiste Bellet
fbe69b8027
Manage savedCards or enter new card behavior for stripe payment form
2021-12-07 16:27:22 +00:00
Jean-Baptiste Bellet
7437c6a6d7
Add a stripe controller that show/hide stripe form if saved cards or not
2021-12-07 16:27:22 +00:00
Jean-Baptiste Bellet
34ce08d901
Format card label in card selector
2021-12-07 16:27:22 +00:00
Jean-Baptiste Bellet
68e4d55f80
Avoid ternary operator
2021-12-07 16:27:22 +00:00
Jean-Baptiste Bellet
f9b0798c88
Add stripe_sca, paypal, check payment method
...
Stripe_sca use the same template than stripe
2021-12-07 16:27:22 +00:00
