David Rodríguez
05b3e97a0e
Bump Ruby from 3.1.7 to 3.2.9
...
Release announcements:
* https://www.ruby-lang.org/en/news/2025/07/24/ruby-3-2-9-released/
* https://www.ruby-lang.org/en/news/2025/03/26/ruby-3-2-8-released/
* https://www.ruby-lang.org/en/news/2025/02/04/ruby-3-2-7-released/
* https://www.ruby-lang.org/en/news/2024/10/30/ruby-3-2-6-released/
* https://www.ruby-lang.org/en/news/2024/07/26/ruby-3-2-5-released/
* https://www.ruby-lang.org/en/news/2024/04/23/ruby-3-2-4-released/
* https://www.ruby-lang.org/en/news/2024/01/18/ruby-3-2-3-released/
* https://www.ruby-lang.org/en/news/2023/03/30/ruby-3-2-2-released/
* https://www.ruby-lang.org/en/news/2023/02/08/ruby-3-2-1-released/
* https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/
Also autocorrect new offenses.
2025-10-31 09:18:11 +01:00
David Rodríguez
4c6d894bc0
Bump RuboCop to 1.86.6
...
There were a few changes needed:
* Plugins are now specified through `plugin:` config keyword.
* All plugin gems need to be specified explicitly in Gemfile since they
are no longer dependencies of plugins already specified explicitly.
* All plugin gems need to be updated in other to use the new APIs.
* One cop was renamed.
* New offenses safe to correct were corrected directly with `bundle exec
rubocop -a`.
* New offenses unsafe to correct were added to the TODO configuration
with `bundle exec rubocop --auto-gen-config --auto-gen-only-exclude
--exclude-limit 1400 --no-auto-gen-timestamp`.
2025-10-27 11:30:33 +01:00
Rachel Arnould
c4c266246c
Merge pull request #13507 from rioug/tag-rules-remove-angular
...
[Variant Tags] Remove angular from tag rule admin page
2025-10-15 23:16:05 +02:00
Maikel Linke
7a12e7426f
Pass actors instead of AR associations to Flipper
...
Apparently they removed support for checking collections of actors.
2025-10-14 13:32:51 +11:00
Maikel Linke
f2f0d954c6
Move source of truth of platforms into one place
...
The first test tokens had an inconsistent client_id and I had to
introduce multiple mappings to get the right config. But that has been
harmonised and we can put the config in one place.
2025-10-10 16:18:22 +11:00
Gaetan Craig-Riou
afdc40d230
Move helper function to component
...
It's only used in the component so there is no need to keep it as an
helper.
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
d3ef744daf
Display existing grouped tag rules
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
35d37639af
Refactor tag rule filter input
...
Consolidated four partials into one
2025-09-24 10:38:53 +10:00
Gaetan Craig-Riou
11006c3a60
Display default rule
2025-09-24 10:36:21 +10:00
Cillian O'Ruanaidh
6f7a547e15
Add a :link_to_or_disabled helper method
2025-09-05 09:38:20 +01:00
Cillian O'Ruanaidh
23c9410a25
Replace darker-background angular directive
2025-09-05 09:38:20 +01:00
Andrey Usyaev
3d7799df19
Fix code review remarks
2025-08-27 13:21:44 +03:00
Andrey Usyaev
5f02d88a86
Fix missed I18n translations for enterprises sells options
2025-08-27 13:21:44 +03:00
Maikel Linke
b3d3d6bf06
Allow DPM feature for specific users
2025-08-11 15:25:50 +10:00
Maikel Linke
f65e4797cf
Add feature toggle for DFC dev platform
2025-08-08 14:00:40 +10:00
Filipe
76aebf8a72
Merge pull request #13436 from chahmedejaz/task/13432-decommission-old-products-screen
...
Decommission Old Products UI and Related Code
2025-08-07 17:39:43 +02:00
David Cook
661bb29029
Remove unused method
...
The name doesn't appear in the codebase so I guess it's unused.
2025-07-28 13:19:16 +10:00
Ahmed Ejaz
6e055ddbdf
Remove icon parameters from admin navigation tabs for simplification
2025-07-27 06:32:44 +05:00
Ahmed Ejaz
025fc784a8
Refactor products_return_to_url method to remove url_filters parameter and simplify usage in views
2025-07-27 06:26:12 +05:00
Gaetan Craig-Riou
dc84d32028
Disable link to inventory related settings for enterprise
...
Metrics/CyclomaticComplexity is disabled on `enterprise_side_menu_items`
because even though there is a lot of branching it's still readable
2025-07-09 11:35:26 +10:00
Ahmed Ejaz
a37e08c2fd
Refactor order management permissions for producers
...
Introduces granular permissions control for producers editing orders:
- Adds new :edit_as_producer_only permission for suppliers
- Refactors ability checks to clearly separate producer vs admin/distributor access
- Updates order views to properly restrict actions based on user role
- Prevents admins from being restricted by producer-only edit mode
2025-06-21 16:16:58 +05:00
Filipe
6ccc588113
Merge pull request #13342 from chitty/cch/refactor-unit-price
...
refactor: move unit price formatting logic out of model into helper
2025-06-19 16:19:03 +01:00
Carlos Chitty
f909bb2c30
Add respond_to_missing? to classes defining method_missing to improve respond_to? behavior
2025-06-18 13:59:42 -04:00
Carlos Chitty
3dcc4428fa
Fix escaped HTML in unit price by marking output as html_safe
2025-06-16 12:53:41 +01:00
Carlos Chitty
85e4f749f9
refactor: move unit price formatting logic out of model into helper
...
Solves Psych::DisallowedClass errors
Example: https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/14739687958/job/41374343627?pr=13232
unit_price returns object with amount and unit, as mentioned in https://github.com/openfoodfoundation/openfoodnetwork/pull/6905\#discussion_r578401368
2025-06-16 12:53:41 +01:00
Cillian O'Ruanaidh
65efd3b66c
Render confirm remove image modal outside of form so a simple :button_to can be used instead of submitting via Stimulus controller.
2025-05-02 13:07:31 +01:00
Ahmed Ejaz
87c957541d
refactor: fix rubocop lint issues
2025-04-13 21:35:55 +05:00
Ahmed Ejaz
213209b460
hide customer info on bulk orders page
2025-04-13 21:35:55 +05:00
Ahmed Ejaz
a4f1f542be
rename distributor_allows_order_editing to filter_by_supplier
2025-04-13 21:35:55 +05:00
Ahmed Ejaz
bc3917ebc1
incorporate show_customer_names_to_suppliers setting
2025-04-13 21:35:55 +05:00
Ahmed Ejaz
19c5fec9a9
add ability update supplier line_items in orders
2025-04-13 21:35:55 +05:00
Carlos Chitty
ecb303fef5
Correct Style/SlicingWithRange rubocop offenses
2025-03-26 11:16:24 -04:00
Maikel Linke
64a8b5845a
Add feature toggle open_in_same_tab for admin dashboard
...
This allows us to test what users actually want.
2025-03-11 16:38:51 +11:00
Maikel Linke
ed926e9e26
Remove unnecessary storage of checkout zone
2025-01-21 20:11:05 +01:00
Filipe
a472f3e4f5
Merge pull request #13068 from vishaldeepak/variant-with-tax
...
New variants should inherit tax category in UI
2025-01-17 10:57:22 -06:00
Filipe
3c1dd10219
Merge pull request #13047 from mkllnk/spree-roles
...
Clarify that our only user role is "admin" and simplify code
2025-01-16 18:06:49 -06:00
Vishal Deepak
1586c8ef28
New varaints should inherit tax category in UI
2025-01-10 13:30:18 +05:30
Maikel Linke
54f83b45c8
Replace has_spree_role? with simpler admin?
...
We have only one role, so let's get rid of the unneeded method.
Now we are in a better place to get rid of Spree::Role and replace it
with a simple boolean.
2024-12-19 09:19:01 +11:00
Manuel Gonçalves
3199118bae
Removed the :selected attribute when the tax category is not required (like original version)
2024-12-03 08:54:35 +00:00
Manuel Gonçalves
980f86ce89
Fixed the lint errors
2024-12-02 21:22:12 +00:00
Manuel Gonçalves
d95bb7736a
Fixed the logic and moved the code to a helper file
2024-12-01 20:43:31 +00:00
Maikel Linke
2b8487cc6d
Parse given datetime for reports properly
2024-10-17 15:08:02 +11:00
Gaetan Craig-Riou
0695b434a2
Fix rebase issue
2024-10-14 15:01:18 +11:00
Gaetan Craig-Riou
4ad6971121
Fix Bulk product edit system spec after rebase
2024-10-14 15:01:18 +11:00
Ahmed Ejaz
5be53a40a9
11200: rename products scope
2024-09-11 11:54:38 +05:00
Ahmed Ejaz
76fdf3725a
11200: add explanations
2024-09-11 11:41:01 +05:00
Ahmed Ejaz
f8d3467d46
11200: add specs
2024-09-11 01:59:43 +05:00
Ahmed Ejaz
1580d539df
11200: coniditonally hide producer column
2024-09-11 00:56:52 +05:00
Joseph Johansen
66b519bd1c
Undo minor unneeded changes
2024-08-22 17:41:00 +02:00
Joseph Johansen
1b8e256e8a
Add unit tests
2024-08-22 17:41:00 +02:00