David Rodríguez
4c6d894bc0
Bump RuboCop to 1.86.6
...
There were a few changes needed:
* Plugins are now specified through `plugin:` config keyword.
* All plugin gems need to be specified explicitly in Gemfile since they
are no longer dependencies of plugins already specified explicitly.
* All plugin gems need to be updated in other to use the new APIs.
* One cop was renamed.
* New offenses safe to correct were corrected directly with `bundle exec
rubocop -a`.
* New offenses unsafe to correct were added to the TODO configuration
with `bundle exec rubocop --auto-gen-config --auto-gen-only-exclude
--exclude-limit 1400 --no-auto-gen-timestamp`.
2025-10-27 11:30:33 +01:00
Carlos Chitty
d0c687650e
Autocorrect Style/HashEachMethods offenses
2025-04-29 15:16:34 -04:00
Neal Chambers
a363f88f2c
Put Subscriptions back into Schedules Controller
2023-08-24 09:18:35 +09:00
Neal Chambers
134cbb4f04
Add Form Object to Fix Metrics/ClassLength
2023-08-24 09:17:53 +09:00
Neal Chambers
186d7a2f54
Move and Rename BulkUpdateForm
2023-07-18 08:17:34 +09:00
Neal Chambers
fb1ae855c2
Fix Metrics/ClassLength
2023-07-18 08:17:34 +09:00
Rob Harrington
0c302b022a
Move StandingOrderForm to app/services folder
2018-02-09 14:44:09 +11:00
Rob Harrington
4362ef2cea
Properly translate all error messages for StandingOrderForm
2018-02-09 14:44:09 +11:00
Rob Harrington
84ad996ef8
Use guard clauses
2018-02-09 14:44:07 +11:00
Rob Harrington
03f1980b1b
Auto-correct rubocop offences for standing-orders
2018-02-09 14:44:07 +11:00
Rob Harrington
3aee0b5e70
Allow proxy order syncer to accept both ActiveRecord::Relation or StandingOrder
2018-02-09 14:44:06 +11:00
Rob Harrington
6d5c920a95
Split proxy order sync logic out into dedicated service object
2018-02-09 14:44:06 +11:00
Rob Harrington
ac8e09bc11
Add credit card validation to StandingOrderForm
2018-02-09 14:44:04 +11:00
Rob Harrington
25907d8969
Prevent standing order form from accepting non cash/stripe payment methods
2018-02-09 14:44:03 +11:00
Rob Harrington
6081db382c
Updating addresses on standing order updates addresses on any initialised orders
2018-02-09 14:44:03 +11:00
Rob Harrington
42266397aa
Improving performance of available variant lookup for standing orders
...
Only search the DB for available variants once
2018-02-09 14:44:01 +11:00
Rob Harrington
ad2506fe75
Require StandingOrders to have at least one product (StandingLineItem)
2018-02-09 14:44:01 +11:00
Rob Harrington
7dcd39986f
Refactoring StandingOrder validations and errors
...
Moving validations to StandingOrderForm
2018-02-09 14:44:01 +11:00
Rob Harrington
9e986f25f1
Orders are not marked as problematic if the changed value matches the new value
2018-02-09 14:43:57 +11:00
Rob Harrington
e357a7b401
StandingOrderForm: Storing problematic orders for reporting to user
2018-02-09 14:43:57 +11:00
Rob Harrington
9f50253537
StandingOrderForm: Rescuing from RecordInvalid when saving
2018-02-09 14:43:57 +11:00
Rob Harrington
1e8767e8b5
StandingOrderForm: Small refactor, update initialised orders one-by-one
2018-02-09 14:43:57 +11:00
Rob Harrington
875557dc9d
WIP: ProxyOrders don't require an order, fixing remainder of specs
2018-02-09 14:43:55 +11:00
Rob Harrington
4b440c83a4
WIP: ProxyOrders don't require an order, StandingOrderForm changes
2018-02-09 14:43:55 +11:00
Rob Harrington
e29a4f9a8a
Moving order initialisation logic from StandingOrderForm to ProxyOrder model
2018-02-09 14:43:54 +11:00
Rob Harrington
64206bc35b
ProxyOrders belong to order cycles
2018-02-09 14:43:54 +11:00
Rob Harrington
e351c3e355
Renaming StandingOrderOrder to ProxyOrder
2018-02-09 14:43:54 +11:00
Rob Harrington
9bf3767093
Preventing line item stock level checks when updating standing orders
2018-02-09 14:43:54 +11:00
Rob Harrington
a57815edbb
Refactoring standing line item delete logic
...
Using StandingOrderForm rather than separate endpoint
2018-02-09 14:43:47 +11:00
Rob Harrington
4c754e2cdb
Ensuring that new standing_line_items are added to orders and totals are updated
2018-02-09 14:43:47 +11:00
Rob Harrington
f4cbd90400
Storing estimated prices for standing line items in the database
2018-02-09 14:43:46 +11:00
Rob Harrington
8ab698d4dc
Generating orders for standing orders ignores stock on hand at initialisation
2018-02-09 14:43:42 +11:00
Rob Harrington
9ad6dce2d6
WIP, SO placement job: processing orders to completion
2018-02-09 14:43:39 +11:00
Rob Harrington
95a7fc8ef5
Initialisation and removal of standing order orders respects begins_at and ends_at contraints
2018-02-09 14:43:39 +11:00
Rob Harrington
3eff65f1f5
Finish refactoring of Standing Order Updaters, replacing with form class used by controller
2018-02-09 14:43:38 +11:00
Rob Harrington
2a3dc33f86
WIP: Pushing shipment and payment update logic down into separate methods
2018-02-09 14:43:38 +11:00
Rob Harrington
6ea4aac361
WIP: Refactoring StandingOrderUpdater into StandingOrderForm
...
Update logic coupled to update action on controller rather than changes to the model
2018-02-09 14:43:38 +11:00
