Filipe
97ceed6cbe
Merge pull request #13263 from chahmedejaz/bugfix/13180-oc-search-on-bom
...
Fix Order Cycle search on BOM page is not working for more than 5 OCs
2025-05-16 10:59:55 +01:00
Maikel
277c51cd51
Merge pull request #13327 from cyrillefr/FixRSpecRailsHttpStatus
...
Fixes RSpec Rails HttpStatus offenses
2025-05-16 15:41:06 +10:00
Filipe
3efa2832de
Merge pull request #13257 from ashishp91/13221-make-shipped-orders-uneditable
...
13221 - Don't allow shipped orders to be editable
2025-05-15 19:23:33 +01:00
cyrillefr
529f3b85eb
Fixes RSpec Rails HttpStatus offenses
2025-05-15 08:46:02 +02:00
cyrillefr
7f842d77ea
Fixes RSpec Rails HaveHttpStatus cop in services & support
2025-05-14 11:47:03 +02:00
cyrillefr
8135aeaeda
Fixes RSpec Rails HaveHttpStatus cop in requests
2025-05-14 11:04:01 +02:00
cyrillefr
5063a772f0
Fixes RSpec Rails HaveHttpStatus cop in controllers
2025-05-14 10:58:04 +02:00
cyrillefr
f810e500b5
Fixes RSpec Rails HaveHttpStatus cop in api v0
2025-05-14 10:46:36 +02:00
cyrillefr
b9e1eb2984
Fixes RSpecRails HaveHttpStatus cop in admin specs
2025-05-14 10:28:57 +02:00
Filipe
371d0fbf79
Merge pull request #13281 from rioug/13172-search-by-tags
...
[Variant tags] Search products by tags
2025-05-14 07:38:59 +01:00
David Cook
71b65b4b98
Merge pull request #13306 from cyrillefr/FixRubocopNamingVariableNumber
...
Fixes Rubocop naming variable number
2025-05-14 09:39:32 +10:00
David Cook
ffea1cca81
Replace JB's method with mine
...
Obviously I'm biased, but I like mine better.
2025-05-13 14:52:20 +10:00
David Cook
d62740da10
Update helper to exclude line items
...
_scrolls down_ Oh... JB already did that 😆
Nice to see we were thinking along the same lines.
2025-05-13 14:52:06 +10:00
David Cook
fa9ed1a66b
Add expectation for other line items
2025-05-13 14:42:46 +10:00
David Cook
3b1f267465
Declare which line items are being expected.
2025-05-13 14:41:03 +10:00
David Cook
cf30b792f9
Refactor: move shared code to context
2025-05-13 14:40:41 +10:00
David Cook
6daf94875a
Rename varianbles based on OC number
...
It was a bit confusing that they don't line up.
2025-05-13 14:23:51 +10:00
Ahmed Ejaz
db0922a7cf
13180: increase filter time to 1 year
2025-05-12 01:14:51 +05:00
Ashish Gaur
71949701ac
Merge branch 'master' into 13221-make-shipped-orders-uneditable
2025-05-08 21:56:46 +05:30
Filipe
d8fa3e2a19
Merge pull request #13292 from mkllnk/oc-notify
...
Process order cycle emails individually to avoid duplicates
2025-05-08 13:15:00 +01:00
cyrillefr
42daf314c4
Fixes variable number naming offenses in spec variables
2025-05-08 09:28:01 +02:00
Maikel
5d4f8313f3
Merge pull request #13305 from filipefurtad0/split_system_specs
...
Split system specs
2025-05-08 10:40:57 +10:00
Maikel
4ef17d3794
Merge pull request #13300 from filipefurtad0/fix_flaky_simple_spec_again
...
Adds tests to toggle the css sections (distributed products)
2025-05-08 10:39:17 +10:00
Maikel
bc3f847a9d
Merge pull request #13299 from cyrillefr/FixRubocopNamingMethodParameterName
...
Fixes NamingMethodParameterName rubocop offense
2025-05-08 10:34:50 +10:00
Gaetan Craig-Riou
eb1919cce9
Update spec/system/admin/products_v3/index_spec.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2025-05-07 14:58:41 +10:00
Gaetan Craig-Riou
532ce7a4d7
Merge pull request #13298 from dacook/cleanup-address-finder
...
Cleanup AddressFinder
2025-05-07 12:16:04 +10:00
filipefurtad0
af8059c22f
Splits shopping_spec
2025-05-06 18:08:51 +01:00
filipefurtad0
e7edc068ef
Splits order_spec
2025-05-06 17:25:01 +01:00
filipefurtad0
81d35741a1
Adds tests to toggle the css sections
...
It's a lucky guess, but the idea is that pre-loading the CSS sections and its contents makes it slightly faster, for following assertions, which are the flaky offenders
2025-05-05 19:50:32 +01:00
Ashish Gaur
5fc3fe03ee
13221 Add spec for checking flash error is shown when editing a shipped order
2025-05-05 20:37:59 +05:30
Ashish Gaur
e122fe3d2d
13221 Use have_select2 in rspec to test s2id matcher
2025-05-05 20:03:47 +05:30
Ashish Gaur
58b6a97d3e
Add spec for order not editable after shipping
2025-05-05 20:03:47 +05:30
cyrillefr
f6df412355
Fixes NamingMethodParameterName rubocop offense
2025-05-05 10:39:15 +02:00
Maikel
45a0185744
Merge pull request #13279 from filipefurtad0/reproduce_12933_stock_reset
...
Reproduces bug #12933 , setting the test case as pending
2025-05-05 14:58:41 +10:00
Gaetan Craig-Riou
347d20c3fb
Add system test for tags
2025-05-05 14:57:02 +10:00
Gaetan Craig-Riou
8c1c51cb6d
Put tag filter behind feature flag
2025-05-05 14:54:55 +10:00
Gaetan Craig-Riou
57af1de680
Remove closeAfterSelect option
...
We need the dropdown to stay open after select so that a multi-selection
select work as expected.
Docs : https://tom-select.js.org/docs/
2025-05-05 14:54:55 +10:00
David Cook
0225db6840
Refactor without setter methods
...
This class was originally built to flexibly accept paramters in any order. It also allowed you to specify multiple of the same type of parameter, with the later one overriding the earlier.
This is too flexible and likely to cause mistakes. And besides, we don't use that feature!
2025-05-05 12:59:27 +10:00
David Cook
3ec14607a6
Merge pull request #13286 from chitty/apr29-rubocop-style-corrections
...
Rubocop Style corrections
2025-05-05 12:53:57 +10:00
David Cook
eadfa8c965
Update from code review
...
Co-authored-by: Gaetan Craig-Riou <40413322+rioug@users.noreply.github.com >
2025-05-05 12:09:58 +10:00
Filipe
846cb4dd89
Merge pull request #13252 from rioug/13159-add-tag-variant
...
[Variant tags] Add variant tag on Bulk Edit Product screen
2025-05-03 17:34:51 +01:00
Maikel Linke
8daa01e228
Process OC emails individually to avoid duplicates
...
Errors or delays can cause multiple duplicate emails to the same
suppliers.
2025-05-02 16:58:00 +10:00
Carlos Chitty
d0c687650e
Autocorrect Style/HashEachMethods offenses
2025-04-29 15:16:34 -04:00
Carlos Chitty
446be6e127
Fix test failure due to hash interpreted as block in matcher
...
Wrap hash in parentheses to ensure it's passed as an argument rather than a block.
2025-04-29 15:16:29 -04:00
Carlos Chitty
63168086e7
Autocorrect Style/HashConversion offenses
2025-04-29 14:27:31 -04:00
Carlos Chitty
17a5b5e620
autocorrect Style/ArrayIntersect offenses
2025-04-29 14:20:50 -04:00
Filipe
69bb78e39c
Merge pull request #13213 from chahmedejaz/task/13128-add-order-number-to-notify-producer-email
...
Add order number to notify producer emails and make customer code available for everyone
2025-04-29 18:22:06 +01:00
Ahmed Ejaz
6f9b5e2c54
fix specs
...
- add a new class .line-items in the orders-summary to better differentiate the line-items summary vs customer-details. This css class is not defined, just .customer-order for customer details. It's only used to make a differentiation in the specs
- use the updated `parsed_email` memoized helper method for mail body content
2025-04-28 15:11:54 +05:00
Ahmed Ejaz
57c30591bc
13128: add order number in OC report
...
- Make Customer Code independant of Customer Names setting
2025-04-28 15:11:52 +05:00
piyush828-design
0bb6860343
Merge branch 'master' into pagy_upgrade
2025-04-28 11:23:44 +05:30
