Jean-Baptiste Bellet
bcd306ebd4
Authorize payment email could be send to guest user
...
Always send the email to the order.email value
2022-02-17 09:40:28 +01:00
Jean-Baptiste Bellet
012e91879a
preselect the only available shipping method
2022-02-17 09:33:23 +01:00
Jean-Baptiste Bellet
716286497e
Add test to cover "preselect the shipping method" if only one is available
...
+ do not preselect if more than one are available
2022-02-17 09:33:23 +01:00
Jean-Baptiste Bellet
7be2f418d0
preselect the only available payment method
2022-02-17 09:33:23 +01:00
Jean-Baptiste Bellet
0e053a2601
Add test to cover "preselect the payment method" if only one is available
...
+ do not preselect if more than one
2022-02-17 09:33:23 +01:00
Matt-Yorkley
00fa84e3b5
Sync when switching from nil dates to open
2022-02-16 21:45:43 +00:00
Matt-Yorkley
5913720c85
Sync for both open and upcoming OCs when switching from closed
2022-02-16 18:33:09 +00:00
Matt-Yorkley
4592827261
Sync OC subscriptions if transitioning from closed to open
2022-02-16 13:03:27 +00:00
Matt-Yorkley
4260422ea7
Remove a couple of unnecessary memory assignments
2022-02-16 12:55:19 +00:00
Matt-Yorkley
d4488fdb3f
Return early if OC is closed
2022-02-16 12:53:22 +00:00
Matt-Yorkley
8c8b9d1b23
Sync subscriptions on newly-cloned order cycles
2022-02-16 10:44:22 +00:00
SarvarKhalimov
22de758e3a
Add spec for product import validation
2022-02-16 14:17:35 +05:00
Maikel Linke
33969de371
Allow shared_examples to have more than 25 lines
2022-02-16 11:41:28 +11:00
Maikel Linke
a6dee77071
Style
2022-02-16 10:33:49 +11:00
filipefurtad0
78946f908a
Adds shared examples; sets conditional filters on test cases
2022-02-15 23:23:31 +00:00
Matt-Yorkley
4c50ca69ea
Improve data migration logic and add test coverage
2022-02-16 10:23:24 +11:00
Matt-Yorkley
fd815a6af6
Don't change Customer factory name generating logic
2022-02-16 10:23:24 +11:00
Matt-Yorkley
feaa92406a
Split migration into two parts for easier testing
2022-02-16 10:23:24 +11:00
Maikel Linke
68193efcf6
Keep old customers.name column for compatibilty
...
Our app code will try to access the old attribute while the migration is
running. That would lead to errors during checkout.
2022-02-16 10:23:24 +11:00
François Turbelin
9a12957e27
Handle the empty-space name on customers
2022-02-16 10:23:23 +11:00
François Turbelin
de4d074cb3
Remove bill_address fetching logic
2022-02-16 10:23:23 +11:00
Maikel Linke
d09ba16411
Associate customers again
...
And simplify the before_validation actions.
2022-02-16 10:23:23 +11:00
Maikel Linke
07314af3f6
Spec customer record association more realistically
...
The newly added specs were tested on the master branch and passed. But
the previous commit broke one test case which I marked as pending here.
The removed specs are completely replaced by the new ones. Their main
downside was to test only small bits of internal behaviour without
considering the whole callback chain of the order. The new specs are
more realistic and catch bugs like mentioned above.
2022-02-16 10:23:23 +11:00
François Turbelin
554a8625e5
Refactor ensure_customer method
2022-02-16 10:23:23 +11:00
François Turbelin
5c9dd81595
Deal with nil attirubtes on bill_address
2022-02-16 10:23:23 +11:00
François Turbelin
6d986deb2d
Remove translation changes from locale file
2022-02-16 10:23:23 +11:00
François Turbelin
4cb31d04a7
Repair specs with default values on ensure_customer method
2022-02-16 10:23:23 +11:00
François Turbelin
50302163c0
Update migration with better logic and cosmetics
2022-02-16 10:23:23 +11:00
François Turbelin
9682b9256b
Arrange classes loading for good migration
2022-02-16 10:23:23 +11:00
François Turbelin
d016c47789
Refactor data migration to use data sets
2022-02-16 10:23:23 +11:00
François Turbelin
b8afb7ec4d
Add default values for new fields
2022-02-16 10:23:23 +11:00
François Turbelin
836a60a6c7
Add missing full_name bind to subscriptions serializer
2022-02-16 10:23:23 +11:00
François Turbelin
23776c7a3e
Fix more specs
2022-02-16 10:23:23 +11:00
François Turbelin
75345a95af
Update customer factory
2022-02-16 10:23:22 +11:00
François Turbelin
eefd9891d6
Add en translations
2022-02-16 10:23:22 +11:00
François Turbelin
7c25127ab6
Improve first_name and last_name setup
2022-02-16 10:23:22 +11:00
Adrien Chauve
ca46359224
More fixes
2022-02-16 10:23:22 +11:00
Adrien Chauve
9b93102a96
More fixes
2022-02-16 10:23:22 +11:00
Adrien Chauve
ba6523bb76
Add Customer.full_name
2022-02-16 10:23:22 +11:00
Adrien Chauve
5ca4d549e7
Update customer creation
2022-02-16 10:23:22 +11:00
Adrien Chauve
d0f347efaa
Add migration to split Customers.name into first and last names
2022-02-16 10:23:22 +11:00
Jean-Baptiste Bellet
405b7e6e17
Handle tax rates for ShippingMethod
...
Co-Authored-By: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com >
2022-02-15 15:16:58 +01:00
Matt-Yorkley
711a51f2ff
Remove .eligible scope
...
In this case we actually expect there to be no payment fee adjustments at all on the payment, regardless of their eligibility.
2022-02-15 12:24:28 +00:00
Matt-Yorkley
5fba7811c4
Remove #try
...
#try is useful when the object might be nil or might not respond to the given method. In this case we expect it to exist and respond to #finalized?, so this is a bit more precise.
2022-02-15 12:21:34 +00:00
Matt-Yorkley
5be1b139b9
Replace .stub with expect(x).to receive(:y)
...
The #stub method is slightly deprecated syntax. Using #expect has the additional benefit here of failing if the object does not receive the expected method call.
2022-02-15 12:19:15 +00:00
Matt-Yorkley
8084ad0068
Extract a comment-method so the code conveys it's purpose
2022-02-15 12:17:08 +00:00
Nihal M. Kelanthodika
b017420319
Add specs to check ensure payment method fee is not applied when crediting/refunding order
2022-02-15 11:52:26 +00:00
Nihal M. Kelanthodika
9215ccc353
Prevents creation of payment adnustment when refunding or crediting an order
2022-02-15 11:52:26 +00:00
Matt-Yorkley
7c7a09a75c
Merge pull request #8880 from openfoodfoundation/dependabot/npm_and_yarn/storybook/addon-controls-6.4.19
...
Bump @storybook/addon-controls from 6.4.18 to 6.4.19
2022-02-15 11:33:04 +00:00
Matt-Yorkley
0d2374f07e
Merge pull request #8881 from openfoodfoundation/dependabot/npm_and_yarn/storybook/server-6.4.19
...
Bump @storybook/server from 6.4.18 to 6.4.19
2022-02-15 11:32:47 +00:00
