Luis Ramos
|
41ff406e86
|
Fix rubocop issue by avoiding rails method name update_attributes
|
2020-06-22 16:51:46 +01:00 |
|
Luis Ramos
|
f848a89a00
|
Rename update_attributes to update #rails4
|
2020-06-22 16:51:43 +01:00 |
|
Luis Ramos
|
777754f8a9
|
Remove dead code that creates products in product_set
|
2020-03-02 19:41:51 +00:00 |
|
luisramos0
|
9404aacfb2
|
run rubocop --auto-correct
|
2019-11-10 18:42:43 +00:00 |
|
luisramos0
|
0dc8ae1561
|
Merging find_product and find_variant into one single method
This fixes rubocop issue, class has too many lines
|
2019-10-27 20:09:42 +00:00 |
|
luisramos0
|
07fcc8f361
|
Refactor ExchangeVariantDeleter.new.delete out of update_product_only_attributes into correct place update_product
Also extracted find_product from update_attributes and find_variant out of create_or_update_variant to make code simpler
|
2019-10-27 19:13:57 +00:00 |
|
luisramos0
|
f57c9d4a25
|
Fix rubocop issue in product_set.update_product_only_attributes: method has too many lines
|
2019-10-21 15:20:53 +01:00 |
|
luisramos0
|
783c3c9e90
|
Add spec to product set to cover case where product and variants attributes are both provided and the product supplier is not, in that case, ExchangeVariantDeleter would not execute and update_product_only_attributes would return nil cancelling update_product_variants from being executed. Now, update_product_only_attributes always returns true if product.save suceeeds, no matter what ExchangeVariantDeleter returns
|
2019-10-21 14:45:27 +01:00 |
|
luisramos0
|
a50ae3f8ce
|
Clarify the API of product_set class by making all other methods to private
|
2019-10-18 10:37:23 +01:00 |
|
luisramos0
|
b625ea0c61
|
Extract to class ExchangeVariantDeleter
|
2019-10-17 19:13:45 +01:00 |
|
luisramos0
|
8857404ddf
|
Remove product variants from all Order Cycles if supplier is changed
|
2019-10-17 19:12:24 +01:00 |
|
luisramos0
|
249a3c4e18
|
Make product set raise error and inform the user something went wrong and keep bugsnag notification so we can get more information about what's going on
|
2019-08-17 19:19:46 +01:00 |
|
luisramos0
|
2b8ebba233
|
Fix some rubocop issues in product_set and admin/products_controller
|
2019-08-17 19:15:32 +01:00 |
|
luisramos0
|
d3c624ae10
|
Add bugsnag notification to product_set create_variant when on_hand or on_demand update fails with exception
|
2019-08-17 19:15:31 +01:00 |
|
luisramos0
|
163c65849e
|
Make product set a bit more robust by not failing to update on_hand when variant is not valid. This will make the overall set update work
|
2019-08-17 19:14:25 +01:00 |
|
luisramos0
|
86b0d71c7e
|
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
|
2019-05-28 12:57:29 +01:00 |
|
luisramos0
|
4b74e50353
|
Make ProductsController#bulk_update work by making ProductSet#create_variant not mass-assigning the provided on_hand and on_demand values and set them after each variant is created
|
2018-12-11 15:18:00 +00:00 |
|
Pau Perez
|
5bd375d422
|
Favor early return over dumb else branch
|
2018-10-11 15:52:40 +02:00 |
|
Pau Perez
|
cbac916e66
|
Validate unit value when updating variant_unit
Variants whose product's variant_unit is weight or volume require
a unit_value.
|
2018-10-11 15:52:40 +02:00 |
|
Pau Perez
|
a2228d4131
|
Make ProductSet parseable by humans
Now it's imposible to understand what is really going on. Feels more
like assembler than Ruby.
|
2018-10-11 15:52:40 +02:00 |
|
Pau Perez
|
d43726504b
|
Make #update_attributes parseable by humans
As it is this is impossible to follow.
|
2018-10-11 15:52:40 +02:00 |
|
Pau Perez
|
2d60b3180e
|
Wrap and improve comment block readability
|
2018-10-11 15:52:40 +02:00 |
|
Rob Harrington
|
b9f19d5777
|
Fixing broken specs
|
2015-04-17 13:00:20 +10:00 |
|
Rohan Mitchell
|
ca1c116a5d
|
Swap param order
|
2014-12-12 13:33:14 +11:00 |
|
Rob H
|
f688461e84
|
Add fields for variant display name and display as to bpe
|
2014-06-12 11:49:53 +10:00 |
|
Rob H
|
de369ae32b
|
WIP: Can manage taxons in BPE
|
2014-05-02 10:28:33 +10:00 |
|
Rohan Mitchell
|
701896be95
|
BPE: Add variant and save it to server. Edit the saved variant.
|
2014-02-13 11:52:44 +11:00 |
|
Rohan Mitchell
|
9c28b5baae
|
Fix product lists not matching when saving changes to product unit+values fields
|
2014-01-10 15:43:45 +11:00 |
|
Rohan Mitchell
|
60a3e06c5b
|
Reformat
|
2013-12-13 11:10:08 +11:00 |
|
Rob H
|
4ae5085192
|
BPUR: Remove unnecessary collections of products on bulk edit page
|
2013-07-23 10:37:50 +10:00 |
|
Rob H
|
0ddd9cc6d0
|
BPUR: use where rather than select for product collection
|
2013-07-23 10:37:50 +10:00 |
|
Rob H
|
8453b43c25
|
BPUR: Allow updating of delegated variant properties
|
2013-07-23 10:37:50 +10:00 |
|
Rob H
|
731127d55c
|
WIP: Bulk Product Update Rewrite: initial acceptance testing
|
2013-07-23 10:37:50 +10:00 |
|