Gaetan Craig-Riou
859f7efd02
Fix Spree:Ability
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
d5cc60fd3a
Fix ProductImporter and related Class
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
b86d8e1603
Fix product import entry validation
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
80112709f3
Fix invoice and api serializer
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
50bd274715
Fix Enterprise
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
d073a181e9
Fix EnterpriseRelationship
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
02b9dfb517
Add after update primary taxon call back
...
It updates supplier on primary taxon update. It fixes falling
enterprise caching specs.
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
22f4ae115a
Add missing associations and validations specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
5cb59d941a
Add transient attribute supplier_id to Spree::Product
...
supplier_id transient attribute will be saved on the variant
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
7af36510c8
Fix lambda styling
...
It follows Style/Lambda cop :
https://docs.rubocop.org/rubocop/1.60/cops_style.html#stylelambda
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
4113880401
Move supplier to variant part 2
...
Variant model and specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
d1dd563720
Move supplier to variant part 1
2024-07-03 10:17:48 +10:00
Gaetan Craig-Riou
9833ac67df
Fix data-disble on Go button
2024-07-01 10:04:50 +10:00
Konrad
5bb47823c6
Merge pull request #12619 from rioug/12559-disable-report-button
...
[Reports] Disable GO button once clicked
2024-06-28 17:11:29 +02:00
Konrad
909bc2792c
Merge pull request #12565 from chahmedejaz/task/11987-remove-SR-from-clone
...
11987: Prevent Reloading the whole table upon Product Clone
2024-06-28 15:35:52 +02:00
Konrad
04dd463f8e
Merge pull request #12592 from mkllnk/report-rendering
...
Load large on-screen reports on demand
2024-06-28 11:14:38 +02:00
David Cook
d799230440
Update controller to catch more specific error
...
We now know which errors to expect. We still let other unknown errors raise higher up, where they will be logged with BugSnag, and treated as internal_server_error.
2024-06-27 12:51:28 +10:00
David Cook
92bd7a5d37
Revert new product duplicator behaviour
2024-06-27 11:39:49 +10:00
David Cook
898ab08bab
Add specs for invalid records
...
It turns out that the duplicator still raises an exception in some cases. Now I think I see why the the controller was catching the exceptions. At least now we know which exceptions to catch.
2024-06-27 11:39:49 +10:00
Ahmed Ejaz
5a259f1b91
Merge branch 'master' into task/11987-remove-SR-from-clone
2024-06-26 16:18:42 +05:00
Ahmed Ejaz
9f832e6743
11987: update code as per new product duplicator behavior
2024-06-26 16:16:13 +05:00
Ahmed Ejaz
95972c75c6
11987: remove rescue StandardError from controller
2024-06-26 16:10:31 +05:00
David Cook
0001ffa970
Fix product index
...
The param product_index wasn't present, so it was always choosing 1.
The products on page are indexed 0-14, so of course it would always conflict.
It would be simpler if we just used product IDs as the index, I think I did earlier but don't remember why not.
Anyway, using a negative number seems to work.
If there's an error, there will only be one at a time.
2024-06-26 17:04:49 +10:00
Gaetan Craig-Riou
74fb6c3143
Disable GO button once clicked
...
It is disabled both on client side and server side, so even if the
server takes a while to respond the button is disabled
2024-06-26 16:01:05 +10:00
Gaetan Craig-Riou
1f018292f7
Merge pull request #12605 from abdellani/12373_12374_fix_bulk_invoice_sending_printing
...
[Invoices] Notify if any order cannot be invoiced on bulk invoice printing (update the behavior only when invoice flag enabled )
2024-06-26 09:16:55 +10:00
Maikel
c8e134cef5
Remove redundant wait loading report content
...
Co-authored-by: Gaetan Craig-Riou <40413322+rioug@users.noreply.github.com >
2024-06-25 11:50:01 +10:00
Mohamed ABDELLANI
a3fd7b77c8
notify if any distributors doesn't have an abn
2024-06-24 14:46:01 +01:00
Ahmed Ejaz
9dd427ab7f
12346 - fix rubocop rails/pluckInWhere errors
2024-06-22 01:54:54 +05:00
Ahmed Ejaz
98e0b0e703
12346 - fix rubocop rails/pluck errors
2024-06-22 01:45:58 +05:00
Maikel
0dd7f264b9
Merge pull request #12542 from anansilva/12448-sanitise-html-custom-tab
...
Sanitize HTML in custom tab content [read only]
2024-06-21 08:35:26 +10:00
Konrad
f9e1ff9238
Merge pull request #12567 from mkllnk/flash-css-fix-v3
...
Error messages don't block bottom of page clicks
2024-06-20 17:22:02 +02:00
Ana Nunes da Silva
d2c6db0d04
Sanitize CustomTab#content
2024-06-20 11:56:09 +02:00
Konrad
25d375bf8e
Merge pull request #12577 from cyrillefr/WhiteLabelButtonAlwaysInactive
...
Update button should change status on modified white label
2024-06-20 11:39:58 +02:00
Ahmed Ejaz
349862c72e
11987: fix specs
2024-06-20 13:41:41 +05:00
Ahmed Ejaz
4b9141f66d
11987 - add products table mutation listner
2024-06-20 12:44:55 +05:00
Maikel Linke
98a29785a7
Load large on-screen reports on demand
...
Sending large reports via Cable Ready is unreliable. The events are
dropped at an unknown point and the report is never displayed to the
user. Instead we just send a link to the report via Cable Ready and
offer a button to load the report on screen.
This has the UX benefit of warning the user about the size as well.
Weaker devices can struggle rendering big HTML documents.
2024-06-20 11:32:33 +10:00
David Cook
0e0a7d9d3e
Merge pull request #12589 from cyrillefr/FixRailsRedundantActiveRecordAllMethodIssue
...
Fixes Rails/RedundantActiveRecordAllMethod issues
2024-06-20 09:40:56 +10:00
Abdellani
0337464291
update logged message when a product is deleted
2024-06-19 15:15:04 +01:00
Abdellani
7a015bad96
populate destroyed_by on produce_v3_controller#destory
2024-06-19 15:14:32 +01:00
cyrillefr
654fda89ca
Fix Rails/RedundantActiveRecordAllMethod issues
...
- Cop: Rails/RedundantActiveRecordAllMethod
- if receiver is an Active Record object, ".all" can be safely removed
- There are 2 allowed receivers that are listed in the
styleguide file (those are defaults cf. cop documentation).
2024-06-19 14:32:21 +02:00
Maikel
8837f1caa2
Revert "Allow negative stock levels for on-demand products"
2024-06-19 15:18:57 +10:00
Maikel
af2e7db155
Merge pull request #12582 from cyrillefr/FixRails_UnusedRenderContentIssues
...
Fixes offenses raised by Rails/UnusedRenderContent
2024-06-19 11:19:22 +10:00
David Cook
2676891322
Merge pull request #12546 from dacook/buu/change-columns-11055
...
[BUU] Change product columns to be shown
2024-06-19 09:25:47 +10:00
David Cook
6fd3cada8c
Fix classname
2024-06-19 09:13:53 +10:00
cyrillefr
a155630b1c
Fixes offenses raised by Rails/UnusedRenderContent
...
- in any cases, adding status: :no_content dropes content from response
- replaced by head :no_content (HTTP 204)
2024-06-18 13:33:19 +02:00
Rachel Arnould
0c6cc9b822
Merge pull request #12558 from cyrillefr/BUUUploadingCorruptProductImagesFailsSilently
...
BUU Display error messages when file not valid
2024-06-18 12:12:51 +02:00
David Cook
b8f8d6d042
Show/hide columns with CSS selectors instead
...
Well, that made the JS way simpler.
Adds a lot of classes though. Maybe we could do it based on column index instead, but this will do for now.
table.hide-col0 { td:nth-child(0) { display: none; } }
2024-06-18 15:35:53 +10:00
Ahmed Ejaz
d2737bd8b0
11987: refactored code
2024-06-18 00:44:10 +05:00
Ahmed Ejaz
05fe7cd4b9
11987: add flash messages for product clone
2024-06-17 23:17:32 +05:00
Ahmed Ejaz
30528cab0f
11987: add slide-in animation for product clone
2024-06-17 22:58:36 +05:00
