Cillian O'Ruanaidh
80b7a5d39a
Remove OrderCycleShippingMethod model and use a :has_and_belongs_to_many association instead
...
Before the OrderCycleShippingMethod had a validation which checked the shipping method belonged to the order cycle distributor. Instead of this validation this just ignores shipping methods which don't belong to one of the order cycle's distributors when they are being attached in the OrderCycleForm service. This pattern is already being used in the OrderCycleForm service for ignoring Schedules that the person doesn't own.
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
593da4996f
A shop won't be shown as open if it doesn't have useable shipping method so these shipping method validations are really necessary
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
a3a52a07b7
Build shipping method with a category so it's valid in the test
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
747c88fb35
Update the Shop::OrderCyclesList service so it's clearer what kind of order cycles are being fetched
...
Before the Shop::OrderCyclesList service would return order cycles even if they are not ready for checkout and we had a check before calling the service in BaseController which would return OrderCycle.where('false'). It seems like this check should be part of the service too.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
f4a4f7c9ff
Remove validations checking order cycle has shipping methods
...
Instead we will make sure the order cycle is not available on the shopfront if it is doesn't have valid shipping methods. This will preven the issue where if one distributor deletes their shipping method, we don't want to invalidate the order cycle for all other distributors.
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
81730f725d
Enterprises shouldn't be considered ready for checkout if it only has backend shipping methods
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
67d4c38550
Rename :preferred_shipping_methods to :selected_shipping_methods on OrderCycle
...
It's a clearer name because 'preferred' implies there could be other unpreferred shipping methods available as well.
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
cc5daf51b1
Expect to be_valid instead of checking presence of specific error spec/models/spree/shipping_method_spec.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
9a511e9e94
Rubocop adjustments
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
0671e52a29
Undo changes to tests, now that order cycle returns all shipping methods by default and doesn't explicitly require OrderCycleShippingMethods anymore
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
fc4f951a1a
Only require OrderCycleShippingMethod records if people want to override the default shipping methods
...
It makes things much simpler if we return all shipping methods by default without needing OrderCycleShippingMethod records to be added to the database.
Co-authored-by: Maikel <maikel@email.org.au >
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
4e0bf75ecf
Get tests broken because of new order cycle shipping method validations working again
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
bff7650b35
Change :available_shipping_methods helper to use new OrderAvailableShippingMethods service.
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
855ec1a708
Add new 'Checkout options' step to the edit order cycle form so people can attach shipping methods
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
1e817af5aa
Validate deleting a shipping method or switching it to backoffice only doesn't invalidate any order cycles
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
48c2e48b24
Update the OrderCycleForm service so it supports attaching shipping methods
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
ca97a7f52d
Add :shipping_methods association to OrderCyle and validations
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
9a6e8a1113
Add an OrderCycleShippingMethod model to handle attaching shipping methods to order cycles
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
a5daee39e3
Extract out a DISPLAY_ON_OPTIONS constant in Spree::ShippingMethod instead of magic strings
2022-09-30 13:13:39 +01:00
Cillian O'Ruanaidh
9b5f743fa5
Extract out a OrderCycle#simple? method so it can be used in models
2022-09-30 13:13:39 +01:00
Jean-Baptiste Bellet
cdf71b419f
Search within all enterprises if user is the super admin
2022-09-29 09:30:21 +02:00
filipefurtad0
e00a59212c
Fixes invert columns logic on reports spec
2022-09-28 11:49:20 +01:00
jibees
4f290b5bc5
Merge pull request #9707 from filipefurtad0/remove_visible_true_label
...
Removes "visible: true" from system specs
2022-09-28 09:21:19 +02:00
Maikel
52c38428e8
Merge pull request #9624 from filipefurtad0/add_vcr_to_the_stack
...
Add VCR to the stack
2022-09-28 10:48:59 +10:00
filipefurtad0
538844a1fb
Removes _visible: true_ from system specs
2022-09-27 17:32:25 +01:00
filipefurtad0
4690cb102b
Adds sets-up the cassettes correctly and other configs
...
deletes unecessary files
Reverts helper option to turn VCR off
2022-09-27 07:26:26 +01:00
jibees
b851aba81a
Merge pull request #9699 from filipefurtad0/localization_number_settings
...
Adds tests to decimal, thousands and localization number settings
2022-09-26 10:57:28 +02:00
filipefurtad0
7b33405530
Replaces translation with actual string
...
DRY: creates update_and_assert_message
2022-09-23 13:00:39 +01:00
filipefurtad0
6e3c0858c1
Adds decimal and thousands separator test
2022-09-23 12:47:18 +01:00
filipefurtad0
fb8d2827d2
Adds number localization preferences test
2022-09-23 12:03:18 +01:00
filipefurtad0
e798277cbf
Adds real requests with concealed secret key
2022-09-21 12:32:49 +01:00
filipefurtad0
3e97433920
Adds VCR config file into support folder
...
...with additional options to vcr_setup
2022-09-21 12:32:49 +01:00
Rachel Arnould
e98d4af630
Merge pull request #9659 from saunmanoj888/fix-bulk-product-update-unit-value
...
Allow to change unit value for numbers with a comma separator on bulk product update
2022-09-21 13:04:08 +02:00
Maikel
a4de128a76
Merge pull request #9674 from filipefurtad0/wicked_pdf_config
...
Makes wicked-pdf config ENV-dependent
2022-09-21 13:16:41 +10:00
Maikel
fe2e510fdc
Merge pull request #9621 from filipefurtad0/invoice_spec_to_account_for_tax_ordering
...
Invoice spec to account for tax ordering
2022-09-21 10:14:07 +10:00
Maikel
5173ddb7a0
Merge pull request #9675 from filipefurtad0/split_build_consumer_tests
...
Makes build run all specs; fixes failing specs
2022-09-20 11:20:52 +10:00
Filipe
bd698f5d81
Merge pull request #9683 from filipefurtad0/customer_query_superadmin_spec
...
Spec reproducing failing customer query, as superadmin
2022-09-19 15:53:07 +01:00
filipefurtad0
7e168fad02
Spec reproduing failing customer query, as superadmin
2022-09-19 14:11:13 +01:00
Jean-Baptiste Bellet
7186526dc6
Fix block too long warnings
2022-09-19 09:26:34 +02:00
filipefurtad0
8c8b262ea1
Sets examples pending and dry running with xit
2022-09-16 15:24:51 +01:00
filipefurtad0
6ae741936f
Scrolls down the page to enable finding element
2022-09-16 15:24:39 +01:00
Jean-Baptiste Bellet
cf8bab97e8
Fix spec by not raising the error image not found
...
`GET http://localhost:3000/throbber.gif 404 (Not Found)`
In the meantime, open an issue to remove jquery.jstree from this page: 9677
2022-09-16 11:04:08 +02:00
Jean-Baptiste Bellet
ba2ad4a0c4
Since #9126 , replacing Paperclip with ActiveStorage, some methods changed
2022-09-16 10:51:04 +02:00
Jean-Baptiste Bellet
4a8dc37b40
Since #9087 , we don't use a boolean but an enum, 'public' or 'hidden'
2022-09-16 10:02:27 +02:00
Jean-Baptiste Bellet
3942c4d808
Fix failing spec: since #9606 we use tom-select
2022-09-16 09:32:34 +02:00
filipefurtad0
bc1ae01eb6
Updates invoice_spec to A3 page size setting
...
Separates display_as in assertion to prevent line break failures
2022-09-15 14:34:15 +01:00
filipefurtad0
e54acf3ca0
Changes tax parcels into the correct order
...
This should fail now, adding pending example on next commit
Wraps failing assertions around pending block
Addresses rubocop Style/LineEndConcatenation convention
Removes pending blocks
2022-09-14 08:02:45 +01:00
saunmanoj888
498d003684
Add unit specs for the js changes for unit_value
2022-09-13 23:28:27 +05:30
binarygit
90f4b1328b
Remove angular from shipping methods tab in enterprise/edit
2022-09-13 15:20:33 +05:45
Jean-Baptiste Bellet
86cb86e8b5
Add a flash error where no available shipping methods to the customer
...
+ update specs as well
2022-09-12 09:42:26 +02:00
