Matt-Yorkley
285c78a5e4
Remove use of #pluck and ensure subquery does not include all columns
2020-02-04 11:10:13 +01:00
Matt-Yorkley
a02c58e231
Add join_table to enterprise groups relation
...
has_and_belongs_to_many relationships now require a join_table
2020-01-22 12:17:23 +01:00
Matt-Yorkley
59ebfb9bd4
Fix subquery errors triggered by #warn_invalid_order_cycles
2020-01-22 12:17:23 +01:00
Matt-Yorkley
103902c006
Replace deprecated arguments in #find_by
...
Failure/Error: enterprise = Enterprise.find_by(name: enterprise_name, select: 'id, is_primary_producer')
ActiveRecord::StatementInvalid:
PG::UndefinedColumn: ERROR: column enterprises.select does not exist
LINE 1: ...HERE "enterprises"."name" = 'User Enterprise' AND "enterpris...
: SELECT "enterprises".* FROM "enterprises" WHERE "enterprises"."name" = 'User Enterprise' AND "enterprises"."select" = 'id, is_primary_producer' LIMIT 1
# ./app/models/product_import/spreadsheet_data.rb:48:in `block in create_enterprises_index'
# ./app/models/product_import/spreadsheet_data.rb:43:in `each'
2020-01-15 16:39:33 +01:00
Matt-Yorkley
d511763733
Replace deprecated #in? method
2020-01-15 12:57:38 +01:00
Matt-Yorkley
d4311a848e
Fix default_scope deprecated syntax
2020-01-15 12:57:38 +01:00
Luis Ramos
f87a553230
Merge pull request #4648 from openfoodfoundation/dependabot/bundler/rubocop-0.79.0
...
Bump rubocop from 0.68.1 to 0.79.0
2020-01-13 19:35:50 +00:00
Maikel Linke
abcfb5ce8d
Update Rubocop config for new version
...
- A couple of cops moved into a different namespace.
- The target ruby version doesn't have to be specified, it's read from
.ruby-version which has been updated to Ruby 2.3.
- Some files were missing in the todo lists.
2020-01-10 08:59:44 +11:00
luisramos0
fb25ddd219
Remove reference to user banners, this code is not used in OFN.
2019-12-28 18:13:04 +00:00
luisramos0
e9e6aa77d8
Make weight calculator work for SubscriptionLineItems by making it test if line_item responds to final_weight_volume field (final_weight_volume_present?)
...
We also add logic to weight_per_variant so that we use variant.unit_value if final_weight_volume is not available but variant_unit is weight
Adapt some test case to test unit_value (in grams) instead of weight (in kgs)
2019-12-08 17:36:21 +00:00
Luis Ramos
0eb4574b37
Merge pull request #4422 from luisramos0/the_poc
...
New Order Cycles edit page with steps
2019-11-20 21:11:23 +00:00
Luis Ramos
2b37592280
Merge pull request #4449 from luisramos0/properties
...
Move properties and product properties from spree_backend to OFN
2019-11-15 08:57:32 +00:00
luisramos0
7c63e59ae9
Add OC imcoming and outgoing abilities to managers, this fixes a few OC feature specs
2019-11-12 12:00:48 +00:00
Matt-Yorkley
5082a133a1
Refactor adjustment fetching into new service and module
2019-11-12 11:57:54 +00:00
luisramos0
c9177feb19
Fix a few more rubocop issues manually
2019-11-10 19:14:12 +00:00
luisramos0
9404aacfb2
run rubocop --auto-correct
2019-11-10 18:42:43 +00:00
luisramos0
de1d7f2877
Remove references to prototype (inexistent in OFN) in model properties
2019-11-08 17:49:35 +00:00
luisramos0
215f2897f3
Bring Property model from spree core
2019-11-08 17:48:49 +00:00
Luis Ramos
3e7bd7dc19
Merge pull request #4376 from luisramos0/ghosts
...
Remove product from Order Cycles if product supplier changes
2019-10-28 21:17:48 +00:00
luisramos0
0dc8ae1561
Merging find_product and find_variant into one single method
...
This fixes rubocop issue, class has too many lines
2019-10-27 20:09:42 +00:00
luisramos0
07fcc8f361
Refactor ExchangeVariantDeleter.new.delete out of update_product_only_attributes into correct place update_product
...
Also extracted find_product from update_attributes and find_variant out of create_or_update_variant to make code simpler
2019-10-27 19:13:57 +00:00
Luis Ramos
02c0b89fa0
Merge pull request #4345 from Matt-Yorkley/shopfront_pagination
...
Shopfront pagination
2019-10-21 16:02:12 +01:00
luisramos0
f57c9d4a25
Fix rubocop issue in product_set.update_product_only_attributes: method has too many lines
2019-10-21 15:20:53 +01:00
luisramos0
783c3c9e90
Add spec to product set to cover case where product and variants attributes are both provided and the product supplier is not, in that case, ExchangeVariantDeleter would not execute and update_product_only_attributes would return nil cancelling update_product_variants from being executed. Now, update_product_only_attributes always returns true if product.save suceeeds, no matter what ExchangeVariantDeleter returns
2019-10-21 14:45:27 +01:00
Matt-Yorkley
ab330e882e
Remove product cache
2019-10-18 21:15:11 +01:00
luisramos0
a50ae3f8ce
Clarify the API of product_set class by making all other methods to private
2019-10-18 10:37:23 +01:00
luisramos0
b625ea0c61
Extract to class ExchangeVariantDeleter
2019-10-17 19:13:45 +01:00
luisramos0
8857404ddf
Remove product variants from all Order Cycles if supplier is changed
2019-10-17 19:12:24 +01:00
Luis Ramos
ad247e2116
Merge pull request #4268 from luisramos0/add_order_endpoint
...
Add api/orders/{order_number} API endpoint
2019-10-16 21:22:27 +01:00
Luis Ramos
19eb93012c
Merge pull request #4326 from kristinalim/feature/4310-remove_shipments_count
...
4310 Do not count order shipments in Order#shipping_method
2019-10-01 11:17:42 +01:00
Luis Ramos
c4d298d732
Merge branch 'master' into remove_deprecations
2019-10-01 10:57:10 +01:00
Pau Pérez Fabregat
c2f8803d72
Merge pull request #4297 from luisramos0/inv_levels
...
Remove all usages of Spree Config track_inventory_levels
2019-10-01 10:35:20 +02:00
Luis Ramos
ef35db6db2
Merge pull request #4296 from luisramos0/subs_line_items
...
Make subscription line items handle soft deleted variants
2019-09-30 13:07:10 +01:00
Matt-Yorkley
7e7429446d
Remove deprecation warnings from VariantStock methods
2019-09-27 17:28:16 +01:00
Kristina Lim
721a0d3a98
Do not count order shipments in Order#shipping_method
2019-09-26 11:01:06 +08:00
luisramos0
cd6d34663e
Remove all usages of Spree Config track_inventory_levels, this is always true in OFN since v2.0.0
2019-09-22 15:25:24 +01:00
luisramos0
c66e5fe1e9
Make subscription line items handle soft deleted variants
...
This ensures subscription list page works. The variant can be removed from the subscription by the user in the edit subscription page
2019-09-22 14:59:59 +01:00
Kristina Lim
3535c4d564
Merge pull request #4240 from Matt-Yorkley/backorder_to_the_future_2
...
Disentangle on_demand and backordered
2019-09-20 00:05:27 +08:00
luisramos0
69afcf7510
Improve readability in order permissions
2019-09-19 16:32:09 +01:00
Matt-Yorkley
4656c35f71
Don't change on_demand variant's stock when updating shipments
2019-09-09 17:49:58 +01:00
Matt-Yorkley
254315b79e
Don't mark on_demand items and shipments as "backordered"
2019-09-09 17:49:56 +01:00
Matt-Yorkley
f413ce2a27
Soft-delete price objects
2019-09-06 17:50:19 +01:00
Luis Ramos
722884d8d8
Merge pull request #3895 from luisramos0/fees_based_on_final_weight
...
Make weight calculator use line_item.final_weight_volume rather than variant.weight
2019-09-05 19:24:56 +01:00
Matt-Yorkley
fc9f61ecf8
Revert PR #4204
...
Temporarily reverting these changes for a quick release
2019-09-05 13:23:59 +01:00
Matt-Yorkley
d4a5829858
Merge pull request #4081 from Matt-Yorkley/products_pagination
...
Bulk Edit Products pagination
2019-09-02 17:14:14 +01:00
Matt-Yorkley
37e50a68e4
Fix timezone date parsing from Angular form fields
2019-09-02 16:29:00 +01:00
Matt-Yorkley
4bec583bff
Refactor import_date_scope
2019-09-02 14:35:00 +01:00
Matt-Yorkley
5259eaae5f
Merge pull request #4204 from Matt-Yorkley/cartastrophe
...
Cartastrophe averted :)
2019-09-02 12:26:08 +01:00
Pau Pérez Fabregat
369a5a8a2f
Merge pull request #4101 from luisramos0/remove_variants_rabl
...
Convert spree/api/products and spree/api/variants views from rabl to AMS
2019-09-02 12:14:26 +02:00
Matt-Yorkley
50a1704994
Make prices soft-deletable
2019-08-30 20:11:32 +01:00