Maikel
c4e4beb912
Revert "Inner join visible orders"
2020-03-19 12:01:00 +11:00
Luis Ramos
5da47b3f19
Merge pull request #4757 from luisramos0/stripe_sca_extra
...
StripeSCA - Handle further SCA auth request when checking out
2020-03-16 16:45:28 +00:00
Pau Perez
53a63775fe
Replace LEFT JOIN with INNER JOIN
...
I see no reason why a LEFT might be needed and its the root cause of the
awful performance.
2020-03-05 17:45:06 +01:00
Maikel
0b18344572
Merge pull request #4790 from mkllnk/4779-payment-method-display
...
4779 payment method display
2020-03-03 10:10:51 +11:00
luisramos0
6877485c90
Extract AuthorizeResponsePatcher from stripeSCA gateway
2020-03-02 17:30:12 +00:00
luisramos0
3fcf286516
Extract PostCheckoutActions from checkout controller
2020-03-02 17:30:12 +00:00
luisramos0
e3ffe8fe6b
Add Checkout Stripe redirect logic to get users redirected to stripe authentication pages provided by the stripe API
2020-03-02 17:30:12 +00:00
luisramos0
d91578ab80
Rename checkout payment redirect to checkout paypal redirect
2020-03-02 17:30:12 +00:00
Luis Ramos
dad21a52b2
Merge pull request #4672 from luisramos0/stripe_sca_method
...
Add new Stripe payment method compatible with the new Stripe Payment Intents API
2020-03-02 17:19:05 +00:00
Luis Ramos
a3a61967a8
Merge pull request #4621 from luisramos0/spree_backend_js
...
OFN without spree_backend 🎉
2020-02-22 10:24:50 +00:00
luisramos0
38fd028a9f
Fix some rubocop issues from previous commit
2020-02-21 10:52:56 +00:00
luisramos0
4e84310d63
Add StripeSCA where StripeConnect is treated as an exception in the setting up of process of a payment method and subscriptions
...
Here we are copy pasting and adding stripe SCA because we are planning to delete the StripeConnect that will be replaced by the stripe sca implementation
2020-02-21 10:52:56 +00:00
Maikel Linke
03fa3e2269
Find last payment deterministically
2020-02-20 15:59:57 +11:00
Maikel Linke
799c1f08de
Optimise finding last payment
...
Suggested by Rubocop.
2020-02-20 15:59:56 +11:00
Maikel Linke
6b66458bfd
Replace andand with new Ruby syntax
2020-02-20 15:59:56 +11:00
Maikel Linke
3e0a5bac6a
Move helper to service for re-use
2020-02-20 15:59:56 +11:00
luisramos0
43280da187
Dup params to avoid nasty effects of a mutated params object in the controller
2020-02-07 10:26:04 +00:00
luisramos0
7eba657b2f
Add missing templates from spree_backend
2020-02-05 20:04:15 +00:00
luisramos0
2663f74767
Add specs for new services
2020-02-05 14:49:17 +00:00
luisramos0
b41de52012
Moved checkout services into a specific folder under app/services
2020-02-05 14:49:17 +00:00
luisramos0
6ce50a5fa5
Extract paypal redirect logic to service class
2020-02-05 14:49:17 +00:00
luisramos0
4fbd2cfa52
Extract UserDefaultAddress logic into separate class to take more 30 lines out of CheckoutController
2020-02-05 14:49:17 +00:00
luisramos0
383b28e170
Add order and current_user to checkout_form_data_adapter where they are required
...
Also re-add order.state condition to update_result: in some tests, the order state is complete but no completion data (completed?) is present
2020-02-05 14:49:17 +00:00
luisramos0
bf55a15f81
Extract checkout params adaptation logic into a service class
2020-02-05 14:49:17 +00:00
Pau Pérez Fabregat
246235b921
Merge pull request #4667 from Matt-Yorkley/rails-4-prep
...
Rails 4 prep
2020-02-04 15:20:28 +01:00
Matt-Yorkley
7d71f21753
Add frozen_string_literal comment to new class
2020-02-04 11:11:24 +01:00
luisramos0
947914724a
Add frozen string literal magic comment
2020-01-28 18:02:58 +00:00
luisramos0
b5004f1cbf
Add specs for ExchangeProductsRenderer#exchange_variants
2020-01-28 18:02:58 +00:00
luisramos0
4596399bc2
Extract logic from controller to renderer service
...
Re-using the filter_visible method for both products and variants
2020-01-28 18:02:58 +00:00
Matt-Yorkley
5f3abbf00e
Refactor BaseController
2020-01-22 12:17:23 +01:00
Luis Ramos
0432c73f19
Merge pull request #4510 from luisramos0/backend_ctrl_resource
...
Bring spree_backend resource controller to OFN
2020-01-15 22:22:24 +00:00
luisramos0
f63c7cf54f
Extract visible_orders_where_values to a private method
2019-12-29 19:01:44 +00:00
luisramos0
13633e8bea
Use arel in order permissions visible orders and editable orders so that we dont have queries with gigantic IN clauses
...
The | operators here were converting the relations to long lists of IDs, in our current particular issue, an IN clause with 100k order_ids
2019-12-29 19:01:44 +00:00
luisramos0
d54850f097
Move ActionCallBacks out of the spree namespace
2019-12-27 17:04:40 +00:00
luisramos0
f8451a2511
Bring needed action_callbacks from spree_backend
2019-12-27 17:04:31 +00:00
luisramos0
0bec492208
Fix some rubocop issues
2019-12-12 18:44:45 +00:00
luisramos0
5cf50f0adf
Convert the manipulation of arrays into active record relations: let the DB do the matching job
2019-12-12 18:44:45 +00:00
luisramos0
197fb36524
Extract ExchangeProductsRenderer from ExchangesProductsController
2019-12-12 18:44:45 +00:00
Luis Ramos
9f351607d1
Merge pull request #4538 from mkllnk/4537-paginated-product-order
...
Make product order deterministic
2019-12-10 18:00:45 +00:00
Maikel Linke
d4512904ea
Make product order deterministic
...
When products are sorted by name and two products have the same name,
their order is undefined. With pagination, two pages can have a
different order of products with the same name which then means that two
pages can return the same product.
Sorting by product id makes sure that the result is always in the same
order, for every page.
2019-12-05 15:37:10 +11:00
luisramos0
3959f16d65
Switch some more references from Permissions to Permissions::Order
2019-11-29 12:22:50 +00:00
luisramos0
5cb77c443b
Fix rubocop issues
2019-11-29 10:53:40 +00:00
luisramos0
82b274e522
Make selector more specific to avoid sql error 'ambiguos column'
2019-11-29 10:49:58 +00:00
luisramos0
bb2e6324bd
Rename order permissions to just order
2019-11-29 10:49:27 +00:00
luisramos0
89056e13ed
Extract order permissions to a separate class
2019-11-29 10:48:58 +00:00
Maikel Linke
50093c325a
Move checkout locking to its own service
...
It gives this complex logic more space and allows for better structure
and more comments at the right places.
2019-11-19 18:18:01 +11:00
Matt-Yorkley
5082a133a1
Refactor adjustment fetching into new service and module
2019-11-12 11:57:54 +00:00
luisramos0
9404aacfb2
run rubocop --auto-correct
2019-11-10 18:42:43 +00:00
Luis Ramos
db8e2891d4
Merge pull request #4417 from Matt-Yorkley/shopfront_patchination
...
Ensure variants returned in #variant_relation are DISTINCT
2019-11-01 12:16:01 +00:00
Matt-Yorkley
67a5a1cdc2
Fix incorrectly ordered entries with duplicate product names in OC and custom taxon ordering applied
2019-10-31 12:14:14 +00:00
