binarygit
75ca1dddf1
Fix tests and rubocop warnings
2024-01-14 15:06:02 +05:45
binarygit
aa7a4fb5a2
Send shipment email by default
2024-01-14 15:06:02 +05:45
binarygit
95a51159d7
send-shipment-email-optionally
2024-01-14 15:05:59 +05:45
filipefurtad0
0a5982bb8f
Update all locales with the latest Transifex translations
2024-01-12 12:12:17 +00:00
filipefurtad0
6eb56fa79b
Update all locales with the latest Transifex translations
2024-01-12 11:59:48 +00:00
Maikel Linke
30b5d065c1
Replace deprecated swagger syntax
2024-01-11 15:13:41 +11:00
Maikel
d197251262
Merge pull request #12026 from dacook/rubocop-autocorrect
...
Autocorrect Rubocop issues
2024-01-11 09:04:49 +11:00
David Cook
c95d7523f6
Merge pull request #12013 from mkllnk/spec-file-helper
...
DRY specs with fixture_file_upload helper
2024-01-10 10:28:23 +11:00
David Cook
47418d9873
Merge pull request #12014 from mkllnk/voucher-on
...
Remove feature toggle for vouchers, they are always on
2024-01-10 09:58:35 +11:00
David Cook
18c2b2512b
Safely autocorrect Style/RedundantLineContinuation
...
Inspecting 1530 files
.................................................................................................................................................................................C................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................
Offenses:
app/helpers/shop_helper.rb:48:43: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
no_open_order_cycles?(order_cycles) &&
^
app/helpers/shop_helper.rb:48:44: C: [Corrected] Style/RedundantLineContinuation: Redundant line continuation.
no_open_order_cycles?(order_cycles) && \ ...
^
spec/system/admin/configuration/content_spec.rb:35:64: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
expect(page).to have_selector :link, "markdown link", href:
^
spec/system/admin/configuration/content_spec.rb:35:65: C: [Corrected] Style/RedundantLineContinuation: Redundant line continuation.
expect(page).to have_selector :link, "markdown link", href: \ ...
^
1530 files inspected, 4 offenses detected, 4 offenses corrected
2024-01-10 09:29:37 +11:00
Konrad
591885610a
Merge branch 'master' into task/11923-add-vouchers-to-oc-customer-total-report
2024-01-09 18:51:47 +01:00
Rachel Arnould
f7aca7a9f1
Merge branch 'master' into 11431-show_warning_when_a_new_invoice_can_be_generated
2024-01-08 16:38:39 +01:00
Rachel Arnould
bd0a296100
Merge pull request #11846 from chahmedejaz/task/11068-delete-product-or-variant
...
[BUU] Add option to delete a product or variant
2024-01-08 13:17:29 +01:00
Maikel Linke
4e510e9bd0
Avoid warning hiding main menu in report spec
2024-01-08 15:54:25 +11:00
Maikel Linke
a8c83b670b
Remove superfluous feature tag from specs
2024-01-08 15:53:50 +11:00
Maikel Linke
e2eead0f86
Scroll to reveal White Label tab
...
The Vouchers tab pushed the White Label tab further down and it was
hidden by the savebar. The CSS adjustment in this commit makes sure
that users can always see all menu items.
The automatic scrolling by Capybara fails because of the savebar but
scrolling to the bottom works.
2024-01-08 15:52:17 +11:00
Maikel Linke
2699ae6ca7
DRY terms of service PDF file use in specs
2024-01-08 13:01:21 +11:00
Maikel Linke
dd639435f1
Remove unnecessary image file helper
2024-01-08 13:01:21 +11:00
Maikel Linke
6327f46733
Use fixture_file_upload helper where possible
...
We can't use it in factories but in other places it's a nice shortcut.
2024-01-08 11:32:01 +11:00
Maikel Linke
41112c1462
DRY uploaded file use in specs
2024-01-08 11:32:01 +11:00
Maikel Linke
57a6d1ef06
Partial spec of error message for readability
...
This avoids Rubocop warnings. We don't need to test for the whole
message. The tested part is unique already and quicker to read.
2024-01-05 11:48:30 +11:00
Maikel Linke
883bfcdf0d
Simplify column toggling in report spec
...
* This partly reverts 3a957fb988 .
2024-01-04 16:53:36 +11:00
Ahmed Ejaz
3a957fb988
11923: add specs
2024-01-03 15:46:16 +05:00
Mohamed ABDELLANI
d239beb226
remove unnecessary require instructions
2024-01-03 11:34:57 +01:00
Maikel
1746ba5878
Merge pull request #11972 from filipefurtad0/fix_flaky_enterprise_navigation
...
Moves test introduced by #11799 to avoid non-explicit modal acceptance
2024-01-03 11:19:33 +11:00
Maikel
b9f117e643
Merge pull request #11959 from mkllnk/connect-app-id
...
Send semantic id when connecting enterprise to app
2024-01-03 11:18:01 +11:00
Maikel
63ce91d52a
Merge pull request #11954 from mkllnk/delete-app
...
Enterprise user can remove Connected Apps
2024-01-03 11:17:26 +11:00
Maikel
1f0c5fc187
Merge pull request #11963 from filipefurtad0/stripe_payment_status_spec_vcr
...
Tests app/services/stripe_payment_status.rb
2024-01-03 10:57:46 +11:00
Ahmed Ejaz
1d6a089754
11068: fix specs
2023-12-28 22:11:52 +05:00
Ahmed Ejaz
f194b03882
11068: add sleep of 0.1s
2023-12-28 17:51:52 +05:00
David Cook
59ad2cf5ec
Re-set vcr config after each test
...
I couldn't find a built-in way to do it, and couldn't even directly access the vcr config outside of VCR.configure. So this is the best way I could think of.
2023-12-28 17:47:09 +11:00
David Cook
263f68f927
Merge pull request #11915 from murjax/cleanse-stripe-js-errors-11886
...
Cleanse JS errors from DOM on Stripe failure
2023-12-28 13:11:36 +11:00
Ahmed Ejaz
c5a86341dc
11068: update sleep logic in specs
2023-12-24 02:00:26 +05:00
Ahmed Ejaz
87d328d6d6
11068: fix specs
2023-12-23 16:08:26 +05:00
Konrad
398be49d43
Merge pull request #11914 from bmd08a1/ft/include-vouchers-in-revenues-by-hub-report
...
Include voucher tax adjustment in revenues by hub report
2023-12-22 20:59:00 +01:00
filipefurtad0
2e301a67b0
Moves test introduced by #11799 to a section in the spec where a modal does not need acceptance
...
Tests forward navigation
2023-12-22 14:24:37 +00:00
Gaetan Craig-Riou
d0edf57e74
Fix tos system spec
...
Actually create a ToS file instead of using a fake one
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
a1d3b20e5b
Remove the fact ToS file
...
Now that we check if there is a ToS file before displaying the banner
it's not needed anymore
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
9609ba4268
Don't show the banner if no ToS file uploaded
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
91e5227d80
Move to simple UserReflex
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
b28f40b125
Add system spec for ToS Banner
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
b3acdaf324
Remove user.id parameter
...
It's not needed, as the reflex get the curent user based on the user
session
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
d0ba881aa2
Move acepting of ToS change to a reflex
...
Spree::Admin::UserController is for super admin user only. Moving to a
reflex simplifies the code by getting rid of a new route and a new stimulus
controller
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
91862c126b
Remove now useless fix
...
Now that the banner isn't displayed if enterprise are not required to
sign ToS, the fix is useless
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
8371eada23
Don't show the banner if enterprises are not required to accepte ToS
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
6226067846
Update translation to be inline with design mockup
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
5c9abfefee
Per review, remove useless code pass
...
It shouldn't be possible for the update to fail, as we are not sending
any parameter. Any other failure should be handled by rails already, ie
missing csrf token.
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
44f22dc634
Per review, check terms_of_service_accepted_at has been updated
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
8e3e9ad18a
Fix terms and condition spec
...
Timecop intefere with the fake terms of service, so we need to manually
accept the terms of service to make the banner disappear
2023-12-22 13:20:14 +01:00
Gaetan Craig-Riou
94fb1397f0
Set up data to hide ToS banner
...
The banner can in some case overlap element we are trying to interact
with. Add a fake ToS file and make sure user have accepted the ToS, so
that the banner is not shown
2023-12-22 13:20:14 +01:00