filipefurtad0
b79ae1af7a
Fixes rubocop offense
2021-12-21 10:51:20 +00:00
Matt-Yorkley
8016e90e07
Ensure payment method is actually selected
2021-12-20 18:47:22 +00:00
Matt-Yorkley
dd23e3d38a
Simplify payment method controller
2021-12-20 18:47:22 +00:00
Matt-Yorkley
b4dab46cf8
Remove unused code for changing required attributes
2021-12-20 18:36:28 +00:00
Matt-Yorkley
723d6489cd
Extract initSelectedCard()
2021-12-20 18:36:26 +00:00
Matt-Yorkley
9525e353a3
Don't try to select a card if there is no select element
...
This error was being thrown when the user had no cards saved:
```
TypeError: stripeCardsController is null
```
2021-12-20 18:36:09 +00:00
Matt-Yorkley
a64f654697
Don't try to select a card if there is no selectTarget
...
This error was being thrown when the user had no cards saved:
```
Error: Missing target element "stripe-cards.select"
```
2021-12-20 15:41:22 +00:00
Matt-Yorkley
f18fc3c2f3
Implement disconnect() to tidy up (remove) event listeners from the DOM when finished
2021-12-20 15:29:52 +00:00
Matt-Yorkley
d58f5aa25d
Move initialization to initialize()
2021-12-20 15:29:52 +00:00
Matt-Yorkley
33c156bb55
Extract (arrow) functions for callbacks used by event listeners and reduce variable assignments
2021-12-20 15:29:52 +00:00
Matt-Yorkley
24c051bad3
Simplify stripe selected check
2021-12-20 15:21:13 +00:00
filipefurtad0
b25e0ed87b
Deletes spec/features/consumer folder
2021-12-20 15:13:57 +00:00
filipefurtad0
c5b14827d0
Adds URL port to the assertion
2021-12-20 14:54:03 +00:00
filipefurtad0
eef89e73c8
Updates/moves sitemap_spec
2021-12-20 14:49:05 +00:00
Jean-Baptiste Bellet
ad24351bb3
Reorganize CSS to display error correctly
...
`.card-errors` is no more child of `.stripe-card`
2021-12-20 15:34:58 +01:00
Jean-Baptiste Bellet
2c5667ef56
Initialize stripe-cards controller when selecting a payment method
2021-12-20 15:34:58 +01:00
Jean-Baptiste Bellet
d4ec075dfc
Disabled stripe-cards input if a already registred card is select
...
And then re-enabled it, if use decide to register a new card
2021-12-20 15:34:58 +01:00
Jean-Baptiste Bellet
7b6aa99de2
Handle when input is already checked
...
ie. user hasn't click on anything
2021-12-20 15:34:58 +01:00
Jean-Baptiste Bellet
6ef7256295
Only submit handle form submit if stripeElementsForm is visible
2021-12-20 15:34:58 +01:00
Transifex-Openfoodnetwork
78ce44fffd
Updating translations for config/locales/en_GB.yml
2021-12-20 19:40:45 +11:00
Maikel Linke
6d1e984af7
Enable testers to activate StripeConnect
...
This will make it easier to test the removal of StripeConnect.
2021-12-20 17:16:39 +11:00
Maikel Linke
470fc92825
Fix old, confusing typo
2021-12-20 17:13:40 +11:00
Maikel Linke
22de357724
Hide deprecated StripeConnect payment gateway
...
StripeConnect has been replaced by StripeSCA but some people still use
the old StripeConnect. Let's prevent people from creating deprecated
payment methods before migrating existing data.
2021-12-20 17:12:19 +11:00
Maikel Linke
6966dea0f5
Extract changing Stripe method selection logic
...
It will change and it's clearer in a separate method.
2021-12-20 17:09:57 +11:00
Maikel Linke
28e6fa235c
Style Layout/HashAlignment
2021-12-20 15:23:58 +11:00
Maikel Linke
178d296c9f
Adapt specs to use stripe_sca_payment_method
...
There are still some specs directly related to StripeConnect and I left
them for now.
2021-12-20 15:00:14 +11:00
Maikel Linke
60adaf3646
Disallow StripeConnect in subscriptions
2021-12-20 15:00:14 +11:00
Luis Ramos
6c281e288c
Switch filter to StripeSCA, this must have been an error, must be tested (manually or automatically)
2021-12-20 15:00:13 +11:00
Matt-Yorkley
68af9b6e80
Only email the hub about authorization required when necessary
...
This is needed in subscriptions, but in the backoffice the hub manager gets a notification in the UI, so the email is not needed.
2021-12-17 19:03:23 +00:00
Cillian O'Ruanaidh
401cc19532
Fix Rubocop LineTooLong violation in spree/admin/variants_controller
2021-12-17 15:40:51 +00:00
Cillian O'Ruanaidh
9bc7922734
Only left join variant overrides belonging to the distributor when searching for in stock variants.
...
Before the :scope_to_distributor call was filtering out variants from other distributors anyway via the :exchange_variants table but it is clearer if we filter by distributor on the :variant_overrides left join too.
2021-12-17 15:25:55 +00:00
Cillian O'Ruanaidh
84eaafb822
Add a :captured_at column on payments to store when they are captured
...
Fixes #8611 .
2021-12-17 14:45:47 +00:00
Filipe
e036e9b979
Merge pull request #8591 from filipefurtad0/consumer_specs_into_system
...
Consumer specs into system
2021-12-17 13:52:28 +00:00
Matt-Yorkley
438c205d87
Add basic test to SubscriptionConfirmJob spec
2021-12-17 12:38:09 +00:00
Filipe
0cc7bdeafa
Merge pull request #8521 from seballot/confirm-hub-change
...
Confirmation popup on shop change in admin section.
2021-12-17 10:56:37 +00:00
Filipe
cd70ce95a6
Merge pull request #8594 from seballot/products-index
...
Hide loading html components on product index
2021-12-17 09:36:54 +00:00
Filipe
e1bd2fc695
Merge pull request #8600 from seballot/shop-filters
...
Make the shop filter section always visible when scrolling
2021-12-17 09:31:51 +00:00
Filipe
e85101e5ff
Merge pull request #8599 from seballot/select
...
Style all standard select as the text input in the backoffice
2021-12-17 09:25:43 +00:00
Matt-Yorkley
542e3ad1aa
Reuse StripeScaPaymentAuthorize in Admin::PaymentsController
2021-12-16 20:42:19 +00:00
Matt-Yorkley
dbe4d61e57
Add explanatory note for "off-session" payment processing
2021-12-16 17:57:53 +00:00
Matt-Yorkley
6b683d600f
Break up #call! with some readable comment-methods
2021-12-16 17:22:56 +00:00
Matt-Yorkley
bbdbf387b7
Combine SendAuthorizationEmails and StripeScaPaymentAuthorize
2021-12-16 17:13:16 +00:00
Matt-Yorkley
fb2c0a253b
Remove reference to params[:token] in Admin::Orders::CustomerDetailsController
...
params[:token] and session[:access_token] are only really used in the context of guest users in the customer-facing parts of the app. Here the user should be fully authenticated already to view the page. There aren't any URL that point at this controller which append a token to the params.
2021-12-16 14:02:50 +00:00
Matt-Yorkley
ec3dadfe68
Remove reference to params[:token] in PaymentsController
...
There seemingly shouldn't be any case where this controller actually receives a token param. There's only one place that creates urls that direct to this controller (Stripe authorization emails), and they do not attach any kind of token to the URL.
If the user is not logged in here (or doesn't have an access_token in their session), they get asked to log in.
Note to future devs: see previous commit for additional context.
2021-12-16 13:41:04 +00:00
Matt-Yorkley
9f49a84e7f
Clarify use of access tokens used for viewing order details as a guest user
...
There are 4 or 5 different places in the app where we reference a :token and params[:token] for completely different purposes (they're not even vaguely the *same* token).
This is an attempt to clarify the places in the app where we use params[:token] in relation to *orders*, for allowing guest users (who are not logged in) to view details of an order they have placed (like after checkout completion), and differentiate it from the various other places where params[:token] can actually be used for something entirely different!
2021-12-16 13:35:55 +00:00
Matt-Yorkley
35e20fc179
Can sort orders via bill_address.lastname
...
We only need to check the orders sort
Fix ordering in api/v0/orders_controller_spec
2021-12-16 09:33:38 +01:00
Matt-Yorkley
45beefc533
Keep the order of passed argument
...
Do not retrieve the orders list sorted by completed_at but by the order_ids array itself
Add BulkInvoiceJob spec and cover sorting behaviour
2021-12-16 09:33:38 +01:00
Jean-Baptiste Bellet
7a48ffdd38
Add order.full_name as new column
...
+ add the linked sortable header via `bill_address_lastname`
2021-12-16 09:26:49 +01:00
Jean-Baptiste Bellet
9c280ee612
add new line
2021-12-16 09:26:49 +01:00
Transifex-Openfoodnetwork
d2b0616a67
Updating translations for config/locales/de_DE.yml
2021-12-16 12:04:37 +11:00
