GeorgeThoppil
898c470c00
Change enterprise visibility scope
2022-04-21 20:27:28 -04:00
Matt-Yorkley
eef59bbaae
Improve permissions query building
...
For larger queries and especially where filtering and paginating, these simpler product queries are way more efficient. It cuts out some very large subqueries with large lists of product ids.
2022-04-05 22:28:09 +01:00
Maikel Linke
3382c1d0bb
Relax some contested metrics rules
...
Rubocop often complains while we think that the code is totally fine. I
would like to achieve the default values one day but there are more
important issues at the moment.
2022-02-25 11:45:15 +11:00
Maikel Linke
b999673dfc
Remove old version of relaxed styled guide
...
We had an old version under "contested settings" and it looks like some
of them were modified. I hope that our new, separate file will
discourage manual tweaks.
We can include the relaxed rules from a gem as well. Let's see if we
need that complexity one day.
2022-02-25 10:51:54 +11:00
Maikel Linke
1d15f35522
Remove now unnecessary inline rubocop config
2022-02-25 10:46:51 +11:00
François Turbelin
23776c7a3e
Fix more specs
2022-02-16 10:23:23 +11:00
Adrien Chauve
ca46359224
More fixes
2022-02-16 10:23:22 +11:00
Filipe
374c05116b
Merge pull request #8726 from Matt-Yorkley/stringex-machina
...
Reduce impact of stringex gem
2022-01-26 19:02:41 +00:00
Jean-Baptiste Bellet
8455d79f9b
Use the last payment method instead of the first for the Payment Method Report
2022-01-18 20:35:08 +01:00
Matt-Yorkley
ea312c78b0
Move PermalinkGenerator out of lib directory
2022-01-15 12:31:43 +00:00
Matt-Yorkley
4dc2172dd2
Update deprecated #search method name
...
DEPRECATION WARNING: #search is deprecated and will be removed in 2.3, please use #ransack instead (called from search at /home/user/Github/openfoodnetwork/lib/open_food_network/sales_tax_report.rb:40)
2021-12-27 16:24:33 +00:00
Filipe
20c0195584
Merge pull request #8017 from cillian/hide-variants-with-no-stock
...
When creating backoffice orders hide variants with no stock by default
2021-12-23 21:34:06 +00:00
Filipe
b256696544
Merge pull request #8549 from mkllnk/deprecate-stripe-connect
...
Hide old "Stripe" (StripeConnect) payment method type, keep new Stripe SCA
2021-12-23 21:33:42 +00:00
Filipe
b786d89fe9
Merge pull request #8555 from jibees/8507-fix-product-search-order-
...
Searching variants should order results by variant display name
2021-12-23 17:41:01 +00:00
Luis Ramos
6c281e288c
Switch filter to StripeSCA, this must have been an error, must be tested (manually or automatically)
2021-12-20 15:00:13 +11:00
Cillian O'Ruanaidh
9bc7922734
Only left join variant overrides belonging to the distributor when searching for in stock variants.
...
Before the :scope_to_distributor call was filtering out variants from other distributors anyway via the :exchange_variants table but it is clearer if we filter by distributor on the :variant_overrides left join too.
2021-12-17 15:25:55 +00:00
Jean-Baptiste Bellet
a33ebbdc85
Include and joins after the order seems in order to select fields...
...
...that are in the order by
2021-12-15 10:11:51 +01:00
Maikel Linke
0cc4e5728e
Reference product attributes for sorting correctly
...
The previous version failed in some cases as it relied on a table name
generated by Rails.
2021-12-15 15:23:52 +11:00
Maikel Linke
faf0a3ab84
Remove unnecessary disabling of cop
2021-12-10 09:26:57 +11:00
Jean-Baptiste Bellet
cad8d8316d
Improve variant order when searching
2021-12-07 11:37:39 +01:00
Jean-Baptiste Bellet
31cc2549ed
Order variant search by display_name
2021-12-07 11:18:20 +01:00
Adrien Chauve
051950e04c
Remove references to deprecated application.yml config file.
...
Point to .env and other .env.* config files.
2021-11-24 15:11:00 +01:00
Matt-Yorkley
817f0942dd
Pull in reports POC work replacing Packing reports
2021-11-04 14:55:23 +00:00
Cillian O'Ruanaidh
2462d71ab5
When creating backoffice orders hide variants with no stock by default
...
But let people include out of stock variants by checking a checkbox if they want.
Note, we only apply the variants in stock scope if a distributor is
present. I think this is because this search method is also used when
setting up subscriptions so I don't think we want to change the
behaviour there.
Co-authored-by: Maikel Linke <maikel@email.org.au >
2021-10-08 13:13:32 +01:00
Maikel
a3c31f7d86
Revert "Kill stripe connect"
2021-09-20 08:39:34 +10:00
Nihal M. Kelanthodika
9d216f0cea
Merge pull request #8160 from apricot12/8019-Delivery_report
...
Show order total in Delivery/Payment Method reports instead of first …
2021-09-15 13:11:43 +05:30
Luis Ramos
5434b51f75
Switch filter to StripeSCA, this must have been an error, must be tested (manually or automatically)
2021-09-10 14:41:06 +05:30
Nihal
43e6d1b933
Show order total in Delivery/Payment Method reports instead of first payment
2021-09-10 13:08:00 +05:30
Matt-Yorkley
1d5077061e
Remove andand
...
This old gem implemented some functionality for handling nils which is no longer needed, as it's provided natively by Ruby with the &. operator.
2021-09-08 14:28:31 +01:00
Jean-Baptiste Bellet
09491cfc6d
Only return order with the selected shipping rates is true
...
Same concept as
https://github.com/openfoodfoundation/openfoodnetwork/blob/master/app/services/search_orders.rb#L31
2021-07-28 17:05:50 +02:00
Matt-Yorkley
886e03af2f
Merge pull request #7805 from Matt-Yorkley/adjustments-admin
...
[Adjustments] Admin adjustments
2021-07-27 12:23:29 +02:00
Matt-Yorkley
12c9914d1b
Delete old Adjustment scopes #with_tax and #without_tax
2021-07-09 21:49:36 +01:00
Jean-Baptiste Bellet
1a8a12fb0c
Filter language to not display the current lang in the dropdown
...
No need to set a lang that is actually already set
2021-07-08 09:15:09 +02:00
Andy Brett
92216cc1c7
Merge pull request #7761 from apricot12/show_variant_SKU_in_xero
...
Show product variant SKU in Xero report
2021-06-23 08:59:15 -07:00
Pau Pérez Fabregat
aa9a85159e
Merge pull request #7806 from mkllnk/feature-toggles
...
Remove custom feature toggles
2021-06-18 12:23:21 +02:00
Maikel Linke
a8eecf963d
Remove unused custom FeatureToggle implementation
...
Flipper is now our only source of truth regarding feature toggles.
2021-06-18 10:46:51 +10:00
Maikel Linke
bba85e5e79
Remove feature toggling via ENV vars
...
We don't use ENV vars for feature toggles any more. Flipper is much
easier to manage.
2021-06-18 10:46:51 +10:00
Luis Ramos
e52937c113
Use rubocop auto correct to add frozen string literal to all files
...
This is an unsafe auto corection, we will need to trust our build here
2021-06-17 23:07:26 +01:00
Luis Ramos
a253228b96
Add some rubocop disable commands in the code to avoid future wrong rubocop auto corrections
2021-06-17 22:26:54 +01:00
Luis Ramos
23627c5453
Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied
...
9290 issues fixed
2021-06-17 22:19:26 +01:00
Nihal Mohammed
3b73f72ac2
Show product variant SKU in Xero report
2021-06-08 19:53:55 +05:30
Matt-Yorkley
7b641ace23
Update Xero Invoices scopes for taxable fees
...
Taxable enterprise fee adjustments now have a tax_category
2021-06-06 20:20:41 +01:00
Matt-Yorkley
2de442f44d
Move taxing of enterprise fees to TaxRate
2021-06-06 20:16:03 +01:00
Maikel
1e1706d371
Merge pull request #7280 from Matt-Yorkley/atomic
...
Remove atomic gem
2021-05-20 17:53:36 +10:00
Viktor Smari
6a342ae368
Ransack.search is deprecated. Use .ransack instead
...
https://github.com/activerecord-hackery/ransack/pull/975
2021-05-09 01:05:37 +02:00
Pau Perez
5bca7d1f8f
Remove the old balance's code branch
...
This keeps the `OrderBalance` abstraction but removes the old code now
that the feature is enabled for all users in all instances and there are
no bugs reported. It's become dead code.
2021-04-19 11:52:41 +02:00
Andy Brett
4aa2ce4b58
Merge pull request #7362 from richardc2117/master
...
Fixes Alphabetical Sorting In Packing Reports
2021-04-15 09:50:02 -07:00
Maikel
0c182c4606
Merge pull request #7259 from jibees/7193-implements-feature-toggle-with-flipper
...
Implements feature toggle with flipper
2021-04-15 11:33:12 +10:00
Matt-Yorkley
e323d016a2
Simplify arguments of #create_adjustment method
2021-04-14 12:01:21 +01:00
Maikel Linke
5775051e35
Simplify FeatureToggle module
...
This saves ten lines of code and makes the simplicity of the
FeatureToggle interface clearer.
2021-04-12 18:26:18 +02:00