Maikel Linke
68193efcf6
Keep old customers.name column for compatibilty
...
Our app code will try to access the old attribute while the migration is
running. That would lead to errors during checkout.
2022-02-16 10:23:24 +11:00
François Turbelin
9a12957e27
Handle the empty-space name on customers
2022-02-16 10:23:23 +11:00
François Turbelin
de4d074cb3
Remove bill_address fetching logic
2022-02-16 10:23:23 +11:00
Maikel Linke
d09ba16411
Associate customers again
...
And simplify the before_validation actions.
2022-02-16 10:23:23 +11:00
Maikel Linke
07314af3f6
Spec customer record association more realistically
...
The newly added specs were tested on the master branch and passed. But
the previous commit broke one test case which I marked as pending here.
The removed specs are completely replaced by the new ones. Their main
downside was to test only small bits of internal behaviour without
considering the whole callback chain of the order. The new specs are
more realistic and catch bugs like mentioned above.
2022-02-16 10:23:23 +11:00
François Turbelin
554a8625e5
Refactor ensure_customer method
2022-02-16 10:23:23 +11:00
François Turbelin
5c9dd81595
Deal with nil attirubtes on bill_address
2022-02-16 10:23:23 +11:00
François Turbelin
6d986deb2d
Remove translation changes from locale file
2022-02-16 10:23:23 +11:00
François Turbelin
4cb31d04a7
Repair specs with default values on ensure_customer method
2022-02-16 10:23:23 +11:00
François Turbelin
50302163c0
Update migration with better logic and cosmetics
2022-02-16 10:23:23 +11:00
François Turbelin
9682b9256b
Arrange classes loading for good migration
2022-02-16 10:23:23 +11:00
François Turbelin
d016c47789
Refactor data migration to use data sets
2022-02-16 10:23:23 +11:00
François Turbelin
b8afb7ec4d
Add default values for new fields
2022-02-16 10:23:23 +11:00
François Turbelin
836a60a6c7
Add missing full_name bind to subscriptions serializer
2022-02-16 10:23:23 +11:00
François Turbelin
23776c7a3e
Fix more specs
2022-02-16 10:23:23 +11:00
François Turbelin
75345a95af
Update customer factory
2022-02-16 10:23:22 +11:00
François Turbelin
eefd9891d6
Add en translations
2022-02-16 10:23:22 +11:00
François Turbelin
7c25127ab6
Improve first_name and last_name setup
2022-02-16 10:23:22 +11:00
Adrien Chauve
ca46359224
More fixes
2022-02-16 10:23:22 +11:00
Adrien Chauve
9b93102a96
More fixes
2022-02-16 10:23:22 +11:00
Adrien Chauve
ba6523bb76
Add Customer.full_name
2022-02-16 10:23:22 +11:00
Adrien Chauve
5ca4d549e7
Update customer creation
2022-02-16 10:23:22 +11:00
Adrien Chauve
d0f347efaa
Add migration to split Customers.name into first and last names
2022-02-16 10:23:22 +11:00
Jean-Baptiste Bellet
405b7e6e17
Handle tax rates for ShippingMethod
...
Co-Authored-By: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com >
2022-02-15 15:16:58 +01:00
Matt-Yorkley
711a51f2ff
Remove .eligible scope
...
In this case we actually expect there to be no payment fee adjustments at all on the payment, regardless of their eligibility.
2022-02-15 12:24:28 +00:00
Matt-Yorkley
5fba7811c4
Remove #try
...
#try is useful when the object might be nil or might not respond to the given method. In this case we expect it to exist and respond to #finalized?, so this is a bit more precise.
2022-02-15 12:21:34 +00:00
Matt-Yorkley
5be1b139b9
Replace .stub with expect(x).to receive(:y)
...
The #stub method is slightly deprecated syntax. Using #expect has the additional benefit here of failing if the object does not receive the expected method call.
2022-02-15 12:19:15 +00:00
Matt-Yorkley
8084ad0068
Extract a comment-method so the code conveys it's purpose
2022-02-15 12:17:08 +00:00
Nihal M. Kelanthodika
b017420319
Add specs to check ensure payment method fee is not applied when crediting/refunding order
2022-02-15 11:52:26 +00:00
Nihal M. Kelanthodika
9215ccc353
Prevents creation of payment adnustment when refunding or crediting an order
2022-02-15 11:52:26 +00:00
Matt-Yorkley
7c7a09a75c
Merge pull request #8880 from openfoodfoundation/dependabot/npm_and_yarn/storybook/addon-controls-6.4.19
...
Bump @storybook/addon-controls from 6.4.18 to 6.4.19
2022-02-15 11:33:04 +00:00
Matt-Yorkley
0d2374f07e
Merge pull request #8881 from openfoodfoundation/dependabot/npm_and_yarn/storybook/server-6.4.19
...
Bump @storybook/server from 6.4.18 to 6.4.19
2022-02-15 11:32:47 +00:00
dependabot[bot]
1b7d72ffa7
Bump @storybook/server from 6.4.18 to 6.4.19
...
Bumps [@storybook/server](https://github.com/storybookjs/storybook/tree/HEAD/app/server ) from 6.4.18 to 6.4.19.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.4.19/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.19/app/server )
---
updated-dependencies:
- dependency-name: "@storybook/server"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-02-15 11:32:14 +00:00
dependabot[bot]
2952b0582a
Bump @storybook/addon-controls from 6.4.18 to 6.4.19
...
Bumps [@storybook/addon-controls](https://github.com/storybookjs/storybook/tree/HEAD/addons/controls ) from 6.4.18 to 6.4.19.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.4.19/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.19/addons/controls )
---
updated-dependencies:
- dependency-name: "@storybook/addon-controls"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-02-15 11:31:49 +00:00
Matt-Yorkley
4726e7a8a4
Merge pull request #8879 from openfoodfoundation/dependabot/npm_and_yarn/storybook/addon-docs-6.4.19
...
Bump @storybook/addon-docs from 6.4.18 to 6.4.19
2022-02-15 11:31:00 +00:00
Matt-Yorkley
46c0baee4f
Merge pull request #8885 from jibees/8882-handle-webpacker-error-for-email
...
Modify assets builder to get CSS inside emails when running in development mode
2022-02-15 11:23:42 +00:00
Matt-Yorkley
e72cc516a8
Drop spree prefix in path generation
2022-02-15 09:47:06 +00:00
Matt-Yorkley
4fbaa65534
Handle unconfirmed email message in UserSessionsController
2022-02-15 09:47:06 +00:00
Maikel Linke
1d5ebe42a9
Update translations
2022-02-15 10:50:01 +11:00
Filipe
e9e5ad2221
Merge pull request #8865 from jibees/8769-use-the-user-in-the-request-to-check-flipper-constraint
...
Use the user in the request to check flipper constraint for split checkout urls
2022-02-14 19:38:27 +00:00
SarvarKhalimov
d69f42e940
Update app/models/product_import/entry_validator.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-02-15 00:10:32 +05:00
Filipe
2de2703e1f
Merge pull request #8868 from jibees/8852-improve-total-cell-design-on-order-summary-table
...
SplitCheckout : Improve design of the order summary table
2022-02-14 18:48:20 +00:00
Filipe
a9d7fa473e
Merge pull request #8870 from jibees/8853-handle-back-button-on-summary-page-for-the-split-checkout
...
Split checkout: handle the link for "Back to Payment method" button in the summary page
2022-02-14 18:29:11 +00:00
Filipe
ddfda4011d
Merge pull request #8873 from Matt-Yorkley/stripe-retries
...
Update checkout retry logic
2022-02-14 15:28:56 +00:00
Matt-Yorkley
e4030e673d
Merge pull request #8875 from openfoodfoundation/dependabot/npm_and_yarn/follow-redirects-1.14.8
...
Bump follow-redirects from 1.14.7 to 1.14.8
2022-02-14 14:03:59 +00:00
Jean-Baptiste Bellet
74ed878a0c
Specify the asset host for the action mailer to get the assets
...
when running in development with webpacker running as well.
2022-02-14 14:54:09 +01:00
Matt-Yorkley
0c2a267bea
Patch keyword arguments syntax in Paperclip error handling
2022-02-14 11:58:22 +00:00
Filipe
6acd8a29f2
Merge pull request #8874 from Matt-Yorkley/puma-update
...
Update puma to latest version
2022-02-14 09:11:51 +00:00
dependabot[bot]
699e9acfa5
Bump @storybook/addon-docs from 6.4.18 to 6.4.19
...
Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs ) from 6.4.18 to 6.4.19.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/v6.4.19/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.19/addons/docs )
---
updated-dependencies:
- dependency-name: "@storybook/addon-docs"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-02-14 09:03:42 +00:00
Matt-Yorkley
ad44bd854b
Merge pull request #8878 from mkllnk/rubocop-action
...
Use our defined rubocop version on CI
2022-02-14 08:58:52 +00:00