Pau Pérez Fabregat
a0c144fd0c
Merge pull request #3415 from openfoodfoundation/feature/enterprise_fee_summary
...
[Enterprise Fee Summary] Merge "Enterprise Fee Summary" report to master
2019-02-12 13:58:47 +01:00
Pau Pérez Fabregat
b6ca0ba24f
Merge pull request #3456 from coopdevs/fix-last-orders-controller-spec
...
Fix orders controller spec
2019-02-12 12:47:15 +01:00
Pau Perez
24189ca88e
Create shipping_rate earlier for callback to work
...
If the shipping_rate is not created at the time the `#after_save`'s
`#ensure_correct_adjustment` callback is executed its call to
`shipping_method.create_adjustment` won't be executed either.
As a result, the OrderUpdater wasn't able to see any adjustments related
to the shipment causing the order total to be outdated.
2019-02-12 12:11:55 +01:00
luisramos0
935c8cb0ce
Move ProductImporter spec to xdescribe until all its specs are green (spree upgrade phase 2)
2019-02-12 10:38:03 +00:00
luisramos0
7c0b21eb83
Make bulk invoices part of spree upgrade phase 2
2019-02-12 10:37:22 +00:00
Pau Perez
ab0b759567
Merge branch '2-0-stable' into 2-0-admin-capture-payment
...
* 2-0-stable: (208 commits)
Re implement orders ctrl update method so we can change redirection logic and add specs for it
Improve readability in admin/orders_spec
Add line items adjustments (order.price_adjustments) to the order edit page so that user is aware of adjustments included in the price like for example tax rates
Adapt variants auto complete to spree v2 code with shipments
Adapt customer search override to spree v2 and fix customer details spec in admin orders spec
Fix distributor change spec in admin orders spec
Fix admin orders spec non tax adjustments by adapting to new view
Fix failing specs due to Spree 2's new order admin page Add missing form tag and OC and shops injectors on order form to make the OC field, the distributor field and the update button work
Use Spree routes
Fix shop accidentally becoming order coordinator
Match date format in spec with import date filter
Make in_stock? work for both variants and overrides by moving it from VariantStock to variant_decorator.
Add unit test for VariantStock.can_supply?
Remove rescue from products_reset_strategy in product import: if setting count_on_hand fails the import will raise a RuntimeError
Change product import's product_reset_strategy from depending on the inexistent variant.count_on_hand DB field and instead make individual calls to variant.count_on_hand= defined in VariantStock. Also, added spec to test return value of the reset method: it should return number of updated records.
Upgrade views to Spree 2 and apply overrides
Updating translations for config/locales/en_US.yml
Update name spaces for rake tasks to shorter 'ofn'.
Refactor checking no preview image in specs
Refactor checking of preview image path in specs
...
2019-02-12 11:12:40 +01:00
luisramos0
58ea28ebb4
Make Api::ShipmentsController#create re-use order.shipment if it exists
...
Improve code and add specs to this controller
2019-02-12 10:09:00 +00:00
luisramos0
0f44beb477
Delete all Spree::Admin::LineItemsController customizations as they are no longer used
2019-02-12 10:09:00 +00:00
Pau Pérez Fabregat
0cc2bd052e
Merge pull request #3436 from luisramos0/2-0-orders-edit
...
[Spree Upgrade] Fix admin new order page flow (from order details to customer details)
2019-02-12 10:35:25 +01:00
Pau Pérez Fabregat
92dca0cdfa
Merge pull request #3194 from HugsDaniel/3109-fix-orders-new
...
[Spree Upgrade] Fix admin new order page
2019-02-12 09:58:29 +01:00
Luis Ramos
edd1da7d50
Update spec/controllers/spree/orders_controller_spec.rb
...
Fix typo in doc
Co-Authored-By: sauloperez <saulopefa@gmail.com >
2019-02-12 09:12:03 +01:00
Matt-Yorkley
097ffba323
Fix broken spec from refactored method
2019-02-11 23:57:13 +00:00
Luis Ramos
dd44d6a0ca
Merge pull request #3355 from luisramos0/2-0-pord-importer-spec
...
[Spree Upgrade] Phase 2 - Fix product_importer spec
2019-02-11 15:28:47 +00:00
Pau Pérez Fabregat
9d065c8a0b
Merge pull request #3233 from Matt-Yorkley/pi/inventories
...
Pi/inventories
2019-02-11 16:10:33 +01:00
Pau Pérez Fabregat
da09c8f86c
Merge pull request #3467 from kristinalim/fix/3455-intermittent_spec_failure
...
3455 [Flaky Spec] Do not expect modal still open when checking that the spinner is gone
2019-02-11 15:58:22 +01:00
luisramos0
acc99fc9bb
Improve readability of cached_product_renderer and respective spec
2019-02-11 11:46:04 +00:00
Kristina Lim
a876c2ab9f
Address timing issues in enterprise roles specs
2019-02-11 13:02:40 +08:00
luisramos0
ad0e5bb093
Re implement orders ctrl update method so we can change redirection logic and add specs for it
2019-02-10 15:31:01 +00:00
Kristina Lim
0032a237a2
Wait for button to disappear before checking flash
2019-02-10 22:08:18 +08:00
Kristina Lim
175264f41f
Use flash matcher in shipping method feature specs
2019-02-10 22:08:18 +08:00
Kristina Lim
e14c60c1c1
Add RSpec matchers for flash messages
2019-02-10 22:08:18 +08:00
Kristina Lim
f143540d0c
Do not expect modal open when checking spinner gone
...
The element referenced in the following might no longer be visible:
within "div.reveal-modal"
2019-02-09 22:40:40 +08:00
Kristina Lim
de30cf1198
Fix description for feature flag example groups
2019-02-08 21:26:39 +00:00
Kristina Lim
461b5725d1
Hide report link and resource from non-superadmins
2019-02-08 21:26:38 +00:00
Kristina Lim
1d3f4aa28a
Add feature flag for enterprise fee summary
2019-02-08 21:26:38 +00:00
Kristina Lim
c92d202612
Rename files for factories in spec/factories/
...
Make these follow the "#{SINGULAR_OBJECT}_factory.rb" convention.
2019-02-08 21:26:38 +00:00
Kristina Lim
625069cb5a
Add :per_item factory trait to shipping and payment methods
2019-02-08 21:26:38 +00:00
Kristina Lim
d2e49b8b49
Move variant setup to new factory trait
2019-02-08 21:26:38 +00:00
Kristina Lim
ce030aeb07
Move order setup to new factory traits
2019-02-08 21:26:38 +00:00
Kristina Lim
61ec43f868
Add enterprise fee factory trait for per item rate
...
We should not presume what is not default for an enterprise fee object.
2019-02-08 21:26:38 +00:00
Kristina Lim
eaa7800427
Do not assign I18n translation to constants
...
The preferred language could change dynamically.
2019-02-08 21:26:38 +00:00
Kristina Lim
c8b154b12a
Separate enterprise fee summary action
...
Split the previous "index" action into "new" and "create" actions.
2019-02-08 21:26:38 +00:00
Kristina Lim
a17fa8013f
Clean up I18n scope in feature specs for report
2019-02-08 21:26:38 +00:00
Kristina Lim
c0e6b70131
Rename EnterpriseFeeSummaryReportController
...
Remove "Report" because this is redundant, and pluralize the resource
name.
2019-02-08 21:26:38 +00:00
Kristina Lim
2063752b97
Improve specs for Enterprise Fee Summary
...
This also addresses a spec that has failed over the rebasing.
2019-02-08 21:26:38 +00:00
Kristina Lim
b78e2b4720
Move lib files for enterprise fee summary to engine
2019-02-08 21:26:38 +00:00
Kristina Lim
dcb1d9fe25
Add feature tests for enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
edf0b0df76
Add navigation item for enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
d3e9a53120
Filter enterprise fee summary for user permissions
2019-02-08 21:26:37 +00:00
Kristina Lim
f81f4b7e4a
Authorize filters before generating enterprise fee report
2019-02-08 21:26:37 +00:00
Kristina Lim
9ce313c7f5
Define filter authorizer for enterprise fee report
2019-02-08 21:26:37 +00:00
Kristina Lim
cd3e258b59
Rename report authorizers to reflect permissions
2019-02-08 21:26:37 +00:00
Kristina Lim
469988856d
Define permissions for enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
5fce9d0a7d
Add multi-distributor scope to shipping and payment methods
2019-02-08 21:26:37 +00:00
Kristina Lim
24ab2e7fb0
Add filtering to enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
2407531957
Make more code for report tests reusable
2019-02-08 21:26:37 +00:00
Kristina Lim
d573dc5023
Make order builder for enterprise fee summary flexible
...
This is in preparation for tests for filtering the report.
2019-02-08 21:26:37 +00:00
Kristina Lim
4a00aceba2
Include shipping fees in enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
1273cc085b
Include payment fees in enterprise fee summary
2019-02-08 21:26:37 +00:00
Kristina Lim
7d74ddc85b
Add HTML view for enterprise fee summary report
2019-02-08 21:26:37 +00:00