Pau Perez
3cef261de1
Force RSpec's output to be in color
...
While also simplifying the configuration using the default `progress`
RSpec formatter.
2021-03-09 16:18:29 +01:00
filipefurtad0
f26a7befab
removes default value assertions
2021-03-09 15:18:02 +00:00
Pau Perez
c986583d09
Remove unnecessary JS-capabilites for test
...
This gets this file execution time from ~10s to ~2s.
2021-03-09 16:04:29 +01:00
Pau Perez
333c669fbf
Remove puts debugging in tests
2021-03-09 16:01:55 +01:00
Andy Brett
0125b5f10e
add spec for plus_relatives_and_oc_producers
2021-03-08 09:10:40 -08:00
Andy Brett
95c232dfe7
add spec for a resumed order
2021-03-08 08:54:28 -08:00
Pau Pérez Fabregat
6b111561e8
Merge pull request #7000 from Matt-Yorkley/dead-code-tax-total
...
DCOTW: Order#tax_total
2021-03-08 16:57:59 +01:00
Matt-Yorkley
c99a9f4ee1
Remove Adjustment#set_eligibility
2021-03-08 15:29:04 +00:00
Pau Pérez Fabregat
876c378e4f
Merge pull request #7028 from Matt-Yorkley/dead-code-available-shipment
...
DCOTW: Order#has_available_shipment
2021-03-08 15:25:39 +01:00
Pau Pérez Fabregat
696a429bcb
Merge pull request #7030 from Matt-Yorkley/dcotw-item-count
...
DCOTW: Order#item_count
2021-03-08 15:23:09 +01:00
Pau Perez
7792bc34c8
Test that currency symbol position can be changed
2021-03-08 13:40:00 +01:00
filipefurtad0
3b81f51fe4
adds coverage to transacion fees/payment methods
2021-03-08 12:35:35 +00:00
Pau Perez
ca268d5c84
Remove unnecessary indirection in test
2021-03-08 13:34:57 +01:00
Pau Perez
96bcde61a3
Fix Money deprecation warning with :html_wrap
...
This fixes the following deprecation warning
```
[DEPRECATION] `html` is deprecated - use `html_wrap` instead. Please
note that `html_wrap` will wrap all parts of currency and if you use
`with_currency` option, currency element class changes from `currency`
to `money-currency`.
```
2021-03-08 13:03:00 +01:00
Pau Perez
485449e289
Fix Money gem deprecation warning with :format
...
This removes millions of deprecation warnings like the following
```
[DEPRECATION] `symbol_position: :before` is deprecated - you can replace it with `format: %u %n`
```
from the build. It gets printed every time a `Spree::Money` is instantiated.
This should result in a non-negligible speed up of the test suite.
2021-03-08 13:03:00 +01:00
Pau Perez
e355a00724
Remove redundant spec context
...
This is already tested by the top-most before block and besides, we
there's no OFN in Japan. We don't need to test all supported currencies
but ensure that the various arguments work as intended.
2021-03-08 12:52:41 +01:00
Matt-Yorkley
af29c67ea5
Update Order#ship_total
2021-03-06 14:14:56 +00:00
Matt-Yorkley
f894473e03
Delete dead code: Order#item_count
2021-03-06 00:04:46 +00:00
Matt-Yorkley
68e752ef32
Delete dead code: Order#has_available_shipment
2021-03-05 23:42:08 +00:00
Matt-Yorkley
365700615a
Remove dead code: Spree::Config.auto_capture
...
We set this value to `true` unconditionally in an initializer, and then check the value in various places via Spree::Config. It's never false, and it's not configurable, so we can just drop it and remove the related conditionals. 🔥
2021-03-05 16:03:07 +00:00
Pau Pérez Fabregat
674f0f87a3
Merge pull request #6528 from mprieger/5546-cart-page-last-item-deletion
...
Fix users removing last item of confirmed order on /cart page
2021-03-04 17:27:51 +01:00
Pau Pérez Fabregat
982c3d2215
Merge pull request #6965 from andrewpbrett/fix-sca-snail
...
Fix #6964 : don't try to complete a failed payment
2021-03-04 17:26:24 +01:00
Pau Pérez Fabregat
ff239802b6
Merge pull request #6982 from andrewpbrett/canceled-order-payments
...
Fix #5018 : Allow access to payments tab for canceled orders
2021-03-04 17:25:30 +01:00
Matt-Yorkley
3396319f29
Fix test setup in Order spec
2021-03-04 14:27:02 +00:00
Matt-Yorkley
b1bf2487e2
Update adjustment scope use in Xero Invoices report
2021-03-04 14:27:02 +00:00
Matt-Yorkley
945605e3a8
Rename Shipment #adjustment to #fee_adjustment for clarity
2021-03-04 14:27:02 +00:00
Matt-Yorkley
a5929b489a
Ensure order object has line items in bulk_invoice_service
2021-03-04 14:27:02 +00:00
Matt-Yorkley
eed71d795e
Use persisted shipment in shipping adjustment test
2021-03-04 14:27:02 +00:00
Matt-Yorkley
57b54637e3
Ensure order factory selects shipping rates correctly
2021-03-04 14:27:02 +00:00
Matt-Yorkley
434c9f1c7c
Fix test setup in adjustments_spec
...
The order association is required for these objects to be found
2021-03-04 14:27:02 +00:00
Matt-Yorkley
0e2c1d0317
Refresh shipment rates when changing shipping method cost
...
The test setup here wasn't correctly updating he shipment's shipping_rates, so they were still zero.
2021-03-04 14:27:02 +00:00
Matt-Yorkley
55db911334
Update sales tax report
2021-03-04 14:27:02 +00:00
Matt-Yorkley
f956aca82f
Use shipping fee adjustment as single source of truth, and persist it on the shipment :cost field when it changes.
2021-03-04 14:27:02 +00:00
Matt-Yorkley
bcbea618e8
Fix adjustment spec
...
The tested adjustment isn't found correctly if it isn't associated to the order...
2021-03-04 14:27:02 +00:00
Matt-Yorkley
7fb5bf217f
Update checkout spec adjustment fetching
2021-03-04 14:27:02 +00:00
Matt-Yorkley
aa16c64f20
Update Order#finalize! to include all adjustments
2021-03-04 14:27:02 +00:00
Matt-Yorkley
c0b33de0f0
Move #adjustment_label to shipment
2021-03-04 14:27:02 +00:00
Matt-Yorkley
e67c29872a
Update OrderMailer spec
2021-03-04 14:27:02 +00:00
Matt-Yorkley
86110f2f40
Improve shipment factory
2021-03-04 14:27:02 +00:00
Matt-Yorkley
f0de09da84
Update order correctly in ReturnAuthorizationsController
2021-03-04 14:27:02 +00:00
Matt-Yorkley
833aae23e5
Update admin adjustments controller
2021-03-04 14:27:02 +00:00
Matt-Yorkley
f94f424b63
Update fee fetching in controller tests
2021-03-04 14:27:02 +00:00
Matt-Yorkley
c093701adf
Improve UserBalanceCalculator spec test setup
...
Previously we were creating order objects that were not actually complete, and manually setting the `completed_at` field. This meant the order objects being tested were not actually in the correct state, ie: pre-checkout orders that had not been processed properly.
2021-03-04 14:27:02 +00:00
Matt-Yorkley
d4c9d70caa
Update Adjustment specs
2021-03-04 14:27:02 +00:00
Matt-Yorkley
045cdec23c
Update OrderDetailedSerializer
2021-03-04 14:27:02 +00:00
Matt-Yorkley
80aefa8e73
Update OrderTaxAdjustmentsFetcher
2021-03-04 14:27:02 +00:00
Matt-Yorkley
02fb2c6a55
Update CheckoutHelper
2021-03-04 14:27:02 +00:00
Matt-Yorkley
f0aa43e198
Update Order shipment adjustments fetching
2021-03-04 14:27:01 +00:00
Matt-Yorkley
1aec324269
Update shipment cost spec
2021-03-04 14:27:01 +00:00
Matt-Yorkley
4c57addb02
Move shipping fee adjustment from the order to the shipment
2021-03-04 14:27:01 +00:00
