Sebastian Castro
5f78fdce8b
Reports Refactor 2: Move all code to lib/reporting
2022-05-12 16:54:13 +02:00
Sebastian Castro
2985d2af15
Report Refactor 1 Cleaning
...
clean no longer used methods
Remove no longer needed require
Delete files not used
Fix Linting
2022-05-12 16:54:13 +02:00
Sebastian Castro
e9513f6172
Report Refactor 1: Enterprise Fee Summary
...
Disable enterprise fee summary spec for now
Will need to write them again
2022-05-12 16:54:13 +02:00
GeorgeThoppil
2046317f16
Allow update of subscriptions containing deleted products
2022-04-21 20:23:34 -04:00
Cillian O'Ruanaidh
7446dfb0b7
Don't allow subscriptions with no quantity to be saved
...
Before you could save a subscription even if the line item(s) it contained had 0 quantity.
For #8903
2022-03-17 11:54:24 +00:00
Maikel Linke
b999673dfc
Remove old version of relaxed styled guide
...
We had an old version under "contested settings" and it looks like some
of them were modified. I hope that our new, separate file will
discourage manual tweaks.
We can include the relaxed rules from a gem as well. Let's see if we
need that complexity one day.
2022-02-25 10:51:54 +11:00
François Turbelin
23776c7a3e
Fix more specs
2022-02-16 10:23:23 +11:00
Matt-Yorkley
31e6405125
Handle setting of payment amount during checkout in OrderUpdater
2022-02-01 11:39:07 +00:00
Filipe
53b96896a9
Merge pull request #8779 from mkllnk/7872-remove-stripe-connect
...
Upgrade old Stripe Connect payment methods to Stripe SCA and remove Stripe Connect
2022-01-26 11:57:26 +00:00
Matt-Yorkley
8ec7d3b651
Fix use of deprecated keyword args syntax in reports
2022-01-24 14:11:08 +00:00
Maikel Linke
ee85b9654d
Remove references to StripeConnect class
2022-01-24 12:35:45 +11:00
Matt-Yorkley
5a2c14e79a
Use new return URL when authorizing Stripe payments in backoffice or subs
2022-01-14 19:41:08 +00:00
Matt-Yorkley
3f3bfadb59
Simplify StripeScaPaymentAuthorize and clarify both return URL types (checkout and off-session)
2022-01-14 19:41:08 +00:00
Matt-Yorkley
68af9b6e80
Only email the hub about authorization required when necessary
...
This is needed in subscriptions, but in the backoffice the hub manager gets a notification in the UI, so the email is not needed.
2021-12-17 19:03:23 +00:00
Matt-Yorkley
542e3ad1aa
Reuse StripeScaPaymentAuthorize in Admin::PaymentsController
2021-12-16 20:42:19 +00:00
Matt-Yorkley
dbe4d61e57
Add explanatory note for "off-session" payment processing
2021-12-16 17:57:53 +00:00
Matt-Yorkley
6b683d600f
Break up #call! with some readable comment-methods
2021-12-16 17:22:56 +00:00
Matt-Yorkley
bbdbf387b7
Combine SendAuthorizationEmails and StripeScaPaymentAuthorize
2021-12-16 17:13:16 +00:00
Matt-Yorkley
3e02023bf8
Move handling of unused payments to Order::Updater
...
An order can be set to paid in various cases that are unrelated to the order being finalized, so this bit of logic needs to be called at the point the order actually gets paid.
2021-11-15 15:42:04 +00:00
Maikel
a3c31f7d86
Revert "Kill stripe connect"
2021-09-20 08:39:34 +10:00
Luis Ramos
60a8ae6675
Remove Stripe Connect gateway and related code
2021-09-10 14:43:24 +05:30
Maikel
9affc6a945
Merge pull request #8108 from Matt-Yorkley/andand
...
Remove `andand` gem
2021-09-10 15:06:00 +10:00
Matt-Yorkley
1d5077061e
Remove andand
...
This old gem implemented some functionality for handling nils which is no longer needed, as it's provided natively by Ruby with the &. operator.
2021-09-08 14:28:31 +01:00
Matt-Yorkley
3dd8ed85b4
Implement manual shipping method selection
2021-09-01 14:16:32 +01:00
Matt-Yorkley
3ae31ec1ce
Simplify tax adjustment sums in Order::Updater
2021-07-09 21:49:36 +01:00
Pau Pérez Fabregat
db993652c4
Merge branch 'master' into payment-states
2021-06-18 12:20:26 +02:00
Luis Ramos
e52937c113
Use rubocop auto correct to add frozen string literal to all files
...
This is an unsafe auto corection, we will need to trust our build here
2021-06-17 23:07:26 +01:00
Andy Brett
b016337d4f
add requires_authorization as a possible payment_state on Orders
2021-06-17 14:23:59 -07:00
Andy Brett
527f4e2cb3
move payment to requires_authorization if cvv_result is present
2021-06-17 14:23:59 -07:00
Andy Brett
31738ceb49
rename and consolidate authorization? methods
2021-06-17 14:23:59 -07:00
Luis Ramos
23627c5453
Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied
...
9290 issues fixed
2021-06-17 22:19:26 +01:00
Matt-Yorkley
9e1d8ab369
Introduce legacy tax handing in Order::Updater whenever order totals change
...
This will remove legacy tax adjustments, recalculate any relevant taxes for items in the order and re-apply them in non-legacy tax adjustments
2021-06-06 20:20:41 +01:00
Matt-Yorkley
6e9ae0b0db
Update tax totals calculation in Order::Updater
...
Line items, shipments, and fees now all have taxes recorded in a uniform way, so we can drop more complexity here (and the number of queries).
2021-06-06 20:16:03 +01:00
Luis Ramos
b2e97fe1d2
Rename order.update! to order.update_order! and adjustment.update! to adjustment.update_adjustment!
2021-05-19 09:54:22 -07:00
Matt-Yorkley
5dd24623f7
Merge pull request #7479 from Matt-Yorkley/payment-callbacks
...
Update Payment after_save callback
2021-05-18 16:19:29 +02:00
Matt-Yorkley
2e248744c0
Merge pull request #7520 from Matt-Yorkley/shipment-controller
...
Shipment controller: test coverage and improvements
2021-05-13 20:26:51 +02:00
Matt-Yorkley
00c4a28d22
Extract order-updating logic to Order::Updater
2021-05-04 16:40:10 +01:00
Matt-Yorkley
13bb5aa8dd
Update Payment after_save callback
...
Backport from Spree 2.4 stable: 4d652a77fd
2021-05-04 16:40:09 +01:00
Matt-Yorkley
925676f136
Split Order::Updater#update into two methods
...
There are two distinct (and very important) operations happening here. The first is to update all adjustments (which can be *incredibly* expensive) and the second is to ensure the order's totals and shipping/payment states are correct. There are lots of places where we currently do both of these things where in fact we only need to do the latter (and skip the really expensive part).
2021-04-30 12:48:53 +01:00
Matt-Yorkley
c7ce10f998
Handle order objects with no distributor
2021-04-30 11:12:41 +01:00
Matt-Yorkley
5b29243847
Delete unused method Stock::Package#currency
2021-04-30 11:10:20 +01:00
Matt-Yorkley
3897c3af68
Refactor Stock::Package#shipping_methods
2021-04-30 11:10:20 +01:00
Matt-Yorkley
0291a7c471
Merge pull request #7482 from Matt-Yorkley/updater-update
...
Updater update
2021-04-29 21:12:15 +02:00
Pau Pérez Fabregat
6c5db0f836
Merge pull request #7507 from Matt-Yorkley/shipment-state-update
...
Shipment callback state update
2021-04-29 12:01:55 +02:00
Matt-Yorkley
290c1d0ebf
Bring in shipment state updating from Spree 2.2
2021-04-28 21:43:28 +01:00
Matt-Yorkley
f52d03fbf4
Refactor Order::Updater#update so we don't call update_totals twice
...
Calling this method twice on every update is really expensive and not necessary.
2021-04-26 11:46:05 +01:00
Andy Brett
56cf43f1c1
scope variant to take overrides into account in packer
2021-04-22 11:45:12 -07:00
Pau Perez
5bca7d1f8f
Remove the old balance's code branch
...
This keeps the `OrderBalance` abstraction but removes the old code now
that the feature is enabled for all users in all instances and there are
no bugs reported. It's become dead code.
2021-04-19 11:52:41 +02:00
Matt-Yorkley
b6038c01a3
Remove references to Adjustment source
2021-04-14 12:01:21 +01:00
Andy Brett
d00970e05d
Merge pull request #7207 from andrewpbrett/fix-nil-price-subs
...
Report subscription failures
2021-04-09 12:13:11 -07:00
