Cillian O'Ruanaidh
f5bd23b4d8
Remove unused Spree::Order#available_payment_methods method
...
This was introduced in 47d2f698ef but we are using OrderAvailablePaymentMethods now.
2022-10-21 17:21:31 +01:00
Matt-Yorkley
0ca86344d2
Update use of deprecated #add_tab method to #add_metadata
2022-10-19 17:36:53 +11:00
Maikel Linke
52e934ec2b
Consistently use our FeatureToggle module
...
Direct calls to Flipper have the downside that we can't add any new
functionality like storing the feature in the database when used.
2022-10-08 16:23:17 +02:00
Maikel Linke
8011d85968
Clarify updating only pre-existing customers
2022-09-29 12:06:06 +02:00
Maikel Linke
a7de56460d
Further simplify Order by outsourcing to service class
2022-09-29 12:06:06 +02:00
Maikel Linke
1f19642dad
Simplify Order by outsourcing to service class
...
This is work in progress and calling the service will be simplified in a
few commits.
2022-09-29 12:06:06 +02:00
Maikel Linke
a0260c4ff7
Move customer update logic to own service file
...
The Order class is too big already. We can move more code in the next
commits.
2022-09-29 12:06:06 +02:00
Maikel Linke
cec81a3ae6
Clarify condition to create customer record
2022-09-29 12:06:06 +02:00
Maikel Linke
37eac5ed49
Remove dead code branch in customer check
...
We only try to create a customer when none is present. So the check for
validating the customer always returned false because we didn't have a
customer.
2022-09-29 12:06:06 +02:00
Maikel Linke
b232fa3d0c
Deal with conflicting customer entries
2022-09-29 12:06:06 +02:00
Maikel Linke
f6ac02dce5
Update customer's email after user changed it
...
This may fail if there's already a customer record with the same email
address for the same enterprise. I will fix that in the next commit.
2022-09-29 12:06:06 +02:00
Maikel Linke
9dbba35019
Find customers by user id as well as email
...
Also fixing up a spec which became brittle due to too much mocking.
2022-09-29 12:06:06 +02:00
Maikel Linke
cf634d8d9b
Simplify customer association
2022-09-29 12:06:06 +02:00
Maikel Linke
5fefd3b14b
Remove useless customer loading and clarify name
...
The method `associate_customer` only loads a customer but doesn't
actually associate one. So the deleted line doesn't have any effect.
The intention was to reset the customer after switching shops but the
before_validation logic on the order model takes care of that already.
I'm renaming this private method here for clarity.
2022-09-29 12:06:06 +02:00
Maikel Linke
0d1f48ac0d
Simplify order-customer logic
2022-09-29 12:06:06 +02:00
filipefurtad0
9ab672d0b1
Restarts checkout flow for state 'confirmation'
2022-06-15 10:35:40 +01:00
georgethoppil
ec7d4b7c21
Restart checkout flow on cart empty if state of checkout is payment
2022-05-23 11:41:10 -04:00
georgethoppil
03b24bfc38
Destroy all adjustments on cart empty
2022-05-17 20:21:47 -04:00
GeorgeThoppil
8903496a1b
Optional restocking items
2022-05-06 10:55:24 -04:00
GeorgeThoppil
8aa4631e21
Setting payment state for subscription order
2022-04-13 19:08:51 -04:00
Maikel
a4bffc61f1
Merge pull request #8997 from apricot12/8968-Group-products-by-supplier-P1
...
Sort products by supplier in invoice
2022-04-13 11:54:12 +10:00
Nihal Mohammed
b2613f3331
Add translations
2022-03-28 18:26:39 +05:30
Nihal Mohammed
5f2f5456a0
Add code to sort order by supplier when Enterprise user chooses to
2022-03-28 18:12:39 +05:30
jibees
d4a4a36b14
Merge pull request #8766 from jibees/8477-cancel-order-and-send-confirmation-email-on-last-item-deletion
...
Edit order: on last item deletion, cancel the order and conditionally send cancellation email to consumer
2022-03-11 08:56:41 +01:00
Nihal Mohammed
e2bdc69a90
Update available_payment_methods method in enterprises_helper and order model
2022-03-07 17:33:09 +05:30
Maikel Linke
d09ba16411
Associate customers again
...
And simplify the before_validation actions.
2022-02-16 10:23:23 +11:00
François Turbelin
554a8625e5
Refactor ensure_customer method
2022-02-16 10:23:23 +11:00
François Turbelin
4cb31d04a7
Repair specs with default values on ensure_customer method
2022-02-16 10:23:23 +11:00
Adrien Chauve
5ca4d549e7
Update customer creation
2022-02-16 10:23:22 +11:00
Filipe
6e2c4a385a
Merge pull request #8810 from Matt-Yorkley/split-checkout-tax
...
Reduce expensive tax recalculation calls
2022-02-10 17:42:39 +00:00
Jean-Baptiste Bellet
50f547af98
Add an attribute that conditions the sending of the cancellation email
...
true by default to not change the default behavior.
Can be set to false when sending params send_cancellation_email
2022-02-10 14:39:00 +01:00
Matt-Yorkley
35392cb117
Remove Order#set_payment_amount!
2022-02-01 11:39:07 +00:00
Matt-Yorkley
448e4bb67b
Reduce expensive tax recalculation calls
...
This can only really be enabled once we've merged the split checkout
2022-01-29 18:56:52 +00:00
Filipe
374c05116b
Merge pull request #8726 from Matt-Yorkley/stringex-machina
...
Reduce impact of stringex gem
2022-01-26 19:02:41 +00:00
Matt-Yorkley
02590014ab
Improve split checkout feature toggle
2022-01-24 20:28:59 +00:00
Matt-Yorkley
2b960a04c6
Move Order callback entirely into service
2022-01-19 13:40:33 +00:00
Matt-Yorkley
8a944e3e78
Tidy up Order#save_default_addresses
2022-01-19 13:40:33 +00:00
Matt-Yorkley
8f37aa71f2
Save default addresses when requested during checkout
2022-01-19 13:40:33 +00:00
Matt-Yorkley
7062cab31f
Replace unnecessary uses of StringEx#to_url with ActiveSupport#parameterize
2022-01-15 10:22:10 +00:00
Matt-Yorkley
6d2521bf5f
Remove Spree.user_class
...
This construct was previously used in Spree to switch out the user class with a dummy class during certain tests. We don't use this any more, so it's just mess.
🔥
2021-12-10 18:18:20 +00:00
Matt-Yorkley
87fe341b5b
Remove dead code: Order#backordered?
2021-12-05 15:17:27 +00:00
Luis Azcuaga
e8fd89a6d2
Run rubocop over existing todo
2021-10-25 21:28:28 -05:00
Nihal M. Kelanthodika
82d9b041c9
Remove unnecessary spaces and newlines
2021-10-06 15:06:57 +05:30
Nihal
7eb0c6c33c
Add module to set unused ship, bill address fields
2021-10-06 15:06:56 +05:30
Nihal
5f1a326a05
Add before_validation callback to set unused addressed fields in customer, order, user, subscription, enterprise_group
2021-10-06 15:06:56 +05:30
Adrien Chauve
45eefb627d
Fix sorting orders by total in admin/ via api/v0/orders
2021-10-01 18:32:59 +02:00
Maikel
9affc6a945
Merge pull request #8108 from Matt-Yorkley/andand
...
Remove `andand` gem
2021-09-10 15:06:00 +10:00
Maikel Linke
e013d81e3d
Simplify safe navigation operator use < and []
2021-09-10 14:40:46 +10:00
Andy Brett
069cb043ee
Merge pull request #8148 from jibees/5236-remove-incomplete-orders-from-admin-interface-2
...
Only shows order that actually have at least one line_item V2
2021-09-09 16:49:30 -07:00
Matt-Yorkley
1d5077061e
Remove andand
...
This old gem implemented some functionality for handling nils which is no longer needed, as it's provided natively by Ruby with the &. operator.
2021-09-08 14:28:31 +01:00