Pau Perez
6bb37a3942
Check taxon's attribute instead of object identity
...
We don't care about the Ruby object instance but the actual DB record it
represents.
2020-08-31 11:05:12 +02:00
Matt-Yorkley
28651bbecf
Merge pull request #5941 from luisramos0/no_spree_specs
...
[Bye bye Spree] Make OFN independent of spec helpers under core/lib/testing_support
2020-08-27 17:05:45 +02:00
Pau Pérez Fabregat
6f33ae586e
Merge pull request #5943 from luisramos0/spree_factories
...
[Bye bye Spree] Make OFN independent of all spree spec factories
2020-08-27 08:54:20 +02:00
Luis Ramos
23c86a1937
Replace select2_search usages with faster targetted_select2_search and remove select2_search and dependent code
2020-08-26 23:06:25 +01:00
Luis Ramos
2abbfad18c
Remove the need to import both :role and :state factory to OFN
2020-08-23 14:47:30 +01:00
Luis Ramos
a44d0f7af6
Add WebHelper where necessary
2020-08-22 18:14:53 +01:00
Luis Ramos
41a7e26fcd
Remove unused helper
2020-08-22 18:14:53 +01:00
Luis Ramos
0ca4d0842a
Remove capybara_ext from spree and bring its helpers that are required in ofn
2020-08-22 16:50:12 +01:00
Luis Ramos
09b7aa134b
Ammend payment method spec and specify a calculator so that the default calculator is not the spree one that is based on a calculator that does not exist in OFN: Spree::Calculator::FlatRate
2020-08-07 18:36:59 +01:00
Pau Perez
c923edd3bb
Replace hardcoded URL with path helper
2020-07-29 11:36:49 +02:00
Luis Ramos
ecc58cedd9
Fix navigation problem in spec
2020-07-27 16:02:59 +01:00
Luis Ramos
27ace50eb7
Fix general settings path in specs
2020-07-27 16:02:57 +01:00
Luis Ramos
a2ebc614d9
Rename AuthenticationWorkflow to AuthenticationHelper
2020-07-27 15:32:35 +01:00
Luis Ramos
10b07aabd9
Rename quick_login_as to login_as
2020-07-27 15:32:35 +01:00
Luis Ramos
5738ec0542
Rename login_to_admin_and_visit to login_as_admin_and_visit
2020-07-27 15:32:34 +01:00
Luis Ramos
c6bb756531
Rename quick_login_as_admin to login_as_admin and also re-use login_to_admin_and_visit when applicable
2020-07-27 15:31:23 +01:00
Luis Ramos
8b04e45ea5
Create login_to_admin_and_visit to avoid loading the admin dashboard unnecessarily
...
This commit removes 19 unnecessary page loads of the admin dashboard
2020-07-27 15:31:11 +01:00
Luis Ramos
1af4bf6994
Replace usage of create_enterprise_user with :user factory
2020-07-27 14:44:23 +01:00
Luis Ramos
2605c4249b
Simplify spec, the 2 minutes wait is not necessary anylonger
2020-07-15 14:54:53 +01:00
Luis Ramos
9c8318d828
Merge pull request #5613 from luisramos0/calculators
...
Move all Calculators from spree to OFN and out of the Spree namespace
2020-07-13 15:16:15 +01:00
Matt-Yorkley
e742069959
Refactor UI interactions for opening exchange product tabs in OC edit
2020-07-08 11:11:39 +02:00
Matt-Yorkley
c8254b8338
Adjust exchange_row assertion to use slightly more specific criteria
2020-07-08 11:11:39 +02:00
Matt-Yorkley
be1e39f0cb
Ensure next page has loaded before interacting with form elements
2020-07-08 11:11:39 +02:00
Luis Ramos
5e8438c446
Move all calculators outside the spree namespace
2020-07-07 17:26:23 +01:00
Luis Ramos
804450bcc5
Fix buggy spec
...
The different shipping method was in the page but only as an option in the dropdown, not as the final selected shipping method! That was the cause of bug #5694 . We now check for the label Shipping which preceeds the final shipping method selection in the order page
2020-07-03 15:35:13 +01:00
Luis Ramos
658c77f3f5
Merge pull request #5701 from Matt-Yorkley/noimage
...
Noimage
2020-07-02 20:17:04 +01:00
Pau Pérez Fabregat
5a72526107
Merge pull request #5692 from luisramos0/taxonomies
...
Fix taxonomies flaky spec
2020-07-01 12:26:56 +02:00
Matt-Yorkley
b441ac2644
Update paths to "noimage" images
2020-06-29 20:07:08 +02:00
Cillian O'Ruanaidh
a9664e103d
Merge latest :master into :drop-blockenspiel branch and resolve conflicts related to Rubocop fixes.
2020-06-29 18:11:08 +01:00
Luis Ramos
10b8c2b789
Relax the assertion and dont check row number so that it passes even if order of elements is not the same
2020-06-27 15:54:58 +01:00
Luis Ramos
1e5975c6e2
Fix rubocop issues
2020-06-22 17:39:20 +01:00
Luis Ramos
f848a89a00
Rename update_attributes to update #rails4
2020-06-22 16:51:43 +01:00
Luis Ramos
8a9dae0ee2
Run rubocop autocorrect
...
This is the result of bundle exec rubocop --auto-correct
2020-06-22 12:23:10 +01:00
Pau Pérez Fabregat
db80992326
Merge branch 'master' into drop-blockenspiel
2020-06-19 12:12:10 +02:00
Luis Ramos
06a37d8ff0
Merge pull request #5566 from rioug/5132-no-error-when-product-csv-malformed
...
Add handling of CSV::MalformedCSVError for product_importer
2020-06-17 19:58:35 +01:00
Luis Ramos
2fcafdcf45
Add spec to cover editing zones
2020-06-16 15:13:54 +01:00
Luis Ramos
774b75b649
Make zones spec faster by going directly to zone list page withouth repeating the navigation through Configuration menu
2020-06-16 14:06:01 +01:00
Luis Ramos
d5bdf306a9
Comment out flaky variant overrides spec
2020-06-15 11:43:30 +01:00
Cillian O'Ruanaidh
fdf0d92366
Move feature spec for bulk coop report to the order management engine.
2020-06-13 15:52:42 +01:00
Luis Ramos
6dcb2d4a3b
Add xit, spec is still too flaky on semaphore
...
It's not the most important spec, this scenario should never happen as
the user will not be able to access the page.
2020-06-12 15:33:34 +01:00
Luis Ramos
f56e0ba0c0
Mock current_spree_user to return a user without permissions so that the controller does not use an already loaded version of current_spree_user that still has enough permissions
2020-06-12 14:23:45 +01:00
Luis Ramos
cf5af68438
Make spec less flaky by making it wait for the Saving text to go away
2020-06-12 13:04:33 +01:00
Gaetan Riou
359c0b9d85
fix typo
2020-06-11 16:54:00 +10:00
Luis Ramos
7924330321
Fix problem with stub_const, we need auto load the controller before the const is stubbed otherwise the controller will be broken
...
See details here: https://github.com/rspec/rspec-mocks/issues/1079#issuecomment-215620243
2020-06-09 10:52:53 +01:00
Gaetan Riou
9b8a97aadd
Add handling of CSV::MalformedCSVError for product_importer
2020-06-08 16:21:02 +10:00
Luis Ramos
beb1b3f3bc
Replay 02d46b7c51 lost in the last merge from master
2020-06-02 16:11:03 +01:00
Luis Ramos
c9a7a6e897
Merge branch 'master' into 3-0-stable-jun-2
2020-06-02 16:00:45 +01:00
Matt-Yorkley
1e3bf7fec4
Merge pull request #5487 from coopdevs/fix-schedule-factory
...
[Spree 2.1] Allow to create order_cycle_schedules
2020-05-30 13:49:47 +02:00
Pau Perez
862364ebbb
Fix schedule destroy spec
2020-05-29 10:24:50 +02:00
Maikel
2f82a58055
Merge pull request #5365 from mbudm/task/orderCycleSpecSplit
...
Split order_cycle_spec into smaller specs grouped by theme
2020-05-29 13:46:42 +10:00