2244 Commits

Author	SHA1	Message	Date
luisramos0	4fbd2cfa52	Extract UserDefaultAddress logic into separate class to take more 30 lines out of CheckoutController	2020-02-05 14:49:17 +00:00
luisramos0	383b28e170	Add order and current_user to checkout_form_data_adapter where they are required ... Also re-add order.state condition to update_result: in some tests, the order state is complete but no completion data (completed?) is present	2020-02-05 14:49:17 +00:00
luisramos0	bf55a15f81	Extract checkout params adaptation logic into a service class	2020-02-05 14:49:17 +00:00
luisramos0	43a6798db2	Move methods around in checkout controller into a more logical organisation: first the filters code and then support code for the update action	2020-02-05 14:49:17 +00:00
luisramos0	06d6579486	Refactor construct_saved_card_attributes to fix rubocop issues	2020-02-05 14:49:17 +00:00
luisramos0	76df526002	Remove dead code from construct_saved_card_attributes	2020-02-05 14:49:17 +00:00
luisramos0	06569ea24c	Refactor load_order to fix rubocop issues	2020-02-05 14:49:17 +00:00
luisramos0	25431f851b	Refactor object_params to fix rubocop issues	2020-02-05 14:49:17 +00:00
luisramos0	bab2420bb3	Break up default address methods to fix rubocop issues	2020-02-05 14:49:17 +00:00
luisramos0	0b2acb3a76	Extracted two methods from checkout_workflow to fix rubocop issues	2020-02-05 14:49:17 +00:00
luisramos0	27db9e604f	Extract respond_to_update_succeeded from update_succeeded	2020-02-05 14:49:17 +00:00
luisramos0	c4e58ebb9e	Extract update_succeeded from checkout#update	2020-02-05 14:49:17 +00:00
luisramos0	9a0ee254af	Extract checkout_workflow from checkout#update	2020-02-05 14:49:17 +00:00
luisramos0	5ce3e1e0d2	Fix some rubocop issues in checkout controller	2020-02-05 14:49:17 +00:00
luisramos0	4b345d928c	Remove old code to detect Phantom Fees, no bugsnag events detected at all	2020-02-05 14:49:17 +00:00
luisramos0	52b1e6c71a	Move all logic required in Spree::CheckoutController to CheckoutController	2020-02-05 14:49:17 +00:00
Luis Ramos	ea75714561	Merge pull request #4635 from luisramos0/main_app_routes ... Replace use of spree.root_path and root_url with main_app.root_path and main_app.root_url	2020-02-04 16:02:48 +00:00
luisramos0	44d1b3f00c	Remove unused search/users controller action	2020-02-04 14:55:34 +00:00
luisramos0	88464d58c2	Fix some rubocop issues and extract ransack hash to reduce repetition	2020-02-04 14:55:34 +00:00
luisramos0	962779bba1	Merge search controller with decorator	2020-02-04 14:54:51 +00:00
luisramos0	1ae73dd6ae	Add search_controller from spree_backend so that we can now merge it with the OFN's decorator	2020-02-04 14:54:51 +00:00
Pau Pérez Fabregat	246235b921	Merge pull request #4667 from Matt-Yorkley/rails-4-prep ... Rails 4 prep	2020-02-04 15:20:28 +01:00
luisramos0	bbb3748d3c	Simplify orders events logic	2020-02-04 11:51:13 +00:00
luisramos0	6e26841817	Fix load_order before filter and remove unused open and close adjustments actions	2020-02-04 11:50:44 +00:00
luisramos0	ab60c4a9dd	Remove unnecessary index action override because this is no longer a decorator ... Remove useless todo comment	2020-02-04 11:50:44 +00:00
luisramos0	7009cd89e0	Fix rubocop issues in customer details controller and update rubocop manual todo accordingly	2020-02-04 11:50:44 +00:00
luisramos0	b93af37ea9	Merge customer details decorator with controller	2020-02-04 11:50:03 +00:00
luisramos0	76b6a85509	Merge spree/admin/orders_controller and its decorator and fix a few rubocop issues	2020-02-04 11:50:03 +00:00
luisramos0	a1d4b4ee98	Add orders_controller from spree_backend so that we can now merge it with the OFN's decorator	2020-02-04 11:50:03 +00:00
luisramos0	51bca7ce2f	Add customer_details_controller from spree_backend so that we can now merge it with the OFN's decorator	2020-02-04 11:50:03 +00:00
Luis Ramos	c4bf4f001f	Merge pull request #4509 from luisramos0/backend_ctrl_payments ... Bring spree_backend payments controller to OFN	2020-02-04 11:46:23 +00:00
luisramos0	a5fe5fb448	Remove usage of deleted const DEFAULT_PAGE ... If params[:page] is not in the request, the results will not be paginated now	2020-02-03 15:04:34 +00:00
luisramos0	4c51d60bfd	Make pagination optional in the ExchangeProductsController	2020-02-03 13:11:26 +00:00
luisramos0	e192207f4e	Fix bug in before filters migration, needs to load payment for the show action	2020-01-30 10:27:26 +00:00
luisramos0	947914724a	Add frozen string literal magic comment	2020-01-28 18:02:58 +00:00
luisramos0	4596399bc2	Extract logic from controller to renderer service ... Re-using the filter_visible method for both products and variants	2020-01-28 18:02:58 +00:00
luisramos0	685abccb61	Make variant count consider oc config and not count variants that are hidden in the inventory of the coordinator of the OC	2020-01-28 18:02:58 +00:00
Luis Ramos	5e61ba8136	Merge pull request #4587 from luisramos0/navigation_helper ... Bring navigation helper from spree_backend	2020-01-28 17:58:18 +00:00
luisramos0	ee3c9563d8	Add all submenus entries to the main tabs list so that the main menu keeps selected when user selects the submenus	2020-01-23 14:31:25 +00:00
Maikel Linke	bd67d63b63	Restore payment error feedback	2020-01-23 16:20:07 +11:00
Maikel Linke	6763012ee9	Rescue unknown checkout errors	2020-01-23 16:20:07 +11:00
luisramos0	74226fbdf8	Fix one rubocop issue and update rubocop todo manual for the new controller	2020-01-22 20:22:28 +00:00
luisramos0	dc5374e284	Merge filter_payment_methods and load_data	2020-01-22 20:21:21 +00:00
luisramos0	f6ecf57737	Make before filters easier to understand using the fact that there are only index, create, new and fire actions in this controller	2020-01-22 20:21:21 +00:00
luisramos0	61ce849546	Merge spree/admin/payments_controller with its decorator and fix a few rubocop issues	2020-01-22 20:21:21 +00:00
luisramos0	12158d73fa	Add payments_controller from spree_backend so that we can now merge it with the OFN's decorator	2020-01-22 20:21:21 +00:00
Matt-Yorkley	5f3abbf00e	Refactor BaseController	2020-01-22 12:17:23 +01:00
Matt-Yorkley	59ebfb9bd4	Fix subquery errors triggered by #warn_invalid_order_cycles	2020-01-22 12:17:23 +01:00
Matt-Yorkley	57ca1d54bb	Fix issue with each_serializer not being called in some cases in Rails 4.	2020-01-22 12:17:23 +01:00
luisramos0	1e203ae419	Remove destroy with js format in variants controller, we dont use this endpoint in OFN and it avoids having to bring additional code from spree_backend	2020-01-16 11:59:36 +00:00