David Cook
fd8be37a62
Use shared page controls on products screen
...
This has an auto submit and can potentially work with Turbo, like on the Orders screen.
2024-04-10 15:17:56 +01:00
David Cook
0fc3d39106
Ensure pagination is retained when saving or discarding
...
But we have more work to do.
2024-04-10 15:17:56 +01:00
David Cook
2c71f7f1ed
Discard changes by reloading the page
...
Now there's a popup asking to confirm, which I think is worth keeping!
2024-04-10 15:17:56 +01:00
David Cook
8696e05e66
Move index and bulk_update actions to good ol' HTTP requests
...
We've found that we just can't rely in StimulusReflex (and the underlying WebSockets stack) to guarantee a response to a request.
Because of this, there was intermittent issues when the server was overloaded with large requests, and the response never arrived, leaving an infinite loader, and a poor user wondering if anything was still happening.
2024-04-10 15:17:56 +01:00
David Cook
d4da684f4a
Merge pull request #12349 from openfoodfoundation/dependabot/bundler/rubocop-1.63.0
...
chore(deps-dev): bump rubocop from 1.62.1 to 1.63.0
2024-04-10 10:32:32 +10:00
Maikel
c9c94fcaa5
Merge pull request #12337 from cyrillefr/FixRailsNegateIncludeRubocopIssue
...
Fix Rubocop Rails/NegateInclude issues
2024-04-09 10:40:47 +10:00
Gaetan Craig-Riou
103c6e7fc0
Remove debugging line
2024-04-09 10:30:46 +10:00
filipefurtad0
8ad4f885a0
Adds shared example for descending name ordering
2024-04-07 17:15:12 +01:00
filipefurtad0
f618ef1201
Adds regression spec for S2 bug #12340
2024-04-05 14:46:52 +01:00
cyrillefr
2877c793f8
Attempt to get rid of flaky spec #10027
2024-04-05 10:07:06 +02:00
David Cook
af2e3ca703
Merge pull request #12326 from filipefurtad0/deletes_connected_accounts_after_specs
...
Removes Stripe accounts created for testing purposes
2024-04-03 10:37:17 +11:00
Matt-Yorkley
a55931c081
Reinstate sorting by arbitrary list of product categories
2024-04-02 09:42:43 +11:00
Matt-Yorkley
2743a8183d
Disable sorting by user-defined product category order
2024-04-02 09:33:34 +11:00
Matt-Yorkley
d9899e8af6
Update more specs
2024-04-02 09:27:36 +11:00
filipefurtad0
66b98bd477
Removes connected account
...
Re-records relevant VCR-cassette on payments_stripe_spec
2024-04-01 11:36:09 +01:00
David Cook
266e94eba8
Fixup spec
2024-03-27 20:20:20 +11:00
David Cook
1d8ed67b0b
Handle unit scale changes
...
As discussed, this is the desired behaviour. The current screen appears to do this, but fails to save the changes.
2024-03-27 20:20:20 +11:00
David Cook
4ddb2ff1e9
Generate unit display with OptionValueNamer
2024-03-27 20:20:20 +11:00
David Cook
cf31d09ad8
Prevent submitting empty value
2024-03-27 20:20:20 +11:00
David Cook
49226ffdbc
Extract unit_value and unit_description values
...
Copied from display_as.js.coffee (ofn.admin.ofnDisplayAs.variantUnitProperties).
2024-03-27 20:20:20 +11:00
David Cook
436f733213
Add variant unit fields
...
Unfortunately we can't use an input[type=number] because you're allowed to type text for unit_description.
These fields will be conditionally shown/hidden in upcoming steps.
2024-03-27 14:34:31 +11:00
David Cook
189cd88848
Remove duplicate spec
...
Must have been an accident while merging conflicts
2024-03-27 14:33:32 +11:00
David Cook
9b040d87f6
Update spec
2024-03-27 14:33:32 +11:00
Maikel
4c1268b3ce
Merge pull request #12274 from mkllnk/dfc-product-import
...
Import products from DFC catalog
2024-03-22 09:25:02 +11:00
Anthony Musyoki
25e3f30f97
Fix Rubocop Rails issue: Rails/FindEach
2024-03-20 15:34:30 +03:00
David Cook
acb53a6ddc
Merge pull request #12273 from mkllnk/rubocop
...
Rubocop
2024-03-19 10:14:01 +11:00
Feruz Oripov
bdcb0856af
Fix failed specs
2024-03-16 19:23:17 +05:00
Feruz Oripov
9d919938f3
Group Order && OrderCycle related services and specs
2024-03-16 19:07:08 +05:00
Maikel Linke
3af7fa7521
Offer nice select box for enterprise id
2024-03-15 16:46:41 +11:00
Maikel Linke
30e8f9eb28
Importing products from DFC catalog
...
Technical demonstration of a complete product export-import roundtrip
which we could now do between OFN instances.
2024-03-15 16:46:41 +11:00
Maikel Linke
477336c660
Style RSpec/NotToNot
2024-03-15 12:17:48 +11:00
Maikel Linke
96ccea3691
Add controller to handle import of DFC products
...
It's not doing anything yet, but this is the basic setup.
2024-03-15 11:40:10 +11:00
Konrad
acc52cc45f
Merge pull request #11918 from abdellani/11896-prevent_bulk_printing_sending_when_ABN_not_set
...
Bulk printing/sending should show warning if ABN is required but not set.
2024-03-14 13:33:41 +01:00
Gaetan Craig-Riou
ff52a66e75
Merge pull request #12250 from mkllnk/not-to-not
...
Enforce RSpec expect(..).not_to over to_not
2024-03-12 10:35:16 +11:00
cyrillefr
7d99197dde
Requested changes: original fix moved up in code
...
- instead of selecting out unapplied tax rates in the total tax
method, did it in the query_result instead. Reverted the
total_excl_tax method to its initial state.
- spec and logic of testing affected also.
2024-03-11 10:13:46 +01:00
cyrillefr
62739c0458
Requested changes in spec
...
- use of new service instead of manually advancing an order
2024-03-11 10:13:46 +01:00
cyrillefr
7fdf1a110d
Fix incorrect results for multiple tax rates in report
...
- total_excl_tax would sum amounts and taxes without
knowledge if taxes rates were really applied or not
- spec shows use case described in issue 12066
2024-03-11 10:13:46 +01:00
Filipe
9abaf90907
Merge pull request #12233 from dacook/buu/unit-scale-basic-12005
...
[BUU] Unit Scale - basic implementation
2024-03-07 17:20:45 +00:00
Filipe
de9446f5f3
Merge pull request #12167 from mkllnk/haml-up
...
Update Haml syntax and gem to version 6
2024-03-07 15:36:29 +00:00
Rachel Arnould
cd9bef4f7b
Merge pull request #12172 from abdellani/12067-fix-invoice-render-multiple-tax-rates
...
fix invoice render multiple tax rates
2024-03-07 10:53:52 +01:00
Maikel Linke
bd6b0ddbf3
Enforce RSpec expect(..).not_to over to_not
2024-03-07 16:57:54 +11:00
David Cook
b3cf977c96
Add unit name (items) field
2024-03-06 13:41:22 +11:00
David Cook
864b876a9a
Add tom-select with naked style
...
The rem units are converted to em to make the padding relative to the chevron size. This means different font sizes will Just Work.
2024-03-06 13:41:22 +11:00
David Cook
ea0967e22e
Safely autocorrect Capybara/NegationMatcher
2024-03-06 09:20:22 +11:00
Filipe
af9f07f496
Merge pull request #12194 from cyrillefr/Replace-dropdown_controller-with-generic-toggle-control_controller
...
Re-implement dropdown controller with html details element
2024-03-05 16:28:29 +00:00
Filipe
ce2712f780
Merge pull request #12168 from rioug/11670-refund-stripe-payment-complete-order
...
Refund stripe payment when an order is complete
2024-02-28 18:08:50 +00:00
cyrillefr
f62b32a3b9
Requested changes after review
...
- modified css to increase clicking area
- modified spec to more straightfoward and more user oriented link
2024-02-28 08:15:34 +01:00
Gaetan Craig-Riou
b5beeead74
Remove stripe stub for refund scenario
2024-02-28 15:13:40 +11:00
David Cook
cb1f877117
Layout/LineLength
...
Manual fix, for some reason rubocop couldn't fix these automatically
2024-02-27 09:51:58 +11:00
cyrillefr
b08623df23
Sytem specs + controller spec
...
- controller spec is lighter since it is based on an html element
2024-02-25 16:43:57 +01:00
