Gaetan Craig-Riou
4e62e20fa8
Fix test to work with new jsdom restriction
...
since jsdom 21, it's no longer possible to mock window.location
See : https://github.com/jsdom/jsdom/issues/3492
2025-11-11 14:58:48 +11:00
Maikel
587f76415b
Merge pull request #13656 from pacodelaluna/replace-alias-attribute-with-alias-method
...
Replace alias_attribute with alias_method
2025-11-10 11:50:33 +11:00
Rachel Arnould
94bda6d0f8
Merge pull request #13592 from rioug/13266-tag-variant-tag-rule
...
[Variant tags] Add tag rules for variant
2025-11-07 14:14:50 +01:00
Filipe
95ad87d840
Merge pull request #13666 from chahmedejaz/bugfix/13519-order-disappear-from-orders-page
...
Order lines are deleted when one tries to capture a payment after order cycle is closed
2025-11-06 13:07:36 +00:00
Konrad
7357419f6f
Merge pull request #13652 from navaneethkp36/13651-fix-button-size-order-confirmation
...
Make the width of "Back to Store" and "Back to Website" buttons consistent with other buttons in order confirmation page
2025-11-05 19:29:42 +01:00
David Cook
8e5fac9fb3
Merge pull request #13632 from rioug/security-247-code-injection
...
[security] Fix potential code injection
2025-11-05 16:34:37 +11:00
Ahmed Ejaz
913dded766
Refactor order cycle handling to simplify closed cycle checks and improve redirection messaging
2025-11-05 02:50:01 +05:00
François Turbelin
b2d7d797d9
Use wrap_parameters to handle address params on Customer v1 API
2025-11-03 11:35:39 +01:00
François Turbelin
e385b9f708
Revert "Use customer-nested params for Customer v1 API writing operations"
...
This reverts commit cf4cd311b3 .
2025-11-03 10:32:26 +01:00
Gaetan Craig-Riou
bd0db57768
Per review, more concise code
2025-11-03 15:58:27 +11:00
Gaetan Craig-Riou
bb8ecccc31
Fix variant tag rules endpoint
...
It now returns tag rules filtered on the preferred variant tags and not
the prefered customer tags
2025-11-03 15:50:12 +11:00
Gaetan Craig-Riou
1a68236c3c
Add variant_tag_rule ability
...
It's needed to allow enterprise user to get a tag autocomplete. Classic
mistake of not testing with a non superadmin user.
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
c057bab493
Use route helpers for autocomplete url
...
Co-authored-by: Maikel <maikel@email.org.au >
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
59340c7cff
Per review, remove unnecessary new translation
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
ce60335a60
Per review, fix leftover comment
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
07a3e83dc6
Fix enterprise specs
...
Plus small refactor
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
38f58b168a
Fix tag rules spec
...
Make sure the autocomplete dropdown list is hidden by default
2025-11-03 14:25:48 +11:00
Gaetan Craig-Riou
ab194a0e80
Add styling for the dropdown
...
It's mostly the same styling as the AngularJs version but with updated
colors
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
749944fc25
Rework TagListInputComponent to integrate autocomplete
...
The component now will try to load a list of existing tag if you give an
`autocomplete_url`. I tried to keep the tag input and the autocomplete
functionality decoupled but is wasn't really possible. Instead I opted
to sub class the Autocomplete stimulus controller, but it only gets
initialised if we pass an `autocomplete_url`.
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
3cffc5538a
Add tag filtering for tag autocomplete
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
6d7908e1f8
Style formatting
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
965b34318f
Add new component to provide tag autocomplete for variant tag
...
It uses composition and inject the TagListInputComponent as a depency,
which should be more flexible that creating a sub class. This new
component could potentially be made more generic if needed
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
3bb9eb9765
Add endpoint to provide autocomplete tag for variant
...
It return a list of available tags and number of related rules, based on
the given enterprise and a partial match on the given tag
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
bd39595917
Add ability to pass option to the tag input field
...
And also render any content given to the component via block
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
81e16a9cdf
Add stimulus-autocomplete package
...
https://github.com/afcapel/stimulus-autocomplete/tree/main
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
c38c8bcff2
Pass the variant_tag_enbabled options to relevant services
...
Plus add integration testing for variant tag rule filtering.
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
7633af8ff2
Call VariantTagRulesFilterer when variant_tag feature is enabled
...
We only support either inventory or variant_tag feature, with the later
taking precedence if both are turned on.
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
94c0ebd897
Fix error in the muliple tag rules spec
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
7b3db4bae4
Add VariantTagRuleFilterer to filter variants by tag rule
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
b1d95cac7f
Display filter by variant tag rule
...
We only support one of filter by inventory variants or filter by variants
at any given time, based on enabled feature. If both features inventory
and variant tag are enabled, variant tag takes precedence.
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
3f297a8afa
Add tag rule to filter by variant
2025-11-03 14:25:05 +11:00
Gaetan Craig-Riou
96f715b62b
Merge pull request #13661 from deivid-rodriguez/ruby-3.2
...
Bump Ruby from 3.1.7 to 3.2.9
2025-11-03 13:29:40 +11:00
François Turbelin
cf4cd311b3
Use customer-nested params for Customer v1 API writing operations
2025-10-31 14:39:55 +01:00
François Turbelin
275326eaa6
Replace alias_attribute with alias_method
2025-10-31 14:26:33 +01:00
David Rodríguez
05b3e97a0e
Bump Ruby from 3.1.7 to 3.2.9
...
Release announcements:
* https://www.ruby-lang.org/en/news/2025/07/24/ruby-3-2-9-released/
* https://www.ruby-lang.org/en/news/2025/03/26/ruby-3-2-8-released/
* https://www.ruby-lang.org/en/news/2025/02/04/ruby-3-2-7-released/
* https://www.ruby-lang.org/en/news/2024/10/30/ruby-3-2-6-released/
* https://www.ruby-lang.org/en/news/2024/07/26/ruby-3-2-5-released/
* https://www.ruby-lang.org/en/news/2024/04/23/ruby-3-2-4-released/
* https://www.ruby-lang.org/en/news/2024/01/18/ruby-3-2-3-released/
* https://www.ruby-lang.org/en/news/2023/03/30/ruby-3-2-2-released/
* https://www.ruby-lang.org/en/news/2023/02/08/ruby-3-2-1-released/
* https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/
Also autocorrect new offenses.
2025-10-31 09:18:11 +01:00
David Rodríguez
201461918d
Fix prettier offense
...
I accidentally introduced this, not sure how, when correcting all
prettier issues.
2025-10-29 11:55:03 +01:00
Maikel
ff16b575c4
Merge pull request #13653 from deivid-rodriguez/bump-rubocop
...
Bump rubocop to 1.86.6
2025-10-29 12:00:31 +11:00
Maikel
44cca40db6
Merge pull request #13643 from deivid-rodriguez/fix-prettier-issues
...
Fix all existing prettier issues
2025-10-29 11:36:54 +11:00
David Rodríguez
4c6d894bc0
Bump RuboCop to 1.86.6
...
There were a few changes needed:
* Plugins are now specified through `plugin:` config keyword.
* All plugin gems need to be specified explicitly in Gemfile since they
are no longer dependencies of plugins already specified explicitly.
* All plugin gems need to be updated in other to use the new APIs.
* One cop was renamed.
* New offenses safe to correct were corrected directly with `bundle exec
rubocop -a`.
* New offenses unsafe to correct were added to the TODO configuration
with `bundle exec rubocop --auto-gen-config --auto-gen-only-exclude
--exclude-limit 1400 --no-auto-gen-timestamp`.
2025-10-27 11:30:33 +01:00
Ahmed Ejaz
895e142e2c
Enhance order cycle closure handling with improved messaging and redirection logic
2025-10-26 02:08:53 +05:00
Navaneeth
f1ffadd39c
Make the width of "Back to Store" and "Back to Website" buttons consistent with other buttons in order confirmation page
2025-10-25 22:15:14 +05:30
Filipe
cc35d118eb
Merge pull request #13627 from guidoDutra/10261/bad-table-format-in-edit-order-page
...
fix table format in edit order page
2025-10-24 13:16:49 +01:00
David Rodríguez
852e7fa81e
Fix all existing prettier issues
2025-10-22 15:30:36 +02:00
David Rodríguez
802878b4eb
Fix JS error when Stripe connect is disabled but Stripe API keys are setup
2025-10-21 17:24:34 +02:00
Gaetan Craig-Riou
adb7563ccb
Fix possible code injection
...
It will fix this security issue :
https://github.com/openfoodfoundation/openfoodnetwork/security/code-scanning/247
2025-10-21 15:48:27 +11:00
David Cook
125a92346c
Merge pull request #13599 from deivid-rodriguez/fix-duplicate-key-warning
...
Fix duplicate keys warnings in some views
2025-10-20 15:21:40 +11:00
Ahmed Ejaz
10917161b0
Refactor order cycle expiry handling to allow skipping order emptying during checkout
2025-10-20 01:42:20 +05:00
Guido Oliveira
be9da62d98
fix table format in edit order page
2025-10-19 07:58:40 -03:00
David Rodríguez
50578647ee
Follow up to old ofnEmptiesCart to ofnChangeHub rename
...
This happened back in 2015 through
9c9051498b , but two places were missed.
One was a code comment so did not affect anything (other than confused
code readers I guess?). The other one did create a regression but was
later fixed by 18d966f0de in 2021.
2025-10-16 12:56:17 +02:00
Rachel Arnould
c4c266246c
Merge pull request #13507 from rioug/tag-rules-remove-angular
...
[Variant Tags] Remove angular from tag rule admin page
2025-10-15 23:16:05 +02:00