filipefurtad0
4e24af2f94
Applies helper changes
2024-07-01 12:24:23 +10:00
filipefurtad0
0fa272a125
Changes helper for dropdown selection
2024-07-01 12:24:00 +10:00
filipefurtad0
2c3778360b
Updates selector
2024-07-01 12:24:00 +10:00
filipefurtad0
8b036e5108
Removes search block - covered already a few lines below
...
under _describe search_ block
2024-07-01 12:23:52 +10:00
filipefurtad0
c4b2748282
Adds pending test case on creating variants
2024-07-01 12:09:14 +10:00
filipefurtad0
289414a504
Adds tests around product creation
...
Introduces a tom-select helper file
2024-07-01 12:09:14 +10:00
filipefurtad0
d88db1365d
Updates specs to accomodate changes on warnings/banners
2024-07-01 12:09:14 +10:00
filipefurtad0
3af5330998
Updates product category test
2024-07-01 12:09:14 +10:00
filipefurtad0
e09fa3e04a
Updates v3 products page
2024-07-01 12:09:14 +10:00
filipefurtad0
2937bdc1d2
Deals with overlapping elements
2024-07-01 12:09:14 +10:00
filipefurtad0
c7894892f6
Deals with overlapping elements
...
Comments assertion due to overlapping elements
2024-07-01 12:09:14 +10:00
filipefurtad0
7303c40c92
Introduces helper to deal with overlapping elements
...
Fixes overlapping elements
2024-07-01 12:09:14 +10:00
filipefurtad0
50c7392c5e
Deals with overlapping elements
2024-07-01 12:09:14 +10:00
filipefurtad0
4871e0082e
Deals with overlapping elements
...
Deals with elements outside page range
2024-07-01 12:09:14 +10:00
filipefurtad0
8897e99113
Clicks OC warning modal away so other buttons are reachable
...
Another option would have been to use page.find(:button, Save).trigger(click)
2024-07-01 12:09:14 +10:00
filipefurtad0
527136105f
Fixes case on products_spec.rb
2024-07-01 12:09:14 +10:00
filipefurtad0
8a198705e3
Fixes case on reports_spec.rb
2024-07-01 12:09:14 +10:00
filipefurtad0
b9bb4a4dcb
displays a list of products
...
...adapted from ./spec/system/admin/bulk_product_update_spec.rb:23
Sets test as pending from issue #11060
2024-07-01 12:09:14 +10:00
filipefurtad0
1c580c42f4
Adds assertions on products page, when no products are found
...
Removes migrated test from legacy product spec file
2024-07-01 12:09:14 +10:00
filipefurtad0
5e4381cc63
Fixes case on failing test
2024-07-01 12:09:14 +10:00
filipefurtad0
9aecf9feb4
Brings the tests back to green, after rebasing
...
This is a WIP branch, and each time we rebase we'll have some specs breaking. The changes in this commit mostly relate to the change in /admin/products URL, which points to the new BUU prodcts page; disabling the feature around related tests brings the branch back to green.
2024-07-01 12:09:14 +10:00
filipefurtad0
308c559810
Fixes case on assertions, on failing specs
...
Selects white_label tab with trigger(click)
Scrolling down did no fix it, it still fails https://github.com/openfoodfoundation/openfoodnetwork/actions/runs/6526149195/job/17719815533?pr=11645 , selecting the element with trigger(click) should work
Updates invoice tests
2024-07-01 12:09:14 +10:00
Konrad
909bc2792c
Merge pull request #12565 from chahmedejaz/task/11987-remove-SR-from-clone
...
11987: Prevent Reloading the whole table upon Product Clone
2024-06-28 15:35:52 +02:00
Konrad
04dd463f8e
Merge pull request #12592 from mkllnk/report-rendering
...
Load large on-screen reports on demand
2024-06-28 11:14:38 +02:00
David Cook
898ab08bab
Add specs for invalid records
...
It turns out that the duplicator still raises an exception in some cases. Now I think I see why the the controller was catching the exceptions. At least now we know which exceptions to catch.
2024-06-27 11:39:49 +10:00
Ahmed Ejaz
b1a3bff2ed
11987: add failing spec for product clone
2024-06-26 16:48:14 +05:00
Ahmed Ejaz
5a259f1b91
Merge branch 'master' into task/11987-remove-SR-from-clone
2024-06-26 16:18:42 +05:00
Mohamed ABDELLANI
a3fd7b77c8
notify if any distributors doesn't have an abn
2024-06-24 14:46:01 +01:00
Gaetan Craig-Riou
c4470f76e3
Merge pull request #12593 from filipefurtad0/regression_spec_12591
...
Adds regression spec for #12591
2024-06-24 14:46:29 +10:00
Gaetan Craig-Riou
cd768a1fe9
Merge pull request #12585 from mkllnk/flaky-caching
...
Ensure all assets are compiled on test page visit
2024-06-24 14:44:11 +10:00
Gaetan Craig-Riou
c756afa1cc
Merge pull request #12571 from filipefurtad0/adds_spec_on_abn_restriction
...
Adds test case to assure acceptance criteria from #12374 and #12373
2024-06-24 14:41:31 +10:00
Konrad
25d375bf8e
Merge pull request #12577 from cyrillefr/WhiteLabelButtonAlwaysInactive
...
Update button should change status on modified white label
2024-06-20 11:39:58 +02:00
Ahmed Ejaz
349862c72e
11987: fix specs
2024-06-20 13:41:41 +05:00
Maikel Linke
98a29785a7
Load large on-screen reports on demand
...
Sending large reports via Cable Ready is unreliable. The events are
dropped at an unknown point and the report is never displayed to the
user. Instead we just send a link to the report via Cable Ready and
offer a button to load the report on screen.
This has the UX benefit of warning the user about the size as well.
Weaker devices can struggle rendering big HTML documents.
2024-06-20 11:32:33 +10:00
filipefurtad0
48a39f20e8
Adds regression spec for #12591
2024-06-19 19:30:42 -06:00
filipefurtad0
d1560ce15e
Adds shared examples for bulk send invoices in PDF
2024-06-19 17:58:58 -06:00
filipefurtad0
3380175c30
Restructures spec to accommodate shared example on bulk printing
2024-06-19 16:52:36 -06:00
filipefurtad0
59b6cdaf01
Extends tests to cases where ABN is an empty string
...
Removes pending and changes testcase
As discussed on Slack we will not fix old invoice model, for ref. see: https://openfoodnetwork.slack.com/archives/CG7NJ966B/p1718781775612759?thread_ts=1718249609.127149&cid=CG7NJ966B
2024-06-19 16:42:10 -06:00
cyrillefr
654fda89ca
Fix Rails/RedundantActiveRecordAllMethod issues
...
- Cop: Rails/RedundantActiveRecordAllMethod
- if receiver is an Active Record object, ".all" can be safely removed
- There are 2 allowed receivers that are listed in the
styleguide file (those are defaults cf. cop documentation).
2024-06-19 14:32:21 +02:00
Maikel
8837f1caa2
Revert "Allow negative stock levels for on-demand products"
2024-06-19 15:18:57 +10:00
Maikel Linke
d5b77a4f80
Ensure all assets are compiled on test page visit
2024-06-19 11:45:28 +10:00
filipefurtad0
fe93e3ed97
Restructures spec
...
Separating into different contexts, with and without invoices feature enabled
2024-06-18 19:32:44 -06:00
David Cook
2676891322
Merge pull request #12546 from dacook/buu/change-columns-11055
...
[BUU] Change product columns to be shown
2024-06-19 09:25:47 +10:00
Rachel Arnould
0c6cc9b822
Merge pull request #12558 from cyrillefr/BUUUploadingCorruptProductImagesFailsSilently
...
BUU Display error messages when file not valid
2024-06-18 12:12:51 +02:00
cyrillefr
8616847793
Update button should change status on modified white label
...
- swap position between users & white label so that user's inner form
- does not interfere with white_label own position in outer form
- modified spec so that lowermost user is clickable
2024-06-17 17:11:19 +02:00
David Cook
aff50f66c4
Name and Producer columns grow to fill and other tweaks
...
If neither are visible, the first column on the left (eg image) will grow. But that's not a likely scenario.
Min-widths help manage sizes on smaller screens in Chrome.
The title for Inherits Properties gets cut off, but I think it's better than cutting off content.
Oh look, it fixed a spec too!
2024-06-17 12:27:06 +10:00
Gaetan Craig-Riou
cc45b9a0d3
Merge pull request #12557 from filipefurtad0/feature_parity_buu
...
Updating specs for BUU (feature parity)
2024-06-17 09:39:01 +10:00
Maikel Linke
6a4a238378
Avoid flakiness with Capybara features
...
Capybara should be clever enought to scroll to an element. The old
method failed nine times in CI. I couldn't reproduce it locally but
let's see if this is better.
2024-06-14 10:47:35 +10:00
filipefurtad0
9cd1977cf8
Removes product creation test
...
This is already covered some lines above and on e22bec014b/spec/system/admin/products_spec.rb (L29)
2024-06-13 12:15:24 -06:00
filipefurtad0
9e5c21f7cd
Corrects test case by adding expect
...
has_select? only returns true or false, it requires an assertion to assure the test is evaluated
Improves syntax
2024-06-13 12:06:34 -06:00
