Konrad
4b6ef7796e
Merge pull request #10762 from mkllnk/report-encoding
...
Preserve encoding of stored reports
2023-05-03 17:08:44 +02:00
Konrad
b60a6fbd05
Merge pull request #10329 from thejwuscript/9861-improve-input-validation
...
Improve input validation on new and edit Payment Method pages
2023-05-03 16:11:21 +02:00
Maikel Linke
630169f8bb
Preserve encoding of stored reports
...
Active Storage reads stored strings as ASCII and that can clash with
Rails' default UTF-8 encoding when special characters are present.
2023-04-28 16:38:06 +10:00
David Cook
918425fd93
Remove customised error message
...
We're now handling these values on the frontend, so can keep this simple.
fixes up:
Add numericality validation for *
Add translation for Active Record error message
2023-04-28 14:02:12 +10:00
David Cook
a46eef291c
Remove localized number logic from calculators
...
The browser is now responsible for dealing with the decimal separator, for all numeric preferences (as input[type=number]; see Spree::Admin::BaseHelper::preference_field_tag). Calculators are the only place that numeric preferences are used.
It will enforce that only one comma or dot (depending on user's locale) is entered, thus avoiding any ambiguity, and mis-interpretation (eg 100,001 could be interpreted as more than 100 thousand or 100 with a decimal place).
2023-04-28 13:54:16 +10:00
Maikel Linke
dae8703b02
Remove unused feature to intercept emails
...
This option came from Spree and we never used it. The config input field
is disabled in the admin interface and I checked our managed databases.
I don't think that we will want this feature in the future either.
Staging sends unmodified emails which is more realistic and we haven't
had a use case to intercept those emails. There's still the BCC option
if we need additional access.
2023-04-26 13:50:31 +10:00
Konrad
75b5d1fd6f
Merge pull request #10712 from jibees/6133-backoffice-orders-endless-spinner-and-error-500-after-skipping-oc-selector
...
Admin, create new order: distributor and order cycle are now mandatory on step 1 (aka the set_distribution step)
2023-04-22 16:04:15 +02:00
Gaetan Craig-Riou
3810d79cad
Merge pull request #10695 from macanudo527/rename_inversables
...
Rename Inversable Method Names
2023-04-21 11:38:58 +10:00
Jean-Baptiste Bellet
92e2a83e0e
Use Rails7 command for image variant syntax
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
f42f513f8c
Display white_label_logo image when hide_ofn_navigation is set to true
...
for both desktop and mobile view
2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet
e3001cc8c4
Add white_label_logo to enterprise model as attachment
...
Co-Authored-By: Maikel <maikel@email.org.au >
2023-04-20 08:45:03 +02:00
Filipe
3e0b358370
Merge pull request #10461 from vviekk/9978
...
Updating price, on_hand, on_demand validations for product import
2023-04-19 16:09:49 +01:00
Filipe
f206b7ed9e
Merge pull request #10661 from mkllnk/report-download
...
[Hidden] Provide download link for reports generated in the background
2023-04-19 11:53:14 +01:00
Jean-Baptiste Bellet
7e306693a8
Use Rails standard naming: same name for the route and the method
2023-04-19 10:15:35 +02:00
saunmanoj888
97f51d24b8
Validate image on creating product from products/new
2023-04-19 16:11:46 +10:00
saunmanoj888
c3d274c84f
Fix corrupt and invalid image upload issue
2023-04-19 16:11:46 +10:00
Neal Chambers
4e32bfd70b
Rename Inversable Method Names
2023-04-18 22:58:06 +09:00
Jean-Baptiste Bellet
ac666a6fce
Validate presence of distributor and order_cycle in set_distribution step
2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet
73a81310f8
Create a new url /orders/ORDER_ID/distribution
...
That handles the step when distributor and order_cycle must be selected
2023-04-18 14:21:23 +02:00
David Cook
0f3e2ae572
Use browser validation for calculator values
...
They're all numbers, so we can reliably validate in the browser, removing the need for additional validation logic.
They will still be validated server-side, and in the unlikely even that there is an error, the generic 'Calculator is invalid' message will appear, with the relevant fields highlighted red. I think that's fine.
2023-04-18 09:50:08 +10:00
David Cook
353acfd6ae
Validate associated calculator with built in error handling
...
Except that pesky generic message was appearing. I still don't know how to control that so just deleted it.
2023-04-18 09:39:39 +10:00
David Cook
e43a018dc7
[wip] Copy each calculator error
...
But we still have the duplicate problem.
Wait a minute, it copies them in the same format that I am copying them. So.. I don't need to copy them at all!
Now I see that we just needed the right format in the translation file.
2023-04-18 09:39:39 +10:00
David Cook
f6fac018ea
[wip] Use a custom message format for associated errors
...
This is much simpler. Multiple messages get combined onto one line though, which is not perfect.
And.. it still seems to duplicate the errors. Weird, it's fine on my frontend though.
2023-04-18 09:39:39 +10:00
James Wu
29ddc68d20
Fix duplicate validation error message
2023-04-18 09:39:39 +10:00
James Wu
f5e2edb028
fixup! Modify Calculator validation error messages [wip]
...
DC: the error message has now become "Amount Invalid input".
2023-04-18 09:39:39 +10:00
James Wu
00cc8da2fc
Fix rubocop class length error
2023-04-18 09:39:39 +10:00
James Wu
1f3e66316b
Modify Calculator validation error messages
2023-04-18 09:39:39 +10:00
James Wu
6b1426d0c6
Add numericality validation for PriceSack
2023-04-18 09:39:39 +10:00
James Wu
c68987c0f2
Add numericality validation for PerItem
2023-04-18 09:39:39 +10:00
James Wu
2cb25e6366
Add numericality validation for FlexiRate
2023-04-18 09:39:39 +10:00
James Wu
073f46e590
Add numericality validation for FlatRate
2023-04-18 09:39:39 +10:00
James Wu
23beea8a13
Add numericality validation for FlatPercentPerItem
2023-04-18 09:39:39 +10:00
James Wu
096e388fdf
Add numericality validation for FlatPercentItemTotal
2023-04-18 09:39:39 +10:00
James Wu
b9b2fa7c94
Fix error converting String to BigDecimal
2023-04-18 09:39:39 +10:00
Konrad
1b536d9265
Merge pull request #10601 from abdellani/fix-v1-customers-endpoint-should-only-return-managed-enterprise-customers
...
fix: v1/customers endpoint should load customers of managed enterprises only
2023-04-16 16:22:02 +02:00
Maikel Linke
ebb15781d5
Store report's filename within the blob
...
For future downloads outside the ReportsController.
2023-04-14 11:29:35 +10:00
Maikel Linke
028c4f4281
Simplify ReportJob by extracting model for result
...
This makes the code heaps simpler.
2023-04-14 11:29:35 +10:00
Filipe
1bf5fbaf3a
Merge pull request #10449 from macanudo527/fix_ER
...
Update OCs after ER Permissions are Revoked
2023-04-12 18:59:20 +01:00
Konrad
2ace3afd67
Merge pull request #10606 from thejwuscript/10116-improve-bom-sorting
...
Sort orders by last name
2023-04-12 16:36:45 +02:00
Jean-Baptiste Bellet
b616c14f63
Don't hide producer's name in products despite hide all refs opt selected
2023-04-11 14:26:47 +02:00
Mohamed ABDELLANI
03cb14c926
define manage_by scope on customer model
2023-04-11 12:18:15 +01:00
James Wu
a75f16e23c
Implement full_name_for_sorting
2023-04-11 15:25:20 +10:00
Neal Chambers
940f806e5f
Fix Rubocop Layout/LineLength
2023-04-04 09:44:15 +09:00
Neal Chambers
77733169fc
Update OCs after ERs Permissions are Revoked
2023-04-04 09:37:13 +09:00
Filipe
62cdda2ce2
Merge pull request #10523 from rioug/10431-voucher-minimum-backend
...
Voucher bare minimum backoffice
2023-03-29 20:21:57 +01:00
Maikel Linke
6f83607aa8
Remove unused product meta description from DB
2023-03-29 14:35:16 +11:00
Maikel Linke
70aff98581
Remove unused product meta description from UI
2023-03-29 14:33:42 +11:00
Gaetan Craig-Riou
2e10336a47
Add ability to manage voucher for enterprise user
...
Update spec accordingly
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
04748b6e0e
Move voucher value to the model
...
Use Spree::Money to display amount with currency
2023-03-28 13:39:29 +11:00
Gaetan Craig-Riou
a48fd0828c
Add Voucher model
...
A voucher belongs to an enterprise and an enterprise can have many
vouchers
2023-03-28 13:39:29 +11:00
