David Cook
1213455350
Merge pull request #13202 from mkllnk/flaky-cache
...
Ensure we test for the right text after AJAX loads filters
2025-03-12 10:12:11 +11:00
David Cook
19ae49aa68
Merge pull request #13200 from mkllnk/caching
...
Make sure the first page load is complete before updating database
2025-03-12 10:11:00 +11:00
Maikel Linke
fc73d8cd4a
Ensure we test for the right text after AJAX loads filters
2025-03-11 17:02:48 +11:00
Maikel Linke
fc2515eac1
Make sure the first page load is complete before updating database
2025-03-07 13:08:50 +11:00
cyrillefr
9bb617d748
Fixes some rubocop linting offenses - part III
2025-03-06 23:42:53 +01:00
David Cook
d3b7db0082
Merge pull request #13186 from cyrillefr/FixRubocopLintIssuesII
...
Fixes some rubocop linting offenses - part II
2025-03-06 11:33:56 +11:00
Ahmed Ejaz
434434f451
13127 - add shipment state in the oc customer total report
2025-03-04 04:09:04 +05:00
cyrillefr
446b948889
Fixes some rubocop linting offenses - part II
2025-03-03 14:03:47 +01:00
Filipe
feccef0b36
Merge pull request #13157 from drummer83/email_styled_password
...
Create styled email for reset password instructions
2025-02-27 16:53:04 -06:00
Filipe
cf3213cf96
Merge pull request #13168 from dacook/dfc-product-import-select-all-12301
...
[DFC Orders] Select/deselect all on DFC Product Import
2025-02-27 16:43:37 -06:00
David Cook
5a1d6b749e
Fix spec
...
The label got changed in a separate PR that was merged around the same time.
It's my fault for changing the label.
2025-02-26 15:57:12 +11:00
Maikel
462886447a
Merge pull request #13126 from mkllnk/oidc-error
...
Direct people to refresh OIDC connection when needed
2025-02-24 15:45:48 +11:00
Konrad
7cd3c32787
Merge pull request #13164 from rioug/fix-user-controlled-method-execution
...
Fix user controlled method execution
2025-02-21 12:59:40 +01:00
Filipe
9baed8536c
Merge pull request #13121 from rioug/13054-out-of-stock-autoremove
...
Autoremove/update item from the cart if stock changed during checkout
2025-02-20 22:35:40 -06:00
Filipe
f715c366ea
Merge pull request #13160 from chahmedejaz/task/13097-add-columns-in-packing-reports
...
Add shipping method and shipment state to packing reports
2025-02-20 19:49:03 -06:00
Filipe
f7b471da08
Merge pull request #13148 from mkllnk/dfc-variants
...
Add DFC product groups with variants
2025-02-20 18:53:00 -06:00
David Cook
b370b207b5
Automatically bind toggleCheckbox action
2025-02-20 12:14:49 +11:00
David Cook
b92c046119
Automatically bind toggleAll action
...
We are already specifying the element's role ('all') in the HTML. Its behaviour should be predefined; there's no need to also specify in the HTML.
The eventhandler doesn't need to be cleand up on disconnect, because they are removed along with the DOM object.
2025-02-20 11:24:21 +11:00
David Cook
c2e54104d0
Add select/deselect all checkbox
...
There's A Controller For That.
(But I think it makes the HTML ugly..)
2025-02-20 10:56:53 +11:00
David Cook
859a20b7a7
Ensure both email formats contain url
2025-02-19 14:20:28 +11:00
David Cook
96b8a4c068
Merge pull request #13134 from dacook/fix-locale-12301
...
Update label and change default dev locale
2025-02-19 09:38:14 +11:00
Ahmed Ejaz
d0650fdab0
Fix ABC size rubocop issue
2025-02-19 02:20:33 +05:00
Ahmed Ejaz
1611b2a31f
Add shipping method and shipment state to packing reports
2025-02-18 12:42:34 +05:00
David Cook
664119ddcf
Update test for multi-part email
...
Now that it's a multi-part email, we have to select the html part for the test.
Another option is to simply check mail.to_s, but this also includes mail headers so doesn't specifically test the body.
2025-02-18 16:15:04 +11:00
David Cook
c9f5dd2d0b
Refactor: rename subject to be consistent
...
Hmm, in different specs it gets called 'mail', 'email', 'message'. The object is a Mail::Message object. The method to generate the object is called `mail`, so I went with that.
2025-02-18 16:07:22 +11:00
Gaetan Craig-Riou
0ae855047d
Fix User controlled method execution
...
Add white list for the fire endpoint to limit which action can be taken.
Add specs for fire endpoint
2025-02-18 14:42:26 +11:00
Maikel Linke
2043d1f8df
Remove custom syntactical sugar
...
It just makes Rswag specs look more different to other request specs and
I found that discouraging. It's good to know that the parameter is just
specified with `let` and that it works exactly in the same way as `let`
in other specs.
The downside is maybe that it's not obvious that those `let` statements
have to correspond with the parameters for the request but error
messages will tell you if you got it wrong. And there's also the
`parameter` declaration to make that clear.
2025-02-18 12:58:10 +11:00
Maikel Linke
6707516203
Automatically document responses for DFC API w/o tag
2025-02-18 12:58:10 +11:00
Maikel Linke
42b6ecbf31
Move rswag specifc config to rswag helper
2025-02-18 12:58:09 +11:00
Maikel Linke
ffe4084b7f
Link to OIDC settings from error message
...
The colour of the link is really bad though.
2025-02-18 12:15:13 +11:00
Maikel Linke
bb503e12a3
Direct people to refresh OIDC connection
...
Not the best UX but the easiest next step to implement. Next we should:
* Include link in error message instead of redirecting straight there.
Otherwise users may feel disoriented.
* Provide a custom error message?
2025-02-18 12:14:12 +11:00
Maikel Linke
00a2894e93
Clear invalid OIDC tokens
2025-02-18 11:48:17 +11:00
Gaetan Craig-Riou
4a2f22e56d
Add OutOfStockModalComponent
...
It encapsulate the logic for the out of stock modal
2025-02-18 10:47:03 +11:00
Filipe
e7ef5984d5
Merge pull request #13125 from dacook/dfc-product-import-list-12301
...
[DFC Orders] List products to import on screen
2025-02-13 22:34:32 -06:00
Filipe
dfe978520d
Merge pull request #13115 from dacook/oidc-record-not-unique
...
Catch error and provide message
2025-02-13 21:53:56 -06:00
Filipe
9f7405500a
Merge pull request #12621 from cyrillefr/KeepStockSelectionWhenErrorOnSaving
...
Keep stock selection when error on saving
2025-02-13 21:20:48 -06:00
filipefurtad0
77b857a30d
Adds test case when the hub is owner of the fee
2025-02-12 21:22:19 -06:00
filipefurtad0
48f5df349a
Adds test case on included tax
2025-02-12 21:22:19 -06:00
filipefurtad0
85ec771e27
Adds coverage on supplier option to charge tax
2025-02-12 21:22:19 -06:00
David Cook
13f5009563
Refactor
...
Co-authored-by: Maikel <maikel@email.org.au >
2025-02-13 09:34:19 +11:00
cyrillefr
2bc5ed49e6
Changes in spec
...
Due to the splitting of products_v3_spec in 4 parts.
2025-02-12 16:01:21 +01:00
cyrillefr
6d6164c8f6
Keep stock selection when error on saving
...
- added 2 not to be persisted attributes aimed at dealing with the UI
- added them to the permitted list
- updated view to switch mode about on_hand/on_demand
that is: from an already persisted variant or not
- Not persisted deals with on_*_desired not to be persisted fields
- Persisted mode deals with regular on_* fields
- the corresponding spec for both on_hand/on_demand
2025-02-12 16:01:21 +01:00
David Cook
f6f1a005cb
Add spec
...
Oh, and a transaction block. Because the controller after hooks tried to update the DB which resulted in
PG::InFailedSqlTransaction: ERROR: current transaction is aborted, commands ignored until end of transaction block
Even for a small rescue statement, it's worth adding a spec. You never know what might not be working!
2025-02-12 16:10:36 +11:00
Maikel
020ccedabe
Merge pull request #13141 from mkllnk/dfc-error-logging
...
Report DFC server errors to Bugsnag
2025-02-12 15:43:46 +11:00
Maikel Linke
d9cb1e8e74
Improve var naming, thanks Gaetan
2025-02-12 15:33:33 +11:00
David Cook
2d577e9e46
Merge pull request #13136 from mkllnk/flaky-oc-spec
...
Hopefully fix flaky OC spec
2025-02-12 14:29:43 +11:00
Maikel Linke
079d09b8b8
Report simple values easily
2025-02-11 15:36:07 +11:00
Maikel Linke
fa7edbb073
Alert ensures to pass metadata correctly
2025-02-11 15:27:58 +11:00
Maikel Linke
c90472ebf9
Update Bugsnag config naming
2025-02-11 14:57:46 +11:00
Maikel Linke
cc6a3f4e5b
Use Bugsnag key with valid format in specs
...
That's why Bugsnag wasn't active in CI.
2025-02-11 14:55:40 +11:00
