Carlos Chitty
446be6e127
Fix test failure due to hash interpreted as block in matcher
...
Wrap hash in parentheses to ensure it's passed as an argument rather than a block.
2025-04-29 15:16:29 -04:00
Carlos Chitty
63168086e7
Autocorrect Style/HashConversion offenses
2025-04-29 14:27:31 -04:00
Ahmed Ejaz
eee5d5c8ad
fix buggy spec:
...
- this before block was causing multiple nevigation to the index
- one from the spec itself, one from here.
2025-04-13 21:35:55 +05:00
Ahmed Ejaz
20146a8e11
update respective specs
2025-04-13 21:35:55 +05:00
Maikel Linke
b15ffe7a4e
Restore empty block with comment
...
RSpec tags are too complex for this simple setup.
2025-03-14 11:26:04 +11:00
cyrillefr
ba58a7b924
Fix: inconsiderate use of RSpec.configure
2025-03-13 10:08:35 +01:00
cyrillefr
e26d591d24
Fixes some rubocop linting offenses - part VI
2025-03-12 21:23:49 +01:00
Hartani Yassir
ace735b230
Merge branch 'master' into 12620-fix-rubocop-rails-response-parse-body
2025-01-31 11:23:15 +01:00
Hartani Yassir
bd41426aef
fix rubocop Rails/ResponseParseBody
2025-01-31 10:47:03 +01:00
Filipe
e2161660b3
Merge pull request #13090 from mkllnk/replace-spree-roles
...
Replace spree roles
2025-01-30 21:30:56 -06:00
Filipe
5d360730c7
Merge pull request #13023 from rioug/12907-fix-checkout-shipping-fee
...
[Checkout] Shipping fees update, remove order callback
2025-01-23 18:50:31 -06:00
Maikel Linke
d49cea5e3d
Use admin flag instead of user role
2025-01-22 14:59:49 +11:00
Gaetan Craig-Riou
0ca164a354
Fix spec
...
Use a completed payment, instead of trying to complete a payment
2025-01-21 10:51:08 +11:00
Filipe
3c1dd10219
Merge pull request #13047 from mkllnk/spree-roles
...
Clarify that our only user role is "admin" and simplify code
2025-01-16 18:06:49 -06:00
François Turbelin
e37881837b
Add unit tests for admin entreprises changes
2025-01-13 16:54:17 +01:00
Maikel Linke
5db8cb452e
Leverage Rails' caching when checking for admin
...
The privileges of a user should never change within a request
life cycle. The `spree_roles` association is very small, between 0 and 2
items are quickly searched in memory without the need of additional
database queries.
From memory, I've seen a lot of spree_roles queries in log files per
request. This should reduce it to one.
2024-12-19 10:12:31 +11:00
Maikel
e9c7e1778c
Merge pull request #12782 from mkllnk/reports
...
Add fallback report loading in case websockets fail
2024-08-23 09:23:42 +10:00
wandji20
4d222c61c6
Improve readability of order_cycle_set process method
2024-08-22 22:17:12 +01:00
wandji20
d599cf77a2
Fix failing specs
2024-08-22 22:17:12 +01:00
Maikel Linke
d354317c73
Replace cable_ready report loading w/ Turbo stream
...
I'm adding TurboPower for the scroll_into_view action. It adds all the
nice CableReady actions to Turbo Streams.
Note that I omitted `block: "start"` because that option is the default
in Javascript. And the generic `action` method doesn't support
parameters like this anyway. I'll work on that in the next commit.
I also re-introduced a race condition by rendering the "loading"
indicator after triggering the report rendering job. I'm planning to
resolve that later.
2024-08-16 14:37:57 +10:00
Maikel Linke
c31416c536
Separate showing and rendering report
2024-08-16 14:37:57 +10:00
Konrad
1a72b5b227
Merge pull request #12563 from abdulazizali77/bugfix/11326-incoming-exchange-per-item-calculator
...
Display only per_item fees for oc incoming exchange #11326
2024-08-02 03:11:27 +02:00
Joseph Johansen
5086f2d8b5
Fix rubocop Style/Send group
2024-07-23 14:18:26 +01:00
Gaetan Craig-Riou
29aa3a8059
Remove useless code
2024-07-12 10:34:42 +10:00
Abdul Aziz Ali
718e6765e1
Enterprise fee controller: Add all fees scenario #11326
2024-07-10 19:42:47 +08:00
David Cook
ca612282f9
Use Rails tmp dir for product imports again
...
In https://github.com/openfoodfoundation/openfoodnetwork/pull/3435 , it was switched to the system tmp dir because it conventiently provided a method to generate a unique filename. However it didn't handle the case where the system provided a symlink (macOS).
I could have fixed that, but surely it's safer to use the Rails tmp directory.
So I changed back to that, using a tip from https://stackoverflow.com/questions/13787746/creating-a-thread-safe-temporary-file-name to generate a unique name. Perhaps we could use a larger string (eg uuid) or append a timestamp too, but I don't know that it's necessary. Instead, we can just check that the dir didn't exist first (as mentioned in the PR). Let's do that..
2024-07-09 15:47:54 +10:00
David Cook
cc1fa7f563
Always avoid error on redirect_to
2024-07-09 13:57:06 +10:00
Gaetan Craig-Riou
04fb49bc25
Fix admin variant overrides controller specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
b5e76e1dab
Fix subscriptions controller specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
2952ebb05c
Fix admin report controller spec
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
b13a1e8843
Fix order cycle controller spec
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
1b7a5fdb2c
Fix inventory items controller
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
765655ae25
Fix bulk line items controller specs
2024-07-03 10:17:49 +10:00
Abdul Aziz Ali
9d12e55bd7
Add enterprise fees controller spec #11326
2024-06-26 06:36:57 +08:00
Ahmed Ejaz
ff10a36e4a
12346: refactor bulk_line_items_controller spec
2024-06-24 14:25:34 +05:00
Ahmed Ejaz
afd09091a2
12346 - fix broken specs
2024-06-22 02:11:39 +05:00
Ahmed Ejaz
98e0b0e703
12346 - fix rubocop rails/pluck errors
2024-06-22 01:45:58 +05:00
David Cook
89cedc4287
Submit and render with Turbo Stream
2024-06-12 14:49:59 +10:00
David Cook
68da9c9e04
Add form to save column preferences
2024-06-12 14:49:53 +10:00
Maikel Linke
6317fe1b71
Disable RSpec monkey patching
2024-05-09 12:24:41 +10:00
filipefurtad0
33889f1255
Deletes connected account, after spec
...
Re-records cassettes
2024-03-29 19:02:45 +00:00
filipefurtad0
1fd4c83cf1
Replaces fake with real client_it
...
Replaces stubs on Stripe Account Controller
2024-03-27 11:28:30 +00:00
Feruz Oripov
9d919938f3
Group Order && OrderCycle related services and specs
2024-03-16 19:07:08 +05:00
Maikel Linke
bd6b0ddbf3
Enforce RSpec expect(..).not_to over to_not
2024-03-07 16:57:54 +11:00
Gaetan Craig-Riou
9ab775c774
Merge pull request #12221 from mkllnk/rspec-sql
...
Use new rspec-sql gem
2024-03-04 11:37:38 +11:00
Maikel Linke
60b86e1d64
Replace custom query counter with new gem rspec-sql
2024-03-01 11:44:25 +11:00
Feruz Oripov
81f40a99d9
Update CustomersWithBalanceQuery
2024-02-26 23:25:33 +05:00
David Cook
2107aeded1
Un-safely autocorrect RSpec/ExpectChange
2024-02-23 12:17:09 +11:00
Konrad
dc4b6519dd
Merge pull request #11885 from dacook/flash-messages
...
Fix mapping of flash messages on order cycle pages
2023-12-06 18:03:57 +01:00
Gaetan Craig-Riou
55d64e1768
Fix rubocop warning
2023-12-04 10:36:53 +11:00
