Maikel
604cc10c3f
Merge pull request #11654 from openfoodfoundation/dependabot/bundler/rubocop-1.57.0
...
chore(deps-dev): bump rubocop from 1.56.4 to 1.57.0
2023-10-13 08:29:29 +11:00
Konrad
cc8898e074
Merge pull request #11219 from abdellani/fix-tax-rates-rendering-when-invoice-enabled
...
fix Viewing an invoice with the instance's invoice setting set to alternative model leads to an error 500
2023-10-12 17:47:27 +02:00
Konrad
f87186373c
Merge pull request #11647 from dacook/image-validation
...
Only validate image when changed
2023-10-12 15:42:22 +02:00
Maikel Linke
45dd5cc40a
Style/SingleLineDoEndBlock: Prefer multiline do...end block
2023-10-12 10:10:42 +11:00
Mohamed ABDELLANI
1c2aa1c370
fix linter issue
2023-10-11 11:00:37 +01:00
Mohamed ABDELLANI
7cb200e21e
fix linting errors
2023-10-11 09:27:16 +01:00
Mohamed ABDELLANI
fc519da83b
update the invoice system tests to run with invoice feature (enabled/disabled)
2023-10-11 09:27:16 +01:00
David Cook
b42cf9735f
Only validate an image if it has been changed
...
Best viewed with whitespace ignored.
2023-10-11 10:12:52 +11:00
David Cook
31b5be73f9
Add spec
2023-10-11 10:12:52 +11:00
Maikel Linke
228f69f13e
Test customer report filtering without sorting
...
The report doesn't seem to sort. So the specs don't expect that either
now. These specs were flaky before, depending on the random order in the
database query result.
2023-10-09 12:05:24 +11:00
Maikel
90c25d604b
Merge pull request #11441 from macanudo527/fix_rails_HasManyOrHasOneDependent
...
Fix Rails/HasManyOrHasOneDependent
2023-10-09 11:44:23 +11:00
David Cook
1c0ebfe61e
Add comment
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
95e7900585
test print invoice button under ACTIONS
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
a9719a798f
fix order mailer tests
2023-10-08 21:47:17 +02:00
Konrad
944925eb06
Merge pull request #11603 from murjax/prevent-customer-edit-shipped-9235
...
Prevent customers from editing shipped orders
2023-10-08 21:42:18 +02:00
Konrad
ef855e8887
Merge pull request #11619 from ccozkan/issue-11611
...
Add ability to customers report to filter with open ended boundaries
2023-10-08 16:28:52 +02:00
David Cook
9a9be8dacd
Validate length of variant fields
2023-10-06 14:15:07 +02:00
David Cook
3ec6386e1c
Validate length of some product fields
...
We know if the values are too long, so let's provide a useful message rather than generating an unhandled database error.
This code seems rather repetetive, it would be good to use a shared module. I wonder if there's a gem for that.
Note that the existing /products/*/edit screen doesn't even handle validation errors yet, but that's something for another day..
2023-10-06 14:15:07 +02:00
David Cook
3b19a19776
Show inline errors for product fields
...
The form helper () doesn't work for this case, but it seems we can call it directly like this instead. I'd like to fix the helper, but got stuck this time.
2023-10-06 14:15:07 +02:00
David Cook
cd34e160bf
Fix deleting of return_authorizations
...
return_authorizations have a stock_location_id, not the other way round. So there's no dependent field to nullify.
2023-10-06 10:58:49 +09:00
Çağrı Özkan
f93fcd347b
Rubocop fix
2023-10-04 02:00:21 +03:00
Çağrı Özkan
a5a13761a8
Filter with open ended boundaries upon missing params
2023-10-04 01:05:41 +03:00
Ryan Murphy
4db6570039
9235: Prevent customers from editing shipped orders
2023-10-03 08:36:57 -04:00
filipefurtad0
14caf3b25c
Moves helper into support folder
...
Wraps SubscripionHelper module around definitions
2023-10-03 09:49:26 +01:00
filipefurtad0
bc73d09438
Declares enable_subscriptions separately
2023-10-03 09:49:26 +01:00
filipefurtad0
96432ebec2
Splits files into new folder
...
Creates helper file for existing methods
2023-10-03 09:49:26 +01:00
filipefurtad0
8bc2feda23
Asserts for subscription instructions and tab
2023-10-03 09:49:26 +01:00
filipefurtad0
b554308f10
Sets correct context
2023-10-03 09:49:26 +01:00
Maikel
b122c93055
Merge pull request #11586 from macanudo527/fix_stylehash_11
...
Fix Style/HashSyntax 12/13
2023-10-02 16:25:21 +11:00
Maikel
350ca3b778
Merge pull request #11479 from filipefurtad0/split_split_checkout
...
Splits checkout files
2023-10-02 12:01:20 +11:00
Konrad
33d9ed4000
Merge pull request #11591 from dacook/admin-users-api-key-9833
...
Redirect to admin users edit path on success
2023-10-01 12:20:46 +02:00
Konrad
06ebeeac0f
Merge pull request #11543 from rioug/11364-Voucher-fix-tax-report
...
[Vouchers] Fix Sales Tax Totals By Order report
2023-10-01 02:09:33 +02:00
Neal Chambers
57d2f04330
Fix Style/HashSyntax
2023-09-29 08:51:48 +09:00
David Cook
e844d71abc
Redirect to edit path on success
...
Simply rendering the edit form on the posted path is problematic. For example if you refresh the path you get a 404.
But if there's errors, we want to render the form with unsaved values so you can see the errors and try again.
2023-09-28 09:41:44 +10:00
filipefurtad0
a634283ec5
Removes unecessary shipping method setup - guest
2023-09-27 22:20:31 +01:00
filipefurtad0
adede9df03
Removes unecessary shipping method setup - details
2023-09-27 22:19:37 +01:00
filipefurtad0
6763095f26
Removes unecessary shipping method setup - payment
2023-09-27 22:19:37 +01:00
filipefurtad0
3702a2e7b1
Removes unecessary shipping method setup - summary
2023-09-27 22:19:31 +01:00
filipefurtad0
25c58426db
Moves split-checkout files to own folder
...
Removes split_ prefix
2023-09-27 21:45:03 +01:00
Gaetan Craig-Riou
33f3c660a4
Fix rubocop warning
2023-09-26 11:21:05 +02:00
filipefurtad0
a4abedf3e3
Fixes rubocop issues
2023-09-26 10:18:28 +01:00
filipefurtad0
d3f9f989f6
Moves summary-step scenarios into dedicated file
2023-09-26 10:18:28 +01:00
filipefurtad0
67793c78ad
Moves payment-step scenarios into dedicated file
2023-09-26 10:18:28 +01:00
filipefurtad0
a0611057f0
Moves details-step/not selecting shipping method scenarios into dedicated file
2023-09-26 10:18:28 +01:00
filipefurtad0
b8f7d6102e
Moves guest/out of stock scenarios into dedicated file
2023-09-26 10:18:28 +01:00
Gaetan Craig-Riou
b129b9f1d0
DRY up specs
2023-09-26 10:50:58 +02:00
Gaetan Craig-Riou
e9051f5c58
As per review comment, clarify specs
...
And some DRYing
2023-09-26 10:26:06 +02:00
Gaetan Craig-Riou
02aaf6f692
Remove voucher validation on code format
...
The code doesn't rely on label match any more so this restriction
is not necessary anymore
2023-09-25 09:49:55 +02:00
Neal Chambers
70e218d2e9
Fix Style/HashSyntax
2023-09-25 13:15:38 +09:00
Neal Chambers
35e8f88943
Fix Style/HashSyntax
2023-09-24 22:41:27 +09:00
