11 Commits

Author	SHA1	Message	Date
Luis Ramos	e52937c113	Use rubocop auto correct to add frozen string literal to all files ... This is an unsafe auto corection, we will need to trust our build here	2021-06-17 23:07:26 +01:00
Luis Ramos	cb8fd2131e	Use body: nil instead of deprecated nothing: ... Ideally we would be using render head status but it's issuing quite a lot of double render problems, we can improve later	2021-03-16 23:13:58 +00:00
Luis Ramos	ed0441dc41	Fix a few more rubocop issues	2021-01-14 09:41:07 +00:00
Luis Ramos	96a351ad0e	Adapt usage of Sets to their new location	2021-01-14 09:41:07 +00:00
Luis Ramos	0fb9f44dda	Make all controllers use new Admin::ResourceController	2020-12-03 15:32:20 -08:00
Luis Ramos	f54abbd376	Fix rubocop issues	2020-06-22 17:39:20 +01:00
Luis Ramos	8a61257547	Rename all before_filter to before_action, it's the same function with a new name	2020-06-22 13:11:57 +01:00
Luis Ramos	7804c740a6	Add name to permitted params and fix some rubocop issues	2020-05-12 15:35:47 +01:00
Matt-Yorkley	90d1a5e605	Add strong params to admin/column_preferences_controller.rb ... Fixes failures such as: 119) Admin::ColumnPreferencesController bulk_update json where I don't own the preferences submitted prevents me from updating the column preferences Failure/Error: raise ActiveModel::ForbiddenAttributesError, params.to_s ActiveModel::ForbiddenAttributesError: {"action_name"=>"enterprises_index", "column_preferences"=>[{"id"=>1, "user_id"=>2716, "action_name"=>"enterprises_index", "column_name"=>"name", "visible"=>false}, {"id"=>nil, "user_id"=>2716, "action_name"=>"enterprises_index", "column_name"=>"producer", "visible"=>true}, {"id"=>nil, "user_id"=>2716, "action_name"=>"enterprises_index", "column_name"=>"status", "visible"=>true}], "format"=>"json", "controller"=>"admin/column_preferences", "action"=>"bulk_update"} # ./app/controllers/application_controller.rb:16:in `print_params' # ./spec/controllers/admin/column_preferences_controller_spec.rb:28:in `block (5 levels) in <top (required)>' # ------------------ # --- Caused by: --- # ActiveModel::ForbiddenAttributesError: # ActiveModel::ForbiddenAttributesError # ./app/models/model_set.rb:24:in `block in collection_attributes='	2020-02-23 14:52:06 +01:00
luisramos0	86b0d71c7e	Result of rubocop auto-correct and rebuilding rubocop_manual_todo	2019-05-28 12:57:29 +01:00
Rob Harrington	1d8719b474	Default column visibility can be set per user using ColumnPreferences model	2016-05-25 08:10:20 +10:00