5 Commits

Author	SHA1	Message	Date
Luis Ramos	7e39d78733	Fix Long Method rubocop issue	2020-11-27 13:59:46 +00:00
Luis Ramos	0152b4da55	Fix rubocop issues	2020-11-27 13:59:46 +00:00
Luis Ramos	2a03e42f2a	Update deep_munge patch to rails 4.1 where the code is now in ActionDispatch::Request::Utils	2020-11-27 13:59:46 +00:00
Cillian O'Ruanaidh	5a66c855bc	Add :frozen_string_literal magic comment and underscore prefix to unused block argument for Rubocop	2020-10-30 11:12:36 +00:00
Cillian O'Ruanaidh	ea3c456d3b	Patch Rails :deep_munge issue so empty array parameters don't get converted to nil ... Before people were unable to remove coordinator fees from an order cycle because Rails was converting the empty :coordinator_fee_ids array paramter into nil. This issue was introduced to Rails in v4.0.0.beta1 and isn't fixed until v5.0.0.beta1 Another way to fix this could be to do something like 'params[:coordinator_fee_ids] ||= []' but it seems like this issue could problems in other parts of the app so a more general fix might be better. Fixes #6224	2020-10-30 11:12:36 +00:00