Luis Ramos
9bbef16804
Converting all calls to ActiveRelation#sum to use a symbol with &
...
This is only applicable to database columns, if we are summing using a method in the model than the & is required!
2020-11-27 13:59:46 +00:00
Pau Pérez Fabregat
6db80e837b
Merge pull request #6361 from andrewpbrett/fix-gateway-error-error
...
move gateway_error require to lib/spree/core.rb
2020-11-13 13:15:13 +01:00
Andy Brett
17202ff39c
move gateway_error require to lib/spree/core.rb
2020-11-10 14:55:56 -08:00
Cillian O'Ruanaidh
89d63dfbb9
When resetting stock to 0 on absent products in inventory import also reset the on demand setting
...
Before when you imported inventory and clicked the 'Set stock to zero for all existing products not present in the file' option it would set the on hand stock to 0 but if the variant override was also set to be on demand the inventory would still be available for sale. This change makes sure the on demand setting is turned off too.
Fixes #6289 .
2020-11-06 14:57:31 +00:00
Luis Ramos
ab53db0c61
Merge ability and ability decorator
2020-11-04 12:15:45 +00:00
Luis Ramos
b7aa04353c
Fix requires of product duplicator
2020-11-04 12:15:45 +00:00
Luis Ramos
1bce516a45
Make specs load product duplicator
...
This makes the ofn version of the product duplicator be used instead of the spree one
2020-11-04 12:15:45 +00:00
Luis Ramos
f6195f1159
Remove duplicate_extra logic from ProductDuplicator
2020-11-04 12:15:23 +00:00
Luis Ramos
4b8515358c
Remove reference to FactoryGirl, it's FactoryBot that is used in OFN
2020-11-04 12:15:23 +00:00
Luis Ramos
d4e4669e49
Run transpec
2020-11-04 12:15:23 +00:00
Luis Ramos
e9f76cb339
Remove some dead code (Config.track_inventory_levels), remove variant.cost_price= so that localized number is seen, and fix specs
2020-11-04 12:15:23 +00:00
Luis Ramos
b68c5ee0f9
Remove dead code (prototypes) and fix specs
2020-11-04 12:15:23 +00:00
Luis Ramos
072cd2bd54
Run rubocop autocorrect in specs
2020-11-04 12:15:23 +00:00
Luis Ramos
8cb75fc6d8
Bring models from spree_core: Spree::Product and Spree::Variant!
...
EPIC COMMIT ALERT :-)
2020-11-04 12:15:23 +00:00
Pau Pérez Fabregat
4911bb6613
Merge pull request #6274 from luisramos0/rubocop
...
Use rubocop auto correct to fix a number of issues
2020-11-02 22:13:36 +01:00
Luis Ramos
c2c12b34f9
Fix more rubocop issues with auto correct
2020-10-30 17:10:23 +00:00
Luis Ramos
c71ebc38bb
Fix Layout/ArgumentAlignment
2020-10-30 17:06:08 +00:00
Luis Ramos
75cec3b606
Fix issue Style/HashSyntax
2020-10-30 16:50:37 +00:00
Luis Ramos
e8138e8c23
Fix rubocop issues in models/payment_spec
2020-10-30 16:50:37 +00:00
Luis Ramos
4845cde20f
Fix rubocop issue Layout/HashAlignment
2020-10-30 16:50:37 +00:00
Luis Ramos
a8265aff89
Fix rubocop issue Layout/FirstHashElementIndentation
2020-10-30 16:50:37 +00:00
Luis Ramos
06433b1be3
Fix rubocop issue Layout/ExtraSpacing
2020-10-30 16:50:37 +00:00
Luis Ramos
d4c52ce122
Fix rubocop issue Layout/EmptyLinesAroundBlockBody
2020-10-30 16:50:37 +00:00
Luis Ramos
eb4e732c1a
Fix rubocop issue Layout/EmptyLines
2020-10-30 16:50:37 +00:00
Luis Ramos
3fe2684270
Fix rubocop issue Layout/BlockAlignment
2020-10-30 16:50:37 +00:00
Luis Ramos
3e6e338e3d
Fix rubocop issue Layout/ArgumentAlignment
2020-10-30 16:50:37 +00:00
Luis Ramos
0618c9e4dd
Fix line_items_decorator spec
2020-10-30 10:12:56 +00:00
Luis Ramos
3730d76b44
Merge pull request #6155 from arku/perf/model-specs
...
Improve model specs' performance
2020-10-28 21:06:10 +00:00
Matt-Yorkley
489529d30e
Merge pull request #5729 from luisramos0/image_settings
...
Remove Image settings page and standardise Paperclip styles
2020-10-22 15:58:14 +02:00
Matt-Yorkley
f5ce0d501d
Merge pull request #5870 from luisramos0/prefs
...
[Bye bye Spree] Bring models app_configuration and preference from spree_core
2020-10-20 21:12:54 +02:00
Luis Ramos
b267f542d1
Merge pull request #5980 from luisramos0/spree_clean_up
...
[Bye bye spree] Some clean up fixes to make it all work without spree
2020-10-20 18:52:54 +01:00
Luis Ramos
0f06195baa
Remove Image settings page, these settings will come from ofn-install now
2020-10-20 11:20:37 +01:00
Arun Kumar Mohan
c65108731c
Define supplier_ids in inventory_reset_strategy specs for clarity
2020-10-17 20:12:14 -05:00
Arun Kumar Mohan
5928eba767
Use build to validate objects from the shipping method factory
2020-10-17 19:59:21 -05:00
Arun Kumar Mohan
874d33caaa
Convert multiline blocks to single-line ones
2020-10-17 19:44:57 -05:00
Maikel
8c65498661
Merge pull request #5998 from andrewpbrett/shipping-per-pound
...
Per-pound shipping calculator
2020-10-16 15:27:57 +11:00
Luis Ramos
4c9e4ee926
Fix problem in calculator spec
...
I am not sure why this started failing on this branch only and not in master but this fix is correct because line_items are created with order defined already, an order.reload is enough to load them into the order
2020-10-15 17:19:39 +01:00
Luis Ramos
fb3f35100f
Remove specs related to subsclassing the order class
...
This is not something we will do
2020-10-15 16:06:27 +01:00
Luis Ramos
249b4d124f
Remove more specs related to dynamic order checkout workflow
2020-10-15 16:06:27 +01:00
Luis Ramos
07b3c100e8
Remove code and specs related to dynamic checkout workflow, we have a static workflow defines in the Order class
2020-10-15 16:06:27 +01:00
Luis Ramos
d54ddacc05
Merge pull request #5887 from luisramos0/orders
...
[Bye bye Spree] Bring models order, line_item and other related from spree_core
2020-10-15 08:49:05 +01:00
Arun Kumar Mohan
2ec35b6306
Remove unnecessary let declaration
2020-10-13 01:22:11 -05:00
Arun Kumar Mohan
e963ab4bd4
Replace FactoryBot.create with create
2020-10-13 01:21:47 -05:00
Luis Ramos
9288250194
Merge pull request #5981 from luisramos0/spree_ability
...
[Bye bye spree] Bring classes related to abilities to OFN
2020-10-12 15:26:30 +01:00
Arun Kumar Mohan
14eee1c9e4
Improve product specs' performance
2020-10-11 01:10:11 -05:00
Arun Kumar Mohan
ff049d33e7
Improve variant stock specs' performance
2020-10-10 00:43:27 -05:00
Arun Kumar Mohan
b02e25af0e
Improve shipment specs' performance
2020-10-09 23:28:32 -05:00
Arun Kumar Mohan
76293c335b
Improve payment specs' performance
2020-10-09 23:05:14 -05:00
Arun Kumar Mohan
01d2c3cb9e
Improve variant specs' performance
2020-10-09 22:11:34 -05:00
Arun Kumar Mohan
80c76606df
Improve line items specs' performance
2020-10-09 22:11:34 -05:00
