Pau Pérez Fabregat
369a5a8a2f
Merge pull request #4101 from luisramos0/remove_variants_rabl
...
Convert spree/api/products and spree/api/variants views from rabl to AMS
2019-09-02 12:14:26 +02:00
luisramos0
b9ddb39edc
Re-add taxons jstree action to make taxonomies config page work again
2019-08-14 16:31:34 +01:00
luisramos0
31bac9641f
Move api products and variants routes and ctrl out of spree namespace
2019-08-01 14:28:55 +01:00
luisramos0
4497173213
Adapt spree/api/products_controller_spec to AMS serializer
2019-07-31 11:23:18 +01:00
luisramos0
4d74d246e8
Remove spree/api/products_controller index and new actions, not used
2019-07-31 10:32:45 +01:00
luisramos0
07aececdcf
Remove unused route api/products managed
2019-07-31 09:50:31 +01:00
luisramos0
c3fbf9cdf9
Remove unused pagination from index and respective specs, fix spec for search by sku by adding sku to the serializer and adapt a few specs to pass with AMS attrivbutes,
2019-07-31 09:40:19 +01:00
luisramos0
180598c603
Convert spree/api/variants_controller to AMS by changing base_controller, using render json instad of respond with, deleting rabl templates and adapting specs
...
Delete unused pagination spec
2019-07-31 09:40:19 +01:00
luisramos0
18aa16650d
Remove dependency to Spree::ApiConfiguration, overall requires_authentication? is true, exceptions will be endpoint specific
2019-07-31 09:35:46 +01:00
luisramos0
8bc9985edb
Transpec and fix rubocop issues in spree/api/variants_controller_spec
2019-07-31 09:32:33 +01:00
luisramos0
6dfc927730
Make spree/api/variant_controllers_spec pass
2019-07-31 09:32:33 +01:00
luisramos0
3771e26eba
Bring tests from spree/api/variants_controller_spec from spree_api
2019-07-31 09:32:33 +01:00
luisramos0
fd21d35aee
Transpec and fix rubocop issues in spree/api/shipments_controller_spec
2019-07-31 09:32:33 +01:00
luisramos0
1417b924d2
Bring and adapt tests from spree/api/shipments_controller_spec and mix them with exiting tests in OFN
2019-07-31 09:32:33 +01:00
luisramos0
2912c1b87d
Transpec and fix rubocop issues in spree/api/product_controller_spec
2019-07-31 09:32:33 +01:00
luisramos0
e746a0db7d
Bring tests from spree/api/products_controller_spec and add them to existing ones on the ofn side
...
Adapt these tests to have a green build
2019-07-31 09:32:33 +01:00
luisramos0
84a2886003
Improve auth code in spree/api/taxons_controller_spec
2019-07-31 09:32:33 +01:00
luisramos0
c668677b8a
Bring spree/api/taxons_controller_spec from spree_api, adapt it, transpec it and fix rubocop issues
2019-07-31 09:32:33 +01:00
luisramos0
2490cbfccb
Transpec and fix rubocop issues in spree/api/base_controller_spec
2019-07-31 09:32:33 +01:00
luisramos0
20a46a791c
Bring and adapt spree/api/base_controller_spec from spree_api
2019-07-31 09:32:33 +01:00
luisramos0
c5bcef6ae4
Delete unused spree/api/line_items_controller_decorator.rb
2019-07-31 09:32:33 +01:00
luisramos0
86b0d71c7e
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
luisramos0
6996353d05
Run transpec for spec/controllers
2019-05-10 01:20:40 +01:00
Pau Pérez Fabregat
380a9c561e
Merge pull request #3725 from coopdevs/add-specs-for-cache-variant-deletion
...
Add specs for the cache refresh on variant removal
2019-04-19 19:02:04 +02:00
luisramos0
46278e3edd
Set distributor in order and shipping methods so that refreshing shipment rates suceeds
2019-04-10 22:16:09 +01:00
Pau Perez
f20a15e955
Add specs for the cache refresh on variant removal
...
This is failing in `master` but thanks to the VariantDeleter it does work
in v2. This specs prove it.
2019-04-10 16:16:00 +02:00
Pau Pérez Fabregat
aed9c41b0d
Merge pull request #3394 from mkllnk/3021-update-soft-delete
...
[Spree upgrade] 3021 update soft delete
2019-02-25 11:58:41 +01:00
luisramos0
5d51ad71b0
Merge branch 'master' into 2-0-stable-Feb20
2019-02-20 14:32:36 +00:00
Maikel Linke
cdb49f88b0
Move Variant deletion into its own service
...
This keeps the override of Spree's model leaner. More importantly, it
prepares us for using `destroy` instead of `delete`.
In the past, `Product#delete` soft-deleted the product, but didn't
delete the variants. When we use `Product#destroy` to soft-delete the
product, it will also call destroy on the variants. If the model doesn't
allow the deletion of the last variant, it will fail. So when a product
is deleted we want to allow the deletion of all variants. But the user
should not be allowed to delete the last variant. That's why I'm moving
the check to the controller level.
Related commits:
- e6c7acdff3
- 2b47c9145a
- b9f19d5777 (diff-412c5af2ec1ba9f6643f6df5a673c1d4R105)
2019-02-19 14:25:18 +11:00
luisramos0
5ccbf7b3ca
Add specs for error cases in shipments_controller_spec
2019-02-13 10:37:21 +00:00
luisramos0
ba8096ff85
Improve method names in shipments_controller_spec
2019-02-12 17:31:58 +00:00
luisramos0
58ea28ebb4
Make Api::ShipmentsController#create re-use order.shipment if it exists
...
Improve code and add specs to this controller
2019-02-12 10:09:00 +00:00
luisramos0
3dc75c88d2
Delete empty controller class eval and spec. Useless left overs from 0ad2978926
2019-02-08 09:29:58 +00:00
luisramos0
e153510a71
Merge branch 'master' into 2-0-stable-nov-24th
2018-11-24 15:19:38 +00:00
Hugo Daniel
a08ddd8171
Use :user factory instead of build_stubbed to create the current_api_user
2018-11-22 14:29:37 +01:00
Hugo Daniel
4e29589be0
Add specs for cloning a product with image
2018-11-15 13:51:40 +01:00
luisramos0
efcf680094
Fixed bulk_line_items_controller_spec by setting shipment on test line_items and by allowing shipment decorator to allow no adjustments in the shipment
...
Fixed 5 out of 7 tests in orders_and_fulfillments_report_spec by providing target_shipment in test line_items
Fixed 12 out of 44 broken tests in bulk_order_management_spec.rb by providing target_shipment in test line_items.” “The remaining 32 failing tests are now failing with the very common: undefined method on_hand= on Spree::Variant
Improved 1 test in reports_spec.rb by providing target_shipment in test line_items. Test now fails with undefined method Spree::Order.shipping_method
Fixed 9 tests in orders_controller_spec by providing target_shipment in test line_items
Fixed 4 tests in packing_report_spec.rb by providing target_shipment in test line_items. Failing tests are now failing with undefined product.on_hand? method
Fixed 8 tests in line_items_controller_spec by providing target_shipment in test line_items
Fixed 1 test in update_billable_periods_spec by providing target_shipment in test line_items
Fixed 4 tests in bulk_coop_report_spec by providing target_shipment in test line_items. The 2 failing tests are now failing with undefined product.on_hand? method
Improved 1 test in line_items_controller_spec by providing target_shipment in test line_items. Test is still failing with an unexpected method call
Fixed 1 test in order_and_distributor_report_spec by providing target_shipment in test line_items
2018-08-30 00:33:15 +01:00
Daniel Dominguez
9d9a974295
Switched gem FactoryGirl to FactoryBot as FactoryGirl is deprecated.
...
- Change FactoryGirl to FactoryBot everywhere on code.
2018-05-04 11:52:08 -03:00
Pau Perez
72889b5c36
Stub current_user instead of api key's user
2017-12-21 10:24:29 +11:00
Pau Perez
bb0223877c
Remove unused arguments and reduce object creation
2017-12-20 17:25:23 +11:00
Pau Perez
5eb1fcddbb
Remove dependency on TestingSupport by inlining
2017-12-20 17:25:23 +11:00
Pau Perez
c646eb3939
Disable api auth as there is no Spree api key set
...
Although Spree::Api::Config[:requires_authentication] is set to false by
default for some unknown reason if not done explicitly Spree still
returns it as false.
This amends the change done in a87c89c83d ,
which introduced the bug. As there is no Spree api key set the auth
fails when getting taxons.
2017-12-20 17:25:23 +11:00
Rob Harrington
82072c8970
Explicitly specifying 'type: :controller' for all controller specs
2017-11-10 08:47:12 +11:00
enricostano
513330cfff
Add JSON api for products clone
2017-09-08 23:55:49 +10:00
Rohan Mitchell
fdd6400cb8
Fix perms for API soft delete
2016-11-04 09:39:17 +11:00
Maikel Linke
cd7721a127
Using date and time of current timezone
...
Using Time.zone.now and Date.current instead of Time.now and Date.today.
This should make all specs timezone independent.
2015-12-10 11:38:41 +11:00
Rob Harrington
ab7bfd10c5
Revert "Renaming options_text to unit_text so that we can use method from included VariantAndLineItemNaming module"
...
This reverts commit e86e08b72e939fee61eddd41d56081395666a877.
Conflicts:
lib/open_food_network/order_and_distributor_report.rb
spec/features/admin/variants_spec.rb
spec/lib/open_food_network/order_and_distributor_report_spec.rb
2015-10-28 13:08:50 +11:00
Rob Harrington
795830d94d
Renaming options_text to unit_text so that we can use method from included VariantAndLineItemNaming module
2015-10-28 13:07:31 +11:00
Lynne Davis
8639109372
Variable weights improvements additions
2015-08-04 20:13:28 +01:00
Rob Harrington
903ed7e507
Merge branch 'master' into variable_weights
...
Conflicts:
app/assets/javascripts/admin/bulk_order_management.js.coffee
app/views/spree/admin/orders/bulk_management.html.haml
app/views/spree/api/line_items/bulk_show.v1.rabl
spec/features/admin/bulk_order_management_spec.rb
2015-05-21 17:31:33 +10:00