Luis Ramos
4b8515358c
Remove reference to FactoryGirl, it's FactoryBot that is used in OFN
2020-11-04 12:15:23 +00:00
Luis Ramos
cf7d8067df
Fix easy rubocop issues
2020-11-04 12:15:23 +00:00
Luis Ramos
d4e4669e49
Run transpec
2020-11-04 12:15:23 +00:00
Luis Ramos
e9f76cb339
Remove some dead code (Config.track_inventory_levels), remove variant.cost_price= so that localized number is seen, and fix specs
2020-11-04 12:15:23 +00:00
Luis Ramos
b68c5ee0f9
Remove dead code (prototypes) and fix specs
2020-11-04 12:15:23 +00:00
Luis Ramos
072cd2bd54
Run rubocop autocorrect in specs
2020-11-04 12:15:23 +00:00
Luis Ramos
8cb75fc6d8
Bring models from spree_core: Spree::Product and Spree::Variant!
...
EPIC COMMIT ALERT :-)
2020-11-04 12:15:23 +00:00
Pau Pérez Fabregat
4911bb6613
Merge pull request #6274 from luisramos0/rubocop
...
Use rubocop auto correct to fix a number of issues
2020-11-02 22:13:36 +01:00
Luis Ramos
fa77204e14
Adapt spec to the move of the controller, in prod the call to request.env['PATH_INFO'] will work correctly
2020-10-31 10:44:19 +00:00
Luis Ramos
c9972189d0
Change usage of Spree::Admin::BaseController to Admin::BaseController
2020-10-31 09:56:59 +00:00
Luis Ramos
eb07a91acb
Adapt code from Spree::Admin::BaseController to Admin::BaseController
2020-10-31 09:52:34 +00:00
Luis Ramos
66ba9ff73d
Move Spree::Admin::BaseController to Admin::BaseController
2020-10-31 09:51:37 +00:00
Luis Ramos
eea73aa989
Merge pull request #5919 from luisramos0/injector_refactor_for_rails41
...
[Rails 4.1, works in master] Convert relations with to_a so that they work in rails 4.1
2020-10-31 09:33:27 +00:00
Luis Ramos
c2c12b34f9
Fix more rubocop issues with auto correct
2020-10-30 17:10:23 +00:00
Luis Ramos
c71ebc38bb
Fix Layout/ArgumentAlignment
2020-10-30 17:06:08 +00:00
Luis Ramos
b0e889be2a
Fix Style/RandomWithOffset
2020-10-30 16:50:37 +00:00
Luis Ramos
b3196295e6
Fix Style/RaiseArgs
2020-10-30 16:50:37 +00:00
Luis Ramos
75cec3b606
Fix issue Style/HashSyntax
2020-10-30 16:50:37 +00:00
Luis Ramos
92417d849c
Fix rubocop issue Rails/DynamicFindBy
2020-10-30 16:50:37 +00:00
Luis Ramos
bf5fcde885
Fix Lint/UnusedMethodArgument
2020-10-30 16:50:37 +00:00
Luis Ramos
40f8c785a2
Fix Lint/UnusedBlockArgument
2020-10-30 16:50:37 +00:00
Luis Ramos
403384dbb1
Fix rubocop isssues, trailing whitespaces and empty lines
2020-10-30 16:50:37 +00:00
Luis Ramos
c30cba8bfe
Fix issue Layout/SpaceInsideHashLiteralBraces
2020-10-30 16:50:37 +00:00
Luis Ramos
e8138e8c23
Fix rubocop issues in models/payment_spec
2020-10-30 16:50:37 +00:00
Luis Ramos
4845cde20f
Fix rubocop issue Layout/HashAlignment
2020-10-30 16:50:37 +00:00
Luis Ramos
a8265aff89
Fix rubocop issue Layout/FirstHashElementIndentation
2020-10-30 16:50:37 +00:00
Luis Ramos
9cb3b0b14a
Fix rubocop issue Layout/FirstArrayElementIndentation
2020-10-30 16:50:37 +00:00
Luis Ramos
06433b1be3
Fix rubocop issue Layout/ExtraSpacing
2020-10-30 16:50:37 +00:00
Luis Ramos
d4c52ce122
Fix rubocop issue Layout/EmptyLinesAroundBlockBody
2020-10-30 16:50:37 +00:00
Luis Ramos
eb4e732c1a
Fix rubocop issue Layout/EmptyLines
2020-10-30 16:50:37 +00:00
Luis Ramos
3fe2684270
Fix rubocop issue Layout/BlockAlignment
2020-10-30 16:50:37 +00:00
Luis Ramos
3e6e338e3d
Fix rubocop issue Layout/ArgumentAlignment
2020-10-30 16:50:37 +00:00
Luis Ramos
cf3f511f4d
Add directive spec to validate the dialog template is loaded on element click
2020-10-30 15:09:13 +00:00
Luis Ramos
1d1067ebc1
Add coverage to T&Cs file opening on a new tab and also for the upload timestamp now displayed in the page
2020-10-30 15:09:13 +00:00
Luis Ramos
ceee89fad0
Make Checkout form submit read terms_and_conditions_accepted from the checkout form checkbox
2020-10-30 15:09:13 +00:00
Luis Ramos
a942218708
Fix post checkout actions spec
2020-10-30 15:09:13 +00:00
Luis Ramos
dd31cbe014
Cover case where enterprise uploads new T&Cs file and customer has already accepted before
2020-10-30 15:09:13 +00:00
Luis Ramos
46733d0c0d
Add feature spec to cover T&Cs ticked by default if customer has already accepted them
2020-10-30 15:09:13 +00:00
Luis Ramos
57a9d6e1e2
Make customer terms_and_conditions_accepted_at be set to current time
...
after a successful checkout
2020-10-30 15:09:13 +00:00
Luis Ramos
3c9c5862d1
Verify terms and conditions updated_at timestamp is touched every time the file name changes.
...
We will need this to check if user already accepted the terms and
conditions of this enterprise.
2020-10-30 15:08:26 +00:00
Luis Ramos
78a8f53d8d
Change default translations to what's been requested on the issue
2020-10-30 15:08:26 +00:00
Luis Ramos
85096a997f
Add a checkbox to checkout to tick for Terms and Conditions
...
Checkout button should be disabled if checkbox is not ticked
2020-10-30 15:08:26 +00:00
Cillian O'Ruanaidh
5aa8c783b1
Use Rspec syntax instead of Test::Unit in ActionDispatch::Request spec.
2020-10-30 11:12:36 +00:00
Cillian O'Ruanaidh
ea3c456d3b
Patch Rails :deep_munge issue so empty array parameters don't get converted to nil
...
Before people were unable to remove coordinator fees from an order cycle because Rails was converting the empty :coordinator_fee_ids array paramter into nil. This issue was introduced to Rails in v4.0.0.beta1 and isn't fixed until v5.0.0.beta1
Another way to fix this could be to do something like 'params[:coordinator_fee_ids] ||= []' but it seems like this issue could problems in other parts of the app so a more general fix might be better.
Fixes #6224
2020-10-30 11:12:36 +00:00
Luis Ramos
0618c9e4dd
Fix line_items_decorator spec
2020-10-30 10:12:56 +00:00
Luis Ramos
d15301021a
Rename inject_json_list to inject_json_array
2020-10-30 10:12:56 +00:00
Luis Ramos
9a9b455e66
Fix problem in default_tax related to sum in active record
2020-10-30 10:12:56 +00:00
Luis Ramos
7e606471e4
Make tag_rulee_applicator and available_payment_methods_filter handle case where a relation is given instead of an array
2020-10-30 10:10:54 +00:00
Luis Ramos
08d26102d2
Separate injection methods so that we can have a separate behaviour for lists without having to check their types
...
This change is required for rails 4.1 where the relations api changed
2020-10-30 10:10:54 +00:00
Luis Ramos
6b826423c1
Merge pull request #6145 from andrewpbrett/instance-unit-picker
...
Allow instances to choose available units for products/variants
2020-10-29 22:22:33 +00:00