1156 Commits

Author	SHA1	Message	Date
Jean-Baptiste Bellet	5b9815f4a3	Test that restock has been called or not, depending on checkbox checked	2023-04-24 15:03:14 +02:00
Konrad	75b5d1fd6f	Merge pull request #10712 from jibees/6133-backoffice-orders-endless-spinner-and-error-500-after-skipping-oc-selector ... Admin, create new order: distributor and order cycle are now mandatory on step 1 (aka the set_distribution step)	2023-04-22 16:04:15 +02:00
Gaetan Craig-Riou	2f17a02974	Merge pull request #10726 from mkllnk/spec-email-helper ... Remove useless email test setup	2023-04-21 15:43:19 +10:00
Jean-Baptiste Bellet	81606e841a	Canceling an order: clicking on cancel btn or cancel action in dropdown	2023-04-20 14:38:59 +02:00
basilawwad	e633670e01	Use a shared_examples for the order cancellation tests	2023-04-20 14:38:59 +02:00
Jean-Baptiste Bellet	ba45dd84dd	Solves rubocop linter errors	2023-04-20 08:46:19 +02:00
Jean-Baptiste Bellet	f42f513f8c	Display white_label_logo image when hide_ofn_navigation is set to true ... for both desktop and mobile view	2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet	54342254b6	Do not show white label logo is hide_ofn_navigation is not checked ... They are both strongly linked	2023-04-20 08:45:03 +02:00
Jean-Baptiste Bellet	6fdf9fa038	Add/Remove white label logo in enterprise preferences panel	2023-04-20 08:45:03 +02:00
Maikel Linke	9b3cfe80ff	Remove useless clearing of test emails ... They are cleared by the test environment anyway.	2023-04-20 13:35:40 +10:00
Maikel Linke	915bd19d7b	Remove useless email test setup ... We always deliver emails these days.	2023-04-20 12:18:04 +10:00
Maikel Linke	9998025687	Remove useless test header setup for emails ... Once upon a time we needed a helper to set the `from` header of emails. This is now set in the ApplicationMailer and not necessary any more.	2023-04-20 12:15:34 +10:00
Filipe	3e0b358370	Merge pull request #10461 from vviekk/9978 ... Updating price, on_hand, on_demand validations for product import	2023-04-19 16:09:49 +01:00
Filipe	f206b7ed9e	Merge pull request #10661 from mkllnk/report-download ... [Hidden] Provide download link for reports generated in the background	2023-04-19 11:53:14 +01:00
saunmanoj888	c3d274c84f	Fix corrupt and invalid image upload issue	2023-04-19 16:11:46 +10:00
Maikel	0b03152f3b	Merge pull request #10697 from mkllnk/rubocop-config-update ... Update Rubocop config and replace deprecated TimeWithZone#to_s with argument	2023-04-19 11:23:34 +10:00
Konrad	2fa86492d1	Merge pull request #10653 from openfoodfoundation/10645-pagination-in-bom-not-aggregating-results-when-clicking-a-productvariant ... BOM: When selecting a specific variant, trigger a new search that avoid pagination issues	2023-04-18 14:49:14 +02:00
Jean-Baptiste Bellet	722c660697	Do not show any links to other steps when no distribution set ... distribution means tuple: distributor + order cycle	2023-04-18 14:36:47 +02:00
Jean-Baptiste Bellet	ac666a6fce	Validate presence of distributor and order_cycle in set_distribution step	2023-04-18 14:36:47 +02:00
David Cook	43e51cb592	Simplify login spec helpers, avoid long lines ... Follow on from 5c6d9a092e	2023-04-18 10:01:23 +10:00
David Cook	6570891349	Fix linter issues ... Although I don't think the size was an issue here, small hashes can easily fit on one line.	2023-04-18 09:50:08 +10:00
David Cook	0f3e2ae572	Use browser validation for calculator values ... They're all numbers, so we can reliably validate in the browser, removing the need for additional validation logic. They will still be validated server-side, and in the unlikely even that there is an error, the generic 'Calculator is invalid' message will appear, with the relevant fields highlighted red. I think that's fine.	2023-04-18 09:50:08 +10:00
David Cook	353acfd6ae	Validate associated calculator with built in error handling ... Except that pesky generic message was appearing. I still don't know how to control that so just deleted it.	2023-04-18 09:39:39 +10:00
David Cook	ce1bd12760	Consolidate specs ... It takes time to set up this test case. Given that there's no interactions in the expectations, we should save time to generate it only once.	2023-04-18 09:39:39 +10:00
James Wu	2a7cb50fa9	Keep and display submitted data on new payment method page	2023-04-18 09:39:39 +10:00
James Wu	ae5f2cc19d	Fix error saving data on new Calculator	2023-04-18 09:39:39 +10:00
James Wu	41ce4fbc16	Fix cache issue with invalid form data	2023-04-18 09:39:39 +10:00
James Wu	48753df5f0	Improve input validation and error notification	2023-04-18 09:39:39 +10:00
Filipe	871b2f8816	Merge pull request #10696 from mkllnk/login-as-admin ... Simplify login test helpers	2023-04-17 12:14:06 +01:00
Jean-Baptiste Bellet	11a7aa9f96	When clicking on "Clear Filters" button, to not reset variant selection ... + add some specs to cover that particular case	2023-04-17 11:08:17 +02:00
Jean-Baptiste Bellet	c0203e7091	Refactor by putting two specs into a shared_example ... "It's a Surprise Tool That Will Help Us Later"	2023-04-17 11:06:23 +02:00
Maikel	44cc5cc665	Merge pull request #10677 from mkllnk/spec-helpers ... Simplify spec helpers	2023-04-17 16:16:29 +10:00
Maikel Linke	5c6d9a092e	Simplify login spec helpers, avoid long lines ... The `login_as_admin_and_visit` helper was used a lot but isn't really shorter than: login_as_admin visit path_visit Calling those methods separately reduces line length. It also removes the potential impression that it may be more efficient to use the helper. Now we have less indirection if one of the calls fails and see the failing spec line straight away.	2023-04-17 11:08:32 +10:00
Maikel Linke	8d500a2c27	Remove superflouous login test helper ... It was often used with a `visit` statement after which resulted in unnecessary page loads. There was only one case where a `visit` was expected but it wasn't needed either.	2023-04-17 10:56:51 +10:00
Maikel Linke	425674c4e5	Remove unused return value of admin login helper ... Well, there was one use of the return helper. But I don't think that it's a very intuitive method.	2023-04-17 10:56:51 +10:00
Maikel Linke	dad4061ff9	Style Rails/ToFormattedS	2023-04-14 16:32:39 +10:00
Maikel Linke	c70a694111	Style line length - rubocop passes completely	2023-04-14 16:12:14 +10:00
Maikel Linke	9c88c77066	Style empty lines	2023-04-14 16:05:50 +10:00
Maikel	b0211d0930	Merge pull request #10686 from filipefurtad0/truncates_product_description ... Sets too long line truncation spec as pending	2023-04-14 15:11:31 +10:00
Maikel	5ff1b0d358	Merge pull request #10676 from filipefurtad0/fix_spec_ts_and_cs ... Adds pending test for default ToS	2023-04-14 14:00:32 +10:00
Maikel Linke	98e4f867b4	Provide download link for generated reports	2023-04-14 11:29:35 +10:00
Konrad	2ace3afd67	Merge pull request #10606 from thejwuscript/10116-improve-bom-sorting ... Sort orders by last name	2023-04-12 16:36:45 +02:00
Konrad	0bfceb877d	Merge pull request #10666 from jibees/9723-admin-missing-translation-in-payment-report ... Admin, Payment reports: add missing translation for payment state	2023-04-12 15:47:23 +02:00
Filipe	c1d28b2e8f	Merge pull request #10119 from binarygit/donot-hide-producers-name-in-products ... Display producer's name in products inspite of hide all refs option	2023-04-12 13:07:52 +01:00
Jean-Baptiste Bellet	2841b42296	Specify truncate parameter as we don't always truncate description ... Only when too long.	2023-04-12 10:34:30 +02:00
filipefurtad0	26947a64c0	Adds test to check pagination upon line-item selection	2023-04-12 09:58:01 +02:00
Maikel Linke	f13c0e1dca	Bring all Rspec config for database cleaning together	2023-04-12 14:23:09 +10:00
MadisonBowron	8c6e0a841c	Fix rubocop extra blank line error	2023-04-11 15:35:37 -04:00
filipefurtad0	70d9cfa08e	Sets too long line truncation spec as pending	2023-04-11 19:46:11 +01:00
Filipe	0971e8d9b5	Merge pull request #10644 from mkllnk/report-timeout-message ... [Hidden] Display a friendly message when a background report times out	2023-04-11 19:40:42 +01:00