16 Commits

Author	SHA1	Message	Date
Maikel Linke	a01aa8849c	Add Ruby version to engines for Rubocop ... > This ensures that RuboCop is using the same Ruby version as the gem. https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Gemspec/RequiredRubyVersion	2023-07-21 14:13:26 +10:00
Matt-Yorkley	1daab8994d	Remove is_master and not_master scopes	2023-06-16 21:23:44 +01:00
Maikel Linke	213fb42a05	Safely autocorrect Gemspec/RequireMFA ... Inspecting 1404 files .............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W.....................W....................................W...........................W....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... Offenses: engines/catalog/catalog.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'. Gem::Specification.new do |s| ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/catalog/catalog.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. s.metadata['rubygems_mfa_required'] = 'true' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/dfc_provider/dfc_provider.gemspec:9:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'. Gem::Specification.new do |spec| ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/dfc_provider/dfc_provider.gemspec:21:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. spec.metadata['rubygems_mfa_required'] = 'true' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/order_management/order_management.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'. Gem::Specification.new do |s| ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/order_management/order_management.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. s.metadata['rubygems_mfa_required'] = 'true' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/web/web.gemspec:7:1: W: [Corrected] Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'. Gem::Specification.new do |s| ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/web/web.gemspec:14:1: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. s.metadata['rubygems_mfa_required'] = 'true' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 1404 files inspected, 8 offenses detected, 8 offenses corrected	2023-04-19 15:35:30 +10:00
Maikel Linke	bde46fa1e9	Safely autocorrect Gemspec/DeprecatedAttributeAssignment ... Inspecting 1404 files .............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W.....................W....................................W...........................W....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... Offenses: engines/catalog/catalog.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec. s.test_files = Dir["test/**/*"] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/dfc_provider/dfc_provider.gemspec:17:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec. spec.test_files = Dir['spec/**/*'] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/order_management/order_management.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec. s.test_files = Dir["spec/**/*"] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/web/web.gemspec:14:3: W: [Corrected] Gemspec/DeprecatedAttributeAssignment: Do not set test_files in gemspec. s.test_files = Dir["test/**/*"] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 1404 files inspected, 4 offenses detected, 4 offenses corrected	2023-04-19 15:35:29 +10:00
Maikel Linke	e6b4f462ef	Revert "Add rubocop config to allow specs to be 300 lines long" ... This reverts commit 0b51d8b297. I think that this config was complicated in the setup and potentially confusing to have different rules in different places. It's better to fix those spec files by either making them smaller or removing the `module` block in the spec. We can reference the modules explicitely where needed.	2022-02-25 12:05:04 +11:00
Luis Ramos	23627c5453	Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied ... 9290 issues fixed	2021-06-17 22:19:26 +01:00
Luis Ramos	c785d0d1d7	Make engine's routes append to main app instead of prepend	2020-11-04 12:15:45 +00:00
Pau Pérez Fabregat	642787b95a	Merge branch 'master' into reset-on-demand-on-absent-products	2020-10-28 17:28:53 +01:00
Luis Ramos	c5186c2412	Fix rubocop_specs file path	2020-10-26 17:27:38 +00:00
Luis Ramos	0b51d8b297	Add rubocop config to allow specs to be 300 lines long	2020-10-26 17:03:50 +00:00
Cillian O'Ruanaidh	2cc751cb30	When resetting stock to 0 on absent products in product import also reset the on demand setting ... Before when you imported products and clicked the 'Set stock to zero for all existing products not present in the file' option it would set the on hand stock to 0 but if the variant was also set to be on demand the product would still be available for sale. This change makes sure the on demand setting is turned off too. Fixes #6064.	2020-10-16 11:38:49 +01:00
Luis Ramos	8a9dae0ee2	Run rubocop autocorrect ... This is the result of bundle exec rubocop --auto-correct	2020-06-22 12:23:10 +01:00
Luis Ramos	58465c4645	Adapt routes placeholder in the new catalog engine to make it similar to the other engines	2020-03-20 11:07:23 +00:00
Luis Ramos	00e57c8a55	Add module definition in the recently moved service and adapt all it's usages to refer to the new namespace	2020-02-13 20:17:09 +00:00
Luis Ramos	2e74e64e22	Move Product Reset Strategy to the catalog domain	2020-02-13 20:17:09 +00:00
Luis Ramos	fc5d623465	Add new domain structure Catalog	2020-02-13 20:17:06 +00:00