Matt-Yorkley
e5818955ff
Invalidate all incomplete payments when creating a new one, not just those in "checkout" state.
...
Looking at prod data; when a checkout submission fails due to something like a card being out of date, the payment's state seems to be "pending" and not "checkout", which means this mechanism fro invalidating old payments is potentially not working where it should.
2022-02-11 17:25:27 +00:00
Jean-Baptiste Bellet
43cd604405
Update to the right link the "Back to Payment method" button
...
+ create a spec as well
2022-02-11 15:01:53 +01:00
Jean-Baptiste Bellet
f60068c0ce
Use the proxy OpenFoodNetwork::FeatureToggle
...
that actually call Flipper.enabled?
2022-02-11 11:19:00 +01:00
Jean-Baptiste Bellet
e50247db5a
Directly used the user in the request
...
not the memoized one @spree_current_user
2022-02-11 11:19:00 +01:00
Jean-Baptiste Bellet
d858d6f941
Improve design by aligning cell on right but with padding
2022-02-11 11:09:54 +01:00
Filipe
6e2c4a385a
Merge pull request #8810 from Matt-Yorkley/split-checkout-tax
...
Reduce expensive tax recalculation calls
2022-02-10 17:42:39 +00:00
Filipe
d8936b412e
Merge pull request #8819 from apricot12/8694-Improve_subsvriptions_index_perfomance
...
8694 improve subscriptions index perfomance by eager loading tags, suppliers and exchanges.
2022-02-10 17:37:00 +00:00
Filipe
820417e6cc
Merge pull request #8828 from apricot12/8794-Keep_schedule_when_cloning_OC
...
Carry over linked schedule to cloned Order Cycle
2022-02-10 17:09:56 +00:00
Jean-Baptiste Bellet
50f547af98
Add an attribute that conditions the sending of the cancellation email
...
true by default to not change the default behavior.
Can be set to false when sending params send_cancellation_email
2022-02-10 14:39:00 +01:00
Jean-Baptiste Bellet
8624fa2a85
On last item deletion, prevent user on order canceling and cancellation email
...
... with a modal.
User can cancel the modal or confirm the last item deletion & order cancelation with or without sending a cancellation email to the consumer.
2022-02-10 14:39:00 +01:00
Jean-Baptiste Bellet
17906f378a
Create a method that actually adjust Items
...
Separate it from the adjustItems method that previously test about the item quantity
2022-02-10 14:34:39 +01:00
Jean-Baptiste Bellet
92cd918e5a
Add LoginModal as controller + connect action to open login modal
2022-02-10 09:52:13 +01:00
Filipe
30c1d89525
Merge pull request #8822 from Matt-Yorkley/split-checkout-payment-total
...
[Split Checkout] Move setting of payment total during checkout into OrderUpdater
2022-02-09 16:21:47 +00:00
Jean-Baptiste Bellet
a951fd2c06
Create a new method pdf_stylesheet_pack_tag that actually include CSS file
...
If running in developpement (ie. `Webpacker.dev_server.running?`), use webpacker to actually render/serve the CSS files.
Source: https://stackoverflow.com/a/60541688
2022-02-09 11:21:50 +01:00
Matt-Yorkley
8dc743f2d4
Extract update_payment_total method
2022-02-08 12:27:42 +00:00
Matt-Yorkley
1c180299a5
Pass indexed payment method tags to PaymentMethod Serializer
2022-02-08 11:42:24 +00:00
Matt-Yorkley
37b5e1b014
Allow Payment Method Serializers to receive options
2022-02-08 11:42:24 +00:00
Nihal M. Kelanthodika
3152fef2ef
Eager load distributors and cached_incoming_exchanges
2022-02-08 11:42:24 +00:00
Nihal M. Kelanthodika
f0d6cd1f59
Query payment_method_tags by id
2022-02-08 11:42:24 +00:00
Nihal M. Kelanthodika
ee77210e81
Eager load taggings in SubscriptionsController#Index
2022-02-08 11:42:24 +00:00
Jean-Baptiste Bellet
4a3e0ea9b9
Use the right scope to retrieve products based on properties
2022-02-07 08:57:18 +01:00
Jean-Baptiste Bellet
dfe8ed26d9
Update tests and use ransack to search with the new scope: with_properties
2022-02-07 08:57:18 +01:00
Maikel Linke
572a65b324
Create a scope to retrieve product based on its properties
...
both inherited and own product properties
Update the product spec to test the scope that concern properties
2022-02-07 08:57:18 +01:00
Cillian O'Ruanaidh
b43a68d717
Merge branch 'master' into remove-inline-advanced-settings-toggle-js
2022-02-04 12:24:17 +00:00
Cillian O'Ruanaidh
05756616dd
Add a remote-toggle controller that can toggle elements outside of its scope
...
This is instead of adding the :data-controller attribute to the div#wrapper because that will wrap pretty much all content on the admin pages.
Co-authored-by: Matt-Yorkley <9029026+Matt-Yorkley@users.noreply.github.com >
2022-02-04 12:23:24 +00:00
Cillian O'Ruanaidh
d03b52a163
Revert "Replace inline JS for toggling order cycle advanced settings with StimulusJs controller"
...
This reverts commit 67ae2e72f3 .
2022-02-04 11:47:38 +00:00
Filipe
e403fc171d
Merge pull request #8808 from Matt-Yorkley/login-modal
...
Remove all Angular code from Login/Signup process
2022-02-03 19:36:44 +00:00
Filipe
c4751d7056
Merge pull request #8813 from Matt-Yorkley/split-checkout-address-state
...
Split checkout: fix loading of saved addresses
2022-02-03 19:06:35 +00:00
Filipe
787b643832
Merge pull request #8818 from jibees/8793-specify-a-min-width-for-radio-input
...
Split checkout: specify a min width for radio input that improve the rendering on iOS
2022-02-02 18:31:27 +00:00
Nihal M. Kelanthodika
6293e927bc
Keep linked schedule when cloning OC
2022-02-02 19:13:48 +05:30
Matt-Yorkley
7235d1813d
Update totals and payment explicitly in current (non-split) checkout
2022-02-01 11:39:07 +00:00
Matt-Yorkley
35392cb117
Remove Order#set_payment_amount!
2022-02-01 11:39:07 +00:00
Filipe
ca0166a420
Merge pull request #8807 from Matt-Yorkley/closed-oc-payment-auth
...
Fix Stripe payment authorizing for closed order cycles
2022-02-01 11:16:31 +00:00
Filipe
998f7afdc4
Merge pull request #8523 from seballot/progress-for-ajax-request
...
Improve loading spinner display
2022-02-01 10:03:04 +00:00
Filipe
012527522c
Merge pull request #8640 from jibees/8630-make-buttons-sticky
...
Make split checkout buttons sticky on step 3
2022-02-01 09:41:33 +00:00
Filipe
8d18279f53
Merge pull request #8784 from apricot12/7398-Weight_field-on-non-weight-variants
...
Convert variant.weight into decimal if integer or 0.0 if nil
2022-01-31 18:55:31 +00:00
Matt-Yorkley
5eb88e020c
Extract/clarify methods in tabs_controller
2022-01-31 16:35:41 +00:00
Filipe
4e4d9bb5a5
Merge pull request #8804 from Matt-Yorkley/split-checkout-fees
...
[Split Checkout] Ensure fees are applied during checkout update
2022-01-31 16:26:22 +00:00
Matt-Yorkley
5b434ca7c4
Replace conditional with a guard clause
2022-01-31 15:55:35 +00:00
Matt-Yorkley
11ed1574ca
Call #check_order_cycle_expiry in PaypalController and StripeController, but avoid it on #authorize action
...
The authorize action is used for authorizing off-session payments where the order is *already complete* and the order cycle may have closed (backoffice and subscriptions). They are essentially asynchronous and not coupled to the current open/closed state of the order cycle.
2022-01-31 15:55:35 +00:00
Matt-Yorkley
5e6dd1e6e1
Move #check_order_cycle_expiry method to OrderStockCheck and don't call it from BaseController :before_action callback
2022-01-31 15:55:35 +00:00
Jean-Baptiste Bellet
d97381548a
Specify a min width for radio
2022-01-31 15:50:37 +01:00
Jean-Baptiste Bellet
da6be441f8
Make sticky buttons fullwidth on mobile
2022-01-31 11:47:35 +01:00
Jean-Baptiste Bellet
ae0a71b29d
This row adds an extra space on the right of the page
...
which introduce an horizontal scroll: visual regression
2022-01-31 11:47:21 +01:00
Filipe
6dac65ace5
Merge pull request #8803 from Matt-Yorkley/buttons-regression
...
Fix visual regression on filter buttons
2022-01-31 10:32:57 +00:00
Jean-Baptiste Bellet
fdeadd0940
Reduce margin on step3 since the container could be a little too high
2022-01-31 11:31:32 +01:00
Jean-Baptiste Bellet
d8391aa1d3
Create a div with a special class (checkout-step3)
...
... and attach the controller to it
Add the T&Cs inside the sicked container with submit buttons
2022-01-31 11:31:32 +01:00
Jean-Baptiste Bellet
293bc10dde
Create a sticky controller that handle the sticky position of an element
...
.. at the bottom
And then add the sticked class to this element if the element is actually sticked
2022-01-31 11:31:32 +01:00
Jean-Baptiste Bellet
3abef1b703
Specify css for this sticky container
...
with a nice box-shadow.
Handle special case for mobile view (ie. max width 700px)
2022-01-31 11:31:32 +01:00
Matt-Yorkley
5f02ab79d4
Adjust animation handling for show/hide
2022-01-31 10:02:09 +00:00