Neal Chambers
1e4034534c
Fix Layout/LineLength
2023-06-23 09:08:04 +09:00
Matt-Yorkley
bb73d70e57
Improve nil-safety in variant naming methods
2023-06-07 12:17:50 +01:00
Matt-Yorkley
e99c328643
Update app/services/variant_units/variant_and_line_item_naming.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-06-01 10:12:19 +01:00
Matt-Yorkley
7f5d1be792
Guard against unsaved variant's product in OptionValueNamer for product import
2023-06-01 10:12:19 +01:00
Matt-Yorkley
a20277c3a7
Completely remove option_values and option_types from the codebase
2023-06-01 10:12:19 +01:00
Matt-Yorkley
35b41fc7fe
Persist unit_value on variant and "option value text" on variant and line_item and improve related AR callbacks
2023-06-01 10:12:19 +01:00
Matt-Yorkley
896e4c45f2
Clarify confusing class
2023-06-01 10:11:20 +01:00
Matt-Yorkley
e5eb622ac7
Cut dead code
2023-06-01 10:11:20 +01:00
Gaetan Craig-Riou
6e76bcac4a
Refactor option_value_value_unit_scaled to use to_d instead of calling BigDecimal
...
As we are now using truncate(2) we don't need to specify the number of significant digits
2023-01-11 15:35:30 +11:00
Gaetan Craig-Riou
91af282ccc
Truncate scaled value unit to maximum of two decimals
...
ie truncate 12.50001234 to 12.5
When using imperial, the scalling calculation rounding results in value unit
having extra decimal when converted back to imperial
+ related spec
2023-01-11 11:04:32 +11:00
Jean-Baptiste Bellet
4452ad2c51
Use BigDecimal to avoir multiplication/division floating errors
...
Like 28.35 * 12 / 12 = 28.350000000000005
+ in js, use parseFloat() to format `12.00` as `12`
2022-09-07 09:17:46 +02:00
Matt-Yorkley
290e292dea
Revert "Fixed inconsistency with display of unit name for products sold by item"
2021-12-07 13:24:12 +00:00
Nihal M. Kelanthodika
8a42043701
Fixed inconsistency with display of unit name for products sold by item
2021-11-19 13:39:42 +05:30
Luis Ramos
e52937c113
Use rubocop auto correct to add frozen string literal to all files
...
This is an unsafe auto corection, we will need to trust our build here
2021-06-17 23:07:26 +01:00
Luis Ramos
23627c5453
Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied
...
9290 issues fixed
2021-06-17 22:19:26 +01:00
Andy Brett
7319ef7345
use better method and class names
2021-03-25 08:51:15 -07:00
Andy Brett
330839012e
add translation
2021-03-25 08:51:15 -07:00
Andy Brett
0afc2d281a
shorten UnitPrices method names
2021-03-25 08:51:15 -07:00
Andy Brett
39fc0707c3
provide unit price values in front end shop
2021-03-25 08:51:15 -07:00
Luis Ramos
e413920335
Move both OptionValueNamer and VariantAndLineItemNaming to app/services/variant_units
2020-09-03 09:11:00 -07:00
