Luis Ramos
bfd4adbcee
Adapt code to work with frozen strings
2020-12-03 06:38:24 -08:00
Luis Ramos
611de912a8
Switch frozen_string_literal to false so that price code keeps working
2020-12-03 06:38:24 -08:00
Matt-Yorkley
b04a76e8bf
Update payments_report totals
2020-11-27 14:00:29 +00:00
Matt-Yorkley
1ceb6ac916
Update orders_and_fulfilment report totals
2020-11-27 14:00:29 +00:00
Matt-Yorkley
9c41c296e4
Remove default comments from ApplicationResponder
2020-11-27 14:00:29 +00:00
Matt-Yorkley
d2998f1190
Remove spaces in payments report
2020-11-27 14:00:29 +00:00
Matt-Yorkley
60aaf8100a
Fix some Rubocop offences
2020-11-27 14:00:29 +00:00
Matt-Yorkley
64153c5072
Remove #handle_asyncronously and update to recommended asyncronous devise mail method
2020-11-27 14:00:29 +00:00
Matt-Yorkley
54ad90e071
Replace deprecated ActiveRecord::ConnectionAdapters::Column#value_to_boolean
...
This method has been removed in Rails 4.2
2020-11-27 14:00:29 +00:00
Matt-Yorkley
49081e171e
Fix PG::UndefinedTable errors
...
The logic of #includes has changed slightly in Rails 4.2 and now usually needs the #references method as well.
PG::UndefinedTable:
# ERROR: missing FROM-clause entry for table "enterprises"
# LINE 1: SELECT "spree_users".* FROM "spree_users" WHERE (enterprises...
# ^
# ./spec/models/spree/user_spec.rb:125:in `block (4 levels) in <top (required)>'
2020-11-27 14:00:29 +00:00
Matt-Yorkley
b36b0eddee
Fix Rubocop issues
2020-11-27 14:00:29 +00:00
Matt-Yorkley
e155b00ab9
Fix undefined constant Spree::Responder
2020-11-27 14:00:28 +00:00
Matt-Yorkley
16cc0afe8f
Replace removed method #retrieve_collector_from_mimes
...
https://apidock.com/rails/v4.1.8/ActionController/MimeResponds/retrieve_collector_from_mimes
2020-11-27 14:00:28 +00:00
Matt-Yorkley
91908a0e4c
Switch from state_machine to state_machines gem
...
The old version is completely unmaintained and does not work with Rails 4.2
2020-11-27 14:00:28 +00:00
Matt-Yorkley
fb333c37e7
Fix Api controller setup for responders gem
2020-11-27 14:00:28 +00:00
Matt-Yorkley
3090cfa909
Add setup for responders gem
2020-11-27 14:00:28 +00:00
Luis Ramos
1d32ecab98
Fix spec by adding necessary references statement
2020-11-27 13:59:46 +00:00
Luis Ramos
7e39d78733
Fix Long Method rubocop issue
2020-11-27 13:59:46 +00:00
Luis Ramos
0152b4da55
Fix rubocop issues
2020-11-27 13:59:46 +00:00
Luis Ramos
2a03e42f2a
Update deep_munge patch to rails 4.1 where the code is now in ActionDispatch::Request::Utils
2020-11-27 13:59:46 +00:00
Luis Ramos
edc1773676
Fix some calls to sum in reports code
2020-11-27 13:59:46 +00:00
Luis Ramos
9bbef16804
Converting all calls to ActiveRelation#sum to use a symbol with &
...
This is only applicable to database columns, if we are summing using a method in the model than the & is required!
2020-11-27 13:59:46 +00:00
Luis Ramos
61708e5deb
AbstractController::ViewPaths was moved to ActionView::ViewPaths in rails 4.1
2020-11-27 13:59:46 +00:00
Pau Pérez Fabregat
8b6a08457a
Merge pull request #6293 from luisramos0/subs_debug
...
Add task to print Subscriptions debug info
2020-11-27 10:17:57 +01:00
Andy Brett
b1b422b90e
fix/silence rubocop styles
2020-11-20 10:41:31 -08:00
Andy Brett
17202ff39c
move gateway_error require to lib/spree/core.rb
2020-11-10 14:55:56 -08:00
Luis Ramos
b281e7e9e5
Merge pull request #6312 from mkllnk/variant-override-loading
...
Avoid loading variant overrides for no reason
2020-11-06 03:59:33 +00:00
Luis Ramos
bd4da3b5ce
Merge pull request #6247 from cillian/deep-munge-issue
...
Patch Rails :deep_munge issue so empty array parameters don't get converted to nil
2020-11-05 13:25:39 +00:00
Maikel Linke
4b1f5ae060
Avoid loading variant overrides for no reason
2020-11-05 14:31:19 +11:00
Luis Ramos
ccab133d63
Make sample data use OFN's calculators
2020-11-04 12:15:45 +00:00
Luis Ramos
4b21667974
Move initializers from Spree engine to the OFN application
2020-11-04 12:15:45 +00:00
Luis Ramos
58a476751b
Remove code from the spree engine that is not needed in OFN
2020-11-04 12:15:45 +00:00
Luis Ramos
3320a3f0bc
Fix some more rubocop issues
2020-11-04 12:15:45 +00:00
Luis Ramos
4c6708267a
Run rubocop -a
2020-11-04 12:15:45 +00:00
Luis Ramos
2f0d61d54f
Bring Spree engine.rb from spree_core
2020-11-04 12:15:45 +00:00
Luis Ramos
f6195f1159
Remove duplicate_extra logic from ProductDuplicator
2020-11-04 12:15:23 +00:00
Luis Ramos
503c17f896
Move Spree::ProductDuplicator to Spree::Core namespace
2020-11-04 12:15:23 +00:00
Luis Ramos
ba16de6627
Move product duplicator to lib/spree/core, it's where spree_core is currently loading it from
2020-11-04 12:15:23 +00:00
Luis Ramos
cf7d8067df
Fix easy rubocop issues
2020-11-04 12:15:23 +00:00
Pau Pérez Fabregat
4911bb6613
Merge pull request #6274 from luisramos0/rubocop
...
Use rubocop auto correct to fix a number of issues
2020-11-02 22:13:36 +01:00
Luis Ramos
c07215552e
Add log entries to log
2020-11-02 20:59:57 +00:00
Luis Ramos
2b01c80c54
Add subs debug task that prints out basic info about a specific Order Cycle
2020-11-02 20:59:57 +00:00
Luis Ramos
eea73aa989
Merge pull request #5919 from luisramos0/injector_refactor_for_rails41
...
[Rails 4.1, works in master] Convert relations with to_a so that they work in rails 4.1
2020-10-31 09:33:27 +00:00
Luis Ramos
ca1373a366
Fix Style/RescueStandardError and Style/RegexpLiteral
2020-10-30 16:50:37 +00:00
Luis Ramos
85096a997f
Add a checkbox to checkout to tick for Terms and Conditions
...
Checkout button should be disabled if checkbox is not ticked
2020-10-30 15:08:26 +00:00
Cillian O'Ruanaidh
5a66c855bc
Add :frozen_string_literal magic comment and underscore prefix to unused block argument for Rubocop
2020-10-30 11:12:36 +00:00
Cillian O'Ruanaidh
ea3c456d3b
Patch Rails :deep_munge issue so empty array parameters don't get converted to nil
...
Before people were unable to remove coordinator fees from an order cycle because Rails was converting the empty :coordinator_fee_ids array paramter into nil. This issue was introduced to Rails in v4.0.0.beta1 and isn't fixed until v5.0.0.beta1
Another way to fix this could be to do something like 'params[:coordinator_fee_ids] ||= []' but it seems like this issue could problems in other parts of the app so a more general fix might be better.
Fixes #6224
2020-10-30 11:12:36 +00:00
Luis Ramos
586e8a9abe
Fix some more rubocop issues
2020-10-30 10:13:16 +00:00
Luis Ramos
399fe2c01b
Make code work for relations and arrays
2020-10-30 10:12:56 +00:00
Luis Ramos
3aeb87debc
Make it work with both relations and arrays
2020-10-30 10:12:56 +00:00