Matt-Yorkley
|
26ba76cff9
|
Fix soft-deletion in CartService and update spec
|
2020-05-05 13:57:50 +02:00 |
|
Matt-Yorkley
|
805f91e838
|
Remove unnecessary #all call
|
2020-05-05 09:56:08 +02:00 |
|
Matt-Yorkley
|
2bdda7de04
|
Change order of methods for easier reading
|
2020-04-29 17:22:46 +02:00 |
|
Matt-Yorkley
|
eb858159ce
|
Eager-load :default_price on variants
|
2020-04-28 01:04:22 +02:00 |
|
Matt-Yorkley
|
468cb3f57e
|
Remove obviously private methods from the public interface in CartService
These methods are not called from anywhere in the app, only in a couple of tests in cart_service_spec.
|
2020-04-27 19:27:07 +02:00 |
|
Matt-Yorkley
|
25525d4f75
|
Use guard clause in each block
|
2020-04-27 19:27:07 +02:00 |
|
Matt-Yorkley
|
a759d8c7c7
|
Avoid N+1s for variants and for line_items of variants
|
2020-04-27 19:27:07 +02:00 |
|
Matt-Yorkley
|
b3242041e5
|
Return earlier (before scoping process, if possible)
|
2020-04-27 19:27:07 +02:00 |
|
Matt-Yorkley
|
106bb7a27f
|
Rename some variables and add comments for clarity in cart_service
|
2020-04-27 19:27:07 +02:00 |
|
Matt-Yorkley
|
2334ab6d00
|
Delete some dead code in cart_service
This Bugsnag error was added a year ago and hasn't been seen
|
2020-04-27 19:27:07 +02:00 |
|
Matt-Yorkley
|
11af5dffdc
|
Memoize scoper in cart_service
Avoids fetching all of the hub's variant overrides from the db every time it's initialized.
|
2020-04-27 19:27:07 +02:00 |
|
luisramos0
|
59ec52babe
|
Refactor order_cycle_distributed_variants, better method names and simpler code
|
2019-04-11 22:15:24 +01:00 |
|
luisramos0
|
96ee527f0c
|
Rename distribution_change_validator to order_cycle_distributed_variants
|
2019-04-11 21:14:01 +01:00 |
|
luisramos0
|
c1d14686a6
|
Merge branch 'master' into 2-0-stable-Mar22
|
2019-03-22 10:55:17 +00:00 |
|
luisramos0
|
60ee17204b
|
Merge branch 'master' into 2-0-stable-Mar16
|
2019-03-16 16:17:38 +00:00 |
|
luisramos0
|
2de6c46834
|
Make order.order_cycle required in cart_service. There’s no more exception for that without product_distributions.
|
2019-03-13 12:24:40 +00:00 |
|
luisramos0
|
351555d4e2
|
Remove unused methods from add_to_cart helper and distribution change validator
|
2019-03-02 12:55:08 +00:00 |
|
luisramos0
|
0460e7fc6c
|
Merge branch 'master' into 2-0-stable-jan-17th
|
2019-01-17 22:51:25 +00:00 |
|
luisramos0
|
ea61e415e1
|
Add bugsnag notifications to detect potential dead code scenarios in variants_stock_levels and cart_service
|
2019-01-15 13:42:51 +00:00 |
|
luisramos0
|
df36e0b344
|
In cart population, replace usage of global allow_backorders with variant.on_demand adapter
|
2018-10-18 18:37:09 +01:00 |
|
luisramos0
|
910297572e
|
Removed unnecessary currency from CartService constructor, using order.currency instead
|
2018-08-23 12:40:18 +01:00 |
|
luisramos0
|
c7b202f932
|
Fixed CodeClimate warnings on services/cart_services.rb
|
2018-08-23 12:39:58 +01:00 |
|
luisramos0
|
05bfc098ff
|
/controllers/spree/order_populator_decorator (with a class_eval) is now /services/CartService with no dependency to Spree::OrderPopulator.
|
2018-08-23 12:39:55 +01:00 |
|