filipefurtad0
2004abc8be
Sets pending test - issue #11350
...
changing the payment_total should not generate a new invoice; rather, it should update the current invoice
2023-10-18 11:20:48 +01:00
filipefurtad0
530cdacc77
Restructures tests as shared examples
...
Merges test files
2023-10-18 11:20:06 +01:00
filipefurtad0
8a1a14112b
Moves tests to shared examples file
2023-10-18 11:20:05 +01:00
filipefurtad0
8b249ee050
Adds unit tests for different attributes
2023-10-18 11:19:03 +01:00
Maikel
0477bef53a
Merge pull request #11657 from mkllnk/report-job-retries
...
Notify user about errors raised in reports
2023-10-18 15:38:34 +11:00
Rachel Arnould
aecb55beb3
Merge pull request #11660 from dacook/products_v3_path
...
Hide old products screen when admin_style_v3 enabled
2023-10-17 10:45:01 +02:00
Konrad
d7b234c062
Merge pull request #11593 from rioug/11363-vouchers-fix-tax-included-in-price-amount
...
[Vouchers] Fix tax included in price amount
2023-10-13 18:22:11 +02:00
David Cook
a13c95433e
Merge pull request #11548 from macanudo527/add_foreign_key_script
...
Add Spec that Generates Migrations for Missing Foreign Keys
2023-10-13 11:20:47 +11:00
David Cook
655c16cca0
New bulk products screen shares path with old
...
The feature toggle will determine which bulk products screen shows. An additional products_old path is also temporarily added for easy reference.
Later, when the old screen is full removed, we'll probably rename the _v3 classes to tidy up.
2023-10-13 10:39:45 +11:00
Maikel
604cc10c3f
Merge pull request #11654 from openfoodfoundation/dependabot/bundler/rubocop-1.57.0
...
chore(deps-dev): bump rubocop from 1.56.4 to 1.57.0
2023-10-13 08:29:29 +11:00
Konrad
cc8898e074
Merge pull request #11219 from abdellani/fix-tax-rates-rendering-when-invoice-enabled
...
fix Viewing an invoice with the instance's invoice setting set to alternative model leads to an error 500
2023-10-12 17:47:27 +02:00
Konrad
f87186373c
Merge pull request #11647 from dacook/image-validation
...
Only validate image when changed
2023-10-12 15:42:22 +02:00
Maikel Linke
f61a2fa2bf
Rescue errors in report generation
...
So we can report them to Bugsnag and the job isn't marked as failed and
therefore won't repeat.
2023-10-12 16:01:52 +11:00
Maikel Linke
477ca39e58
Update spec
2023-10-12 15:40:06 +11:00
Maikel Linke
45dd5cc40a
Style/SingleLineDoEndBlock: Prefer multiline do...end block
2023-10-12 10:10:42 +11:00
Mohamed ABDELLANI
1c2aa1c370
fix linter issue
2023-10-11 11:00:37 +01:00
Mohamed ABDELLANI
7cb200e21e
fix linting errors
2023-10-11 09:27:16 +01:00
Mohamed ABDELLANI
fc519da83b
update the invoice system tests to run with invoice feature (enabled/disabled)
2023-10-11 09:27:16 +01:00
David Cook
b42cf9735f
Only validate an image if it has been changed
...
Best viewed with whitespace ignored.
2023-10-11 10:12:52 +11:00
David Cook
31b5be73f9
Add spec
2023-10-11 10:12:52 +11:00
Maikel Linke
228f69f13e
Test customer report filtering without sorting
...
The report doesn't seem to sort. So the specs don't expect that either
now. These specs were flaky before, depending on the random order in the
database query result.
2023-10-09 12:05:24 +11:00
Maikel
90c25d604b
Merge pull request #11441 from macanudo527/fix_rails_HasManyOrHasOneDependent
...
Fix Rails/HasManyOrHasOneDependent
2023-10-09 11:44:23 +11:00
David Cook
1c0ebfe61e
Add comment
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
95e7900585
test print invoice button under ACTIONS
2023-10-08 21:47:17 +02:00
Mohamed ABDELLANI
a9719a798f
fix order mailer tests
2023-10-08 21:47:17 +02:00
Konrad
944925eb06
Merge pull request #11603 from murjax/prevent-customer-edit-shipped-9235
...
Prevent customers from editing shipped orders
2023-10-08 21:42:18 +02:00
Konrad
ef855e8887
Merge pull request #11619 from ccozkan/issue-11611
...
Add ability to customers report to filter with open ended boundaries
2023-10-08 16:28:52 +02:00
David Cook
9a9be8dacd
Validate length of variant fields
2023-10-06 14:15:07 +02:00
David Cook
3ec6386e1c
Validate length of some product fields
...
We know if the values are too long, so let's provide a useful message rather than generating an unhandled database error.
This code seems rather repetetive, it would be good to use a shared module. I wonder if there's a gem for that.
Note that the existing /products/*/edit screen doesn't even handle validation errors yet, but that's something for another day..
2023-10-06 14:15:07 +02:00
David Cook
3b19a19776
Show inline errors for product fields
...
The form helper () doesn't work for this case, but it seems we can call it directly like this instead. I'd like to fix the helper, but got stuck this time.
2023-10-06 14:15:07 +02:00
Neal Chambers
085d0f27f7
Move Timestamp Generation into its own Method
2023-10-06 11:19:31 +09:00
Neal Chambers
aaa42ce410
Add Filtering for Optional Relationships
2023-10-06 11:06:54 +09:00
Neal Chambers
3c51b48225
Fix Formatting and Bugs
2023-10-06 11:06:54 +09:00
Neal Chambers
6d22ec5605
Improve Migration Timestamping
2023-10-06 11:06:54 +09:00
Neal Chambers
2b4bf185d6
Replace Duplicate Model Detection with Column Specific Foreign Key Check
2023-10-06 11:06:54 +09:00
Neal Chambers
f1c61fa3aa
Add Option to Write Migrations to Disk
2023-10-06 11:06:54 +09:00
Neal Chambers
2d6784b88d
Allow Full Modulized Class Name to be Used for TODOs
2023-10-06 11:06:54 +09:00
Neal Chambers
d4c363ac39
Reduce Cyclomatic Complexity
2023-10-06 11:06:54 +09:00
Neal Chambers
9df42f596c
Add SQL to Migration Files
2023-10-06 11:06:54 +09:00
Neal Chambers
7ec1f69e2a
Create Foreign Key TODO
2023-10-06 11:06:54 +09:00
Neal Chambers
816ffe6e32
Convert rake task to spec
2023-10-06 11:06:54 +09:00
David Cook
cd34e160bf
Fix deleting of return_authorizations
...
return_authorizations have a stock_location_id, not the other way round. So there's no dependent field to nullify.
2023-10-06 10:58:49 +09:00
Çağrı Özkan
f93fcd347b
Rubocop fix
2023-10-04 02:00:21 +03:00
Çağrı Özkan
a5a13761a8
Filter with open ended boundaries upon missing params
2023-10-04 01:05:41 +03:00
Ryan Murphy
4db6570039
9235: Prevent customers from editing shipped orders
2023-10-03 08:36:57 -04:00
filipefurtad0
14caf3b25c
Moves helper into support folder
...
Wraps SubscripionHelper module around definitions
2023-10-03 09:49:26 +01:00
filipefurtad0
bc73d09438
Declares enable_subscriptions separately
2023-10-03 09:49:26 +01:00
filipefurtad0
96432ebec2
Splits files into new folder
...
Creates helper file for existing methods
2023-10-03 09:49:26 +01:00
filipefurtad0
8bc2feda23
Asserts for subscription instructions and tab
2023-10-03 09:49:26 +01:00
filipefurtad0
b554308f10
Sets correct context
2023-10-03 09:49:26 +01:00
