Maikel Linke
a37b0eb698
Replace mocking on tested order object
...
It's more realistic this way.
2024-07-11 15:42:23 +10:00
Maikel Linke
2e36c699f6
Test resulting stock instead of method calls
...
The next test case wasn't asserting anything as well. The referenced
method `decrease_stock_for_variant` doesn't actually exist.
2024-07-11 15:42:23 +10:00
Maikel Linke
cb4e7d6fe3
Fix spec to assert updating shipments
...
The spec was asserting on all shipments of the order but there were one.
In consequence, the spec didn't assert anything. Now I set up a shipment
that is asserted on. I'm stil not sure how useful this spec is though.
2024-07-11 15:42:23 +10:00
Maikel Linke
94d560d341
Replace expecting method call with outcome
...
This is more realistic and robust. Don't mock the class under test (even
though `touch` is actually provided by Active Record).
2024-07-11 15:42:22 +10:00
Maikel Linke
eea227bc22
Style order spec block a tiny bit
2024-07-11 15:42:22 +10:00
cyrillefr
ce8a2b3251
Fixes Rails/SkipsModelValidations offenses
...
- increments! & decrement! skip validations
- replaced increment! method calls
- one call was for a redefined increment! method
- the other for a regular(ActiveRecord::Persistence)
- removes increments/decrements definition now useless
2024-07-05 16:35:40 +02:00
Gaetan Craig-Riou
448308710a
Per review, distributor are now updated via variant
...
When a product is deleted, it will delete associated variant and
in turn will touch the affected distributors
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
f73745a803
David's first review changes
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
3788b33eb0
First round of code review change
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
c328ee8087
Remove stockable_by from Product and Variant
...
It's not used anymore
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
117f6d3300
First round of code review change
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
260211cf15
Fix Ruboxop issue
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
891f79666d
Spree::Product remove in_supplier_or_distributor scope
...
It is not used anywhere
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
b6faa43879
Fix touching distributor callback spec
...
The original spec check if the supplier and distributor where
updated after deleting product. In reality, the supplier and the
distributor are the same, so no need to test with the supplier
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
3dc7c2bf56
Fix spree product touch supplier
...
Take into account import product scenario, in this case the variant
doesn't have an assigned supplier yet.
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
dd8f0aafab
Fix ProductImport::EntryProcessor#count_existing_items
...
Plus spec
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
564ea0bd49
Fix enterprise touching when associated record updated
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
5884edaa1b
Fix product import system spec
2024-07-03 11:15:10 +10:00
Gaetan Craig-Riou
25371ee9d0
Fix admin pages
...
- move supplier to variant row on Bulk Edit product page
- add supplier dropdow on add/update variant page
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
0c9223809b
Fix with_properties scope to accept any number of arguments
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
ef298e3b62
Fix taxon
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
95ed806370
Fix shipment specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
612ab097b7
Fix order specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
054d967323
Fix line items
...
* fix supplier related code
* Fix associations + plus spec
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
859f7efd02
Fix Spree:Ability
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
d5cc60fd3a
Fix ProductImporter and related Class
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
94faf4cf69
Fix invenrory reset strategy spec
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
b86d8e1603
Fix product import entry validation
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
a87f10b2a6
Fix order cycle spec
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
50bd274715
Fix Enterprise
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
d073a181e9
Fix EnterpriseRelationship
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
02b9dfb517
Add after update primary taxon call back
...
It updates supplier on primary taxon update. It fixes falling
enterprise caching specs.
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
22f4ae115a
Add missing associations and validations specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
8abea0afcf
Add missing associations and validations specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
6290e7ad1c
Test the suppliers are touched on destroy
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
4113880401
Move supplier to variant part 2
...
Variant model and specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
d1dd563720
Move supplier to variant part 1
2024-07-03 10:17:48 +10:00
David Cook
d799230440
Update controller to catch more specific error
...
We now know which errors to expect. We still let other unknown errors raise higher up, where they will be logged with BugSnag, and treated as internal_server_error.
2024-06-27 12:51:28 +10:00
Ahmed Ejaz
4315a05eb8
11987: fix lint issue
2024-06-26 16:32:32 +05:00
Ahmed Ejaz
5a259f1b91
Merge branch 'master' into task/11987-remove-SR-from-clone
2024-06-26 16:18:42 +05:00
Ahmed Ejaz
3f6e5e7d09
11987: duplicate product without raising error
2024-06-26 16:00:59 +05:00
Ana Nunes da Silva
d2c6db0d04
Sanitize CustomTab#content
2024-06-20 11:56:09 +02:00
Maikel
8837f1caa2
Revert "Allow negative stock levels for on-demand products"
2024-06-19 15:18:57 +10:00
Maikel
2f173cb5c2
Merge pull request #12536 from mkllnk/stock-levels
...
Allow negative stock levels for on-demand products
2024-06-13 10:26:01 +10:00
zanetagebka
a2a670c848
Fix cops StringConcatenation
2024-06-11 15:17:32 +10:00
Filipe
5872515a35
Merge pull request #12515 from isidzukuri/12503_skip_saving_of_unchanged_products
...
Do not commit to db unchanged products in bulk save
2024-06-05 18:01:59 +02:00
Ana Nunes da Silva
a7dc243db9
Sanitize product description using rails default sanitizer
2024-06-03 11:45:49 +01:00
Maikel Linke
ecbba894f7
Update stock levels of on-demand items
...
We weren't bothering with stock when items were on demand anyway. But we
want to track stock now so that we can backorder more when local stock
levels become negative.
2024-05-31 16:38:24 +10:00
Filipe
a01dcaadcf
Merge pull request #12506 from anansilva/12448-sanitise-html-enterprise-group
...
Sanitise HTML in long description of enterprise group [read-only]
2024-05-30 14:07:20 +02:00
David Cook
35c2297d55
Detect changes in price
...
Price is actually an association with lots of custom methods to make it look like a field, and so changes were ignored.
Now this issue is fixed, perhaps it should be moved to a concern..
Note, there are other delegated fields: product name and description may be assigned from the variant. But there's no hooks to save the prroduct, so I didn't include it when checking for changes.
2024-05-28 12:00:04 +10:00
