6 Commits

Author	SHA1	Message	Date
Neal Chambers	edbf4c15a9	Safely autocorrect Style/RedundantReturn ... Inspecting 1513 files .........................................................................................................................................................................................................................................................................................................C......................................................C............................................................................................................................................................................................................................................................................................................................................................................................................................................C.........................................................C.......C......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... Offenses: app/models/product_import/entry_validator.rb:200:7: C: [Corrected] Style/RedundantReturn: Redundant return detected. return true unless Float(value, exception: false).nil? ^^^^^^ app/models/spree/stock/availability_validator.rb:30:9: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return line_item.target_shipment if line_item.target_shipment ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/stock/availability_validator.rb:31:9: C: [Corrected] Style/RedundantReturn: Redundant return detected. return line_item.order.shipments.first if line_item.order&.shipments&.any? ^^^^^^ lib/reporting/reports/enterprise_fee_summary/summarizer.rb:41:11: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return DataRepresentations::IncomingExchangeLineItemFee if for_incoming_exchange? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/reporting/reports/enterprise_fee_summary/summarizer.rb:42:11: C: [Corrected] Style/RedundantReturn: Redundant return detected. return DataRepresentations::OutgoingExchangeLineItemFee if for_outgoing_exchange? ^^^^^^ lib/stripe/authorize_response_patcher.rb:31:7: C: [Corrected] Style/RedundantReturn: Redundant return detected. return url if url.match(%r{https?://\S+}) && url.include?("stripe.com") ^^^^^^ lib/tasks/data.rake:99:7: C: [Corrected] Style/RedundantReturn: Redundant return detected. return true if Integer(value) ^^^^^^ 1513 files inspected, 7 offenses detected, 7 offenses corrected	2023-11-17 09:00:50 +09:00
Neal Chambers	871a8e6f2c	Fix Rails/Blank	2023-08-17 16:42:46 +09:00
Luis Ramos	23627c5453	Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied ... 9290 issues fixed	2021-06-17 22:19:26 +01:00
Andy Brett	6996001580	add defensive checking for stripe response	2021-03-13 10:58:30 +00:00
Andy Brett	ab5ffead1d	require that the redirect url be to stripe.com and over https	2021-01-21 09:18:29 -08:00
luisramos0	6877485c90	Extract AuthorizeResponsePatcher from stripeSCA gateway	2020-03-02 17:30:12 +00:00