Konrad
2477a63f36
Merge pull request #12103 from basilawwad/selecting-OC-should-redirect-to-shop
...
Modify default hash tabs controller to redirect users to shopping panel when an OC is selected.
2024-02-19 21:51:19 +01:00
Gaetan Craig-Riou
cb83ad688e
Remove old vcr stripe cassettes
2024-02-19 15:44:20 +11:00
Gaetan Craig-Riou
02019f7cae
Re recorde vcr cassette after rebase
2024-02-19 11:01:20 +11:00
Gaetan Craig-Riou
848767d50f
Per review, clean up test set up
2024-02-19 10:58:31 +11:00
Gaetan Craig-Riou
89236f4c2f
Per review, create a Stripe account
...
It's better to avoid hard coded stripe entities
2024-02-19 10:58:31 +11:00
Gaetan Craig-Riou
ef1d2fdb4d
Clean up cassettes
...
* remove old cassettes left over from a rebase
* re recorded cassettes with the lastest Stripe version
2024-02-19 10:58:31 +11:00
Gaetan Craig-Riou
657f71c357
Further refactor payment specs
...
- remove any stub_request
- use intance_double of ActiveMerchant::Billing::Response
2024-02-19 10:58:31 +11:00
Gaetan Craig-Riou
8832f2fef6
Refactor #credit spec
...
Model spec shouldn't know about the undelying call to stripe. Replaced
request stubs by payment method stubs.
Consolidate #credit spec in one `describe` block
2024-02-19 10:58:31 +11:00
Gaetan Craig-Riou
0af9ccd17a
Add test for #credit
...
it uses ActiveMerchant::Billing::StripePaymentIntentsGateway#refund,
we covering the last scenario that previously used the decorator.
2024-02-19 10:58:31 +11:00
Gaetan Craig-Riou
549610bc35
Finally remove StripePaymentIntentsGateway decorator
...
Add spec for Spree::Gateway::StripeSCA#void
It also partially fix 11670, refund of Stripe payment should now work
for complete order
2024-02-19 10:58:31 +11:00
Gaetan Craig-Riou
8a0c32eec0
Improve Stripe::ProfileStorer specs
...
* Use `with_stripe_setup` helper
* add the request failing scenario
2024-02-19 10:53:53 +11:00
Gaetan Craig-Riou
62fbaa8a6e
Update Stripe payment intents decorator
...
- copied the relevant code from the new Active Merchant version
- Add spec to cover the scenario of saving a card when paying by card
- Fix Stripe stub.
I used stripe stubs for the new scenario because storing a card on
stripe depends on some client side interaction with Stripe. We can't
capture that with VCR.
2024-02-19 10:53:53 +11:00
Maikel
4bb1afcc8f
Merge pull request #12166 from openfoodfoundation/dependabot/bundler/stripe-10.9.0
...
chore(deps): bump stripe from 10.8.0 to 10.9.0
2024-02-19 10:22:53 +11:00
Maikel Linke
7eccce138b
Update Stripe API recordings for new version
2024-02-19 10:02:05 +11:00
Rachel Arnould
39b83eae19
Merge pull request #12133 from dacook/buu/new-variant-11066
...
[BUU] Create a new variant inline
2024-02-16 14:32:17 +01:00
Rachel Arnould
a3af15dbae
Merge pull request #12162 from isidzukuri/12003_improve_error_messageg_when_no_products_are_changed
...
Improve error message by not displaying the first part of the second …
2024-02-16 11:24:52 +01:00
Filipe
49ebcc23b3
Merge pull request #12159 from mkllnk/capybara-wait-time
...
Reduce Capybara wait time during development
2024-02-16 09:37:28 +00:00
basilawwad
08111f9a2c
added shop target and activateshoppanel function
...
Remove Pending Message
Update shopping_spec.rb
Update shopping_spec.rb
2024-02-16 09:27:21 +03:00
David Cook
7164cbd0bd
Don't validate numericality if blank
...
This avoids unnecessary second message when left blank:
> can't be blank
> is not a number
Ok this is a little confusing. Why is there a separate presence check above, and why is it only for measurable units, when we still require a number for _all_ units? Because, for 'items', we allow a blank value then auto-set it to 1.
I don't know if it's really necessary, but that's how it currently works...
2024-02-16 08:51:53 +11:00
David Cook
915a5ce66b
Listen for changes on added fields
...
Finally, we can add new variants!
Requires updated stimulus-rails-nested-form
2024-02-16 08:51:49 +11:00
isidzukuri
ae9229ec7a
Merge branch 'master' into 12003_improve_error_messageg_when_no_products_are_changed
2024-02-15 09:36:53 +02:00
isidzukuri
0c02b5d9bd
fix spec
2024-02-15 09:24:02 +02:00
isidzukuri
b9eea88f5c
more precise spec for error message wording
2024-02-15 09:20:32 +02:00
isidzukuri
c0e820e447
Improve error message by not displaying the first part of the second sentence if no changes were counted
2024-02-15 09:14:52 +02:00
David Cook
1df0eca4d1
Click button to add form
...
Now we can fill out the form, but in most cases we can't submit it because it's not marked as 'changed'.
2024-02-15 17:32:08 +11:00
David Cook
5253aeab17
Add unit_value so we can create new variants for producuts by weight/volume
2024-02-15 17:31:50 +11:00
David Cook
eff92b076f
Add new variant form
...
And with the benefit of time travel, a feature spec from the future which will show us where we're heading.
2024-02-15 17:20:38 +11:00
David Cook
831d786d44
Fix existing specs
...
Gotta wait for server response before making expectations. This reveals that one test was incomplete, oops.
2024-02-15 17:04:14 +11:00
Maikel Linke
78bfd47ad3
Add rake task to reset queued jobs
...
Please note that the spec is using Redis as Sidekiq does. This revealed
that Sidekiq wasn't set up for jobs in the test environment properly.
2024-02-15 16:51:10 +11:00
Maikel
c15bf61099
Merge pull request #12156 from isidzukuri/issue_12062_fix_flacky_tax_rate_finder_spec
...
Improve random name generation in factories related to tax_rate_factory
2024-02-15 15:43:05 +11:00
David Cook
ec0e8b80eb
Add specs for creating variants
...
This already works, but we want to make sure it stays that way!
2024-02-15 14:57:13 +11:00
Maikel Linke
3f98e2e559
Reduce Capybara wait time during development
...
In test-driven development, you run tests and expect them to fail.
Waiting for the results unnecessarily long just slows down development.
And even though CI can be slow, we should aim for good performance of
our code. Long wait times can hide performance bottle necks.
If anyone struggles with the default value, we can add an environment
variable to adjust the wait time to your machine in .env.test.local. But
this may just work for everyone.
2024-02-15 13:11:51 +11:00
Konrad
8751cc37f3
Merge pull request #12126 from cyrillefr/Replace-remote_toggle_controller-with-generic-toggle_control_controller
...
Replace remote_toggle with method inside generic controller
2024-02-15 00:32:05 +01:00
Konrad
6e54b1e726
Merge pull request #12116 from cillian/apply-fees-on-shipments-create
...
Make sure fees are applied when adding the first item to a back office order
2024-02-14 23:53:54 +01:00
Konrad
7cd7d2e8ea
Merge pull request #12132 from rioug/9290-capture-payment-ignore-order-change
...
Fix capturing order payment ignore order changes
2024-02-14 23:00:49 +01:00
isidzukuri
cffe573203
improve random name generation in factories related to tax_rate_factory
2024-02-14 18:41:28 +02:00
Rachel Arnould
164bac63e0
Merge pull request #12130 from dacook/buu/modal-styles-11065
...
[BUU] Image modal styles
2024-02-14 16:12:32 +01:00
Maikel Linke
96469cb58a
Update stripe cassettes
2024-02-14 11:16:59 +11:00
filipefurtad0
60c03f6161
Re-records VCR tapes
2024-02-08 15:08:59 +00:00
David Cook
c2f8786ffa
Filter out STRIPE_INSTANCE_SECRET_KEY from cassettes
...
And also STRIPE_ENDPOINT_SECRET just in case it's ever used in tests.
Re-records Stripe tests. But some failed... :'(
Failed examples:
rspec ./spec/lib/stripe/credit_card_cloner_spec.rb:71 # Stripe::CreditCardCloner#find_or_clone when called with a valid customer and payment_method clones both the payment method and the customer
rspec ./spec/lib/stripe/payment_intent_validator_spec.rb[1:1:1:1:17:1:2] # Stripe::PaymentIntentValidator#call when payment intent is valid valid non-3D credit cards are correctly handled behaves like payments intents from UnionPay (debit) captures the payment
2024-02-08 14:58:24 +00:00
filipefurtad0
edae56345b
Removes unnecessary Stripe api key / secret declaration
2024-02-08 14:53:48 +00:00
filipefurtad0
5b738476e4
Replaces double with instance_double
2024-02-08 14:50:42 +00:00
filipefurtad0
ecc5bbd0ed
Adds condition to set Stripe.api key
...
Updates spec accordingly
2024-02-08 14:50:42 +00:00
filipefurtad0
949f7ef4d4
Removes unecessary braces - Ruby magic ;-)
2024-02-08 14:50:42 +00:00
filipefurtad0
9cad866fb6
Renames test case and VCR cassette
...
deletes previous cassette
2024-02-08 14:50:42 +00:00
filipefurtad0
949b515bfb
Replaces stubs for non-existing customer test case
2024-02-08 14:50:42 +00:00
filipefurtad0
57f55d7585
Replaces stubs for existing customer test case
2024-02-08 14:50:42 +00:00
filipefurtad0
94168a3586
Encompasses test cases in describe block
...
Maybe not needed but, brings perhaps some structure to the spec, an creates a place holder for the required setup
2024-02-08 14:50:42 +00:00
David Cook
c4ea343a47
Merge pull request #12127 from filipefurtad0/corrects_setup_in_credit_card_cloner_spec
...
Corrects setup for setup in credit card cloner spec
2024-02-08 09:14:35 +11:00
filipefurtad0
6c9556f2db
Removes UnionPay (debit) from non-3DS card list
...
Rubocop fixes
2024-02-07 16:32:34 +00:00
