Konrad
2477a63f36
Merge pull request #12103 from basilawwad/selecting-OC-should-redirect-to-shop
...
Modify default hash tabs controller to redirect users to shopping panel when an OC is selected.
2024-02-19 21:51:19 +01:00
Gaetan Craig-Riou
edc40c9ea9
Refactor Spree::Gateway::StripeSCA
...
- fix confusing comment
- rename parameter to better reflect usage
2024-02-19 10:58:31 +11:00
Gaetan Craig-Riou
549610bc35
Finally remove StripePaymentIntentsGateway decorator
...
Add spec for Spree::Gateway::StripeSCA#void
It also partially fix 11670, refund of Stripe payment should now work
for complete order
2024-02-19 10:58:31 +11:00
Rachel Arnould
39b83eae19
Merge pull request #12133 from dacook/buu/new-variant-11066
...
[BUU] Create a new variant inline
2024-02-16 14:32:17 +01:00
basilawwad
08111f9a2c
added shop target and activateshoppanel function
...
Remove Pending Message
Update shopping_spec.rb
Update shopping_spec.rb
2024-02-16 09:27:21 +03:00
David Cook
7164cbd0bd
Don't validate numericality if blank
...
This avoids unnecessary second message when left blank:
> can't be blank
> is not a number
Ok this is a little confusing. Why is there a separate presence check above, and why is it only for measurable units, when we still require a number for _all_ units? Because, for 'items', we allow a blank value then auto-set it to 1.
I don't know if it's really necessary, but that's how it currently works...
2024-02-16 08:51:53 +11:00
David Cook
915a5ce66b
Listen for changes on added fields
...
Finally, we can add new variants!
Requires updated stimulus-rails-nested-form
2024-02-16 08:51:49 +11:00
isidzukuri
ae9229ec7a
Merge branch 'master' into 12003_improve_error_messageg_when_no_products_are_changed
2024-02-15 09:36:53 +02:00
isidzukuri
c0e820e447
Improve error message by not displaying the first part of the second sentence if no changes were counted
2024-02-15 09:14:52 +02:00
David Cook
3706b6d1da
Make actions target optional
...
This is to make testing simpler, but it is strictly optional anyway.
2024-02-15 17:32:08 +11:00
David Cook
765ee0ed78
refactor js
2024-02-15 17:32:08 +11:00
David Cook
1df0eca4d1
Click button to add form
...
Now we can fill out the form, but in most cases we can't submit it because it's not marked as 'changed'.
2024-02-15 17:32:08 +11:00
David Cook
6cca7a4a3a
Refactor HAML
...
Making use of nested hash to DRY it up
2024-02-15 17:32:08 +11:00
David Cook
6e5154b922
add stimulus-rails-nested-form
...
The official instructions (https://www.stimulus-components.com/docs/stimulus-rails-nested-form ) don't quite work, because of an issue with this component (https://stackoverflow.com/a/76715129 ). So we work around for now by using the umd file instead.
2024-02-15 17:32:08 +11:00
David Cook
977ea47487
move new variant form to template
...
it can be activated with JS, once I can get that compoent working..
◉ Best viewed with whitespace ignored
2024-02-15 17:32:08 +11:00
David Cook
5253aeab17
Add unit_value so we can create new variants for producuts by weight/volume
2024-02-15 17:31:50 +11:00
David Cook
eff92b076f
Add new variant form
...
And with the benefit of time travel, a feature spec from the future which will show us where we're heading.
2024-02-15 17:20:38 +11:00
David Cook
d812815913
Fix: use correct parameter name
...
Before, the index was defaulting to the record id, but we want to have a sequential index to guarantee the order always stays the same.
And more importantly, we'll need it for new records that don't have an ID yet.
2024-02-15 11:00:59 +11:00
David Cook
7e186091ff
Ensure un-changed field error state shows
...
When there is a required field that can't be empty. I knew these complex styles would come back to bite me.
◉ Best viewed with whitespace ignored
2024-02-15 10:36:45 +11:00
David Cook
c65771eac6
Add new 'naked' button
...
I couldn't think of a better name.
2024-02-15 10:36:45 +11:00
David Cook
50b325c944
Annotate and arrange scss
2024-02-15 10:36:45 +11:00
David Cook
024f324027
Refactor: move rows to partials
...
This file was too big and it's about to get bigger.
2024-02-15 10:36:45 +11:00
Konrad
8751cc37f3
Merge pull request #12126 from cyrillefr/Replace-remote_toggle_controller-with-generic-toggle_control_controller
...
Replace remote_toggle with method inside generic controller
2024-02-15 00:32:05 +01:00
Konrad
6e54b1e726
Merge pull request #12116 from cillian/apply-fees-on-shipments-create
...
Make sure fees are applied when adding the first item to a back office order
2024-02-14 23:53:54 +01:00
Rachel Arnould
164bac63e0
Merge pull request #12130 from dacook/buu/modal-styles-11065
...
[BUU] Image modal styles
2024-02-14 16:12:32 +01:00
Filipe
850918dac5
Merge pull request #12112 from chahmedejaz/bugfix/12085-fix-customer-search-autofill-issue
...
Fix Customer Search Autofill Issue
2024-02-12 12:29:28 +00:00
David Cook
5e4dd3864f
Update image and modal size
...
Using a new 'fit' modal size.
On smaller screens, we need to allow the image to shrink. That's a good general rule, but I was hesitant to make it a global rule..
2024-02-07 12:48:44 +11:00
David Cook
98cfc68c3a
Add option for modal class
2024-02-07 12:28:43 +11:00
David Cook
d24348d0f2
Increase button size
...
And fix alignment for smaller screens.
2024-02-07 10:13:17 +11:00
cyrillefr
f8cb98f43e
Replace remote_toggle with method inside generic controller
...
- put former remote toggle ctrller toggle method
in new toggleAdvancedSettings in more generic toggle ctrller
- modified acordingly the 2 associated views
- put former test code in more generic ctrller test file
- deleted now useless ctrller + test files
2024-02-06 17:02:23 +01:00
David Cook
b3692d7468
Remove min-height for ModalComponent
2024-02-06 15:00:29 +11:00
David Cook
6189feadaa
Prevent modal covered by scrollbar
...
Using units relative to the document, rather than the screen.
I don't think that remaining min-height should be there at all, but reveal-modal is used a lot so I don't know for sure.
2024-02-06 14:56:39 +11:00
David Cook
784f74f466
Align buttons to the right
2024-02-06 14:51:13 +11:00
David Cook
8c6d3a27ec
Move modal action styles to parent component
...
They were already being shared with a HelpModalComponent in fact.
2024-02-06 14:34:36 +11:00
Rachel Arnould
d4d5449fba
Merge pull request #12107 from dacook/buu/fixes
...
[BUU] Style and behaviour updates
2024-02-05 11:33:06 +01:00
Rachel Arnould
11bdba3c4e
Merge pull request #12073 from rioug/12045-add-invisible-captcha
...
Add invisible captcha to registration screen
2024-02-05 10:44:41 +01:00
Gaetan Craig-Riou
6d3af4801e
Merge pull request #12100 from mkllnk/remove-background-reports-toggle
...
Remove background_reports feature toggle
2024-02-05 11:47:43 +11:00
Cillian O'Ruanaidh
da71f711c0
Make sure fees are applied when adding the first item to a back office order
2024-02-02 13:11:15 +00:00
Ahmed Ejaz
a6431bdec6
12085: fix customer search autofill issue
2024-02-02 01:58:35 +05:00
David Cook
d0724bab85
Fix column header alignmnt
2024-02-01 12:09:49 +11:00
David Cook
36722bfa20
Add more room for the On Hand column
2024-02-01 12:02:42 +11:00
David Cook
262823bddd
Ensure On Demand field doesn't overflow following cell
2024-02-01 11:56:40 +11:00
David Cook
079925bc9a
Fix for styling with a blank value
...
It's not usually valid, but can still be entered. I wasn't able to fix the positioning of the :after psuedo element without having a child text node. Maybe it's possible to add an empty child text node, but I didn't think it worth getting down to that level..
2024-02-01 11:31:14 +11:00
David Cook
133a9e6c7f
Show popout when press printable character
2024-02-01 11:18:15 +11:00
David Cook
da82b12ca7
Prevent negative values for stock on hand
...
Using browser validation. I didn't use model validation because the on_hand pseudo-attribute doesn't support it.
But.. it turned out to not be so simple. Browser validation can't work if the field is hidden, and breaks the javascript. So now I made the javascript smarter, and the end result is more helpful I think.
2024-02-01 11:18:15 +11:00
David Cook
3d941dcc1f
Adjust popout position
...
Now it's lined up perfectly with the number input.
2024-02-01 11:18:15 +11:00
David Cook
ae1fabae38
Tweak padding according to design
2024-02-01 11:18:15 +11:00
Konrad
a30da1f656
Merge pull request #12093 from cillian/generate-invoice-button-warning
...
Display a warning when clicking the generate invoice button if an ABN is required but not present
2024-01-31 21:52:15 +01:00
Konrad
60c18ffa85
Merge pull request #12084 from cyrillefr/Replace-toggle_controller-with-generic-toggle_control_controller
...
Replace toggle_controller with method inside generic controller
2024-01-31 21:17:47 +01:00
Konrad
d24924b8f4
Merge pull request #12075 from cyrillefr/Actions-dropdown-should-not-open-automatically-after-shipping-the-order
...
Actions dropdown should stay closed after shipping order
2024-01-31 20:49:49 +01:00
