isidzukuri
0c02b5d9bd
fix spec
2024-02-15 09:24:02 +02:00
isidzukuri
b9eea88f5c
more precise spec for error message wording
2024-02-15 09:20:32 +02:00
isidzukuri
c0e820e447
Improve error message by not displaying the first part of the second sentence if no changes were counted
2024-02-15 09:14:52 +02:00
Rachel Arnould
164bac63e0
Merge pull request #12130 from dacook/buu/modal-styles-11065
...
[BUU] Image modal styles
2024-02-14 16:12:32 +01:00
Maikel Linke
96469cb58a
Update stripe cassettes
2024-02-14 11:16:59 +11:00
filipefurtad0
60c03f6161
Re-records VCR tapes
2024-02-08 15:08:59 +00:00
David Cook
c2f8786ffa
Filter out STRIPE_INSTANCE_SECRET_KEY from cassettes
...
And also STRIPE_ENDPOINT_SECRET just in case it's ever used in tests.
Re-records Stripe tests. But some failed... :'(
Failed examples:
rspec ./spec/lib/stripe/credit_card_cloner_spec.rb:71 # Stripe::CreditCardCloner#find_or_clone when called with a valid customer and payment_method clones both the payment method and the customer
rspec ./spec/lib/stripe/payment_intent_validator_spec.rb[1:1:1:1:17:1:2] # Stripe::PaymentIntentValidator#call when payment intent is valid valid non-3D credit cards are correctly handled behaves like payments intents from UnionPay (debit) captures the payment
2024-02-08 14:58:24 +00:00
filipefurtad0
edae56345b
Removes unnecessary Stripe api key / secret declaration
2024-02-08 14:53:48 +00:00
filipefurtad0
5b738476e4
Replaces double with instance_double
2024-02-08 14:50:42 +00:00
filipefurtad0
ecc5bbd0ed
Adds condition to set Stripe.api key
...
Updates spec accordingly
2024-02-08 14:50:42 +00:00
filipefurtad0
949f7ef4d4
Removes unecessary braces - Ruby magic ;-)
2024-02-08 14:50:42 +00:00
filipefurtad0
9cad866fb6
Renames test case and VCR cassette
...
deletes previous cassette
2024-02-08 14:50:42 +00:00
filipefurtad0
949b515bfb
Replaces stubs for non-existing customer test case
2024-02-08 14:50:42 +00:00
filipefurtad0
57f55d7585
Replaces stubs for existing customer test case
2024-02-08 14:50:42 +00:00
filipefurtad0
94168a3586
Encompasses test cases in describe block
...
Maybe not needed but, brings perhaps some structure to the spec, an creates a place holder for the required setup
2024-02-08 14:50:42 +00:00
David Cook
c4ea343a47
Merge pull request #12127 from filipefurtad0/corrects_setup_in_credit_card_cloner_spec
...
Corrects setup for setup in credit card cloner spec
2024-02-08 09:14:35 +11:00
filipefurtad0
6c9556f2db
Removes UnionPay (debit) from non-3DS card list
...
Rubocop fixes
2024-02-07 16:32:34 +00:00
filipefurtad0
769ccfd6ef
Corrects setup for setup in credit card cloner spec
...
We should not need additional hard coded keys other than the API key and the CLIENT_ID; this PR removes hard coded customer ID - creates one instead
Undoes Stripe.api_key deletion
This was a mixup with an ongoing PR in which we remove the need to call api_key in each individual spec.
2024-02-07 12:20:43 +00:00
David Cook
5e4dd3864f
Update image and modal size
...
Using a new 'fit' modal size.
On smaller screens, we need to allow the image to shrink. That's a good general rule, but I was hesitant to make it a global rule..
2024-02-07 12:48:44 +11:00
Rachel Arnould
d4d5449fba
Merge pull request #12107 from dacook/buu/fixes
...
[BUU] Style and behaviour updates
2024-02-05 11:33:06 +01:00
Rachel Arnould
11bdba3c4e
Merge pull request #12073 from rioug/12045-add-invisible-captcha
...
Add invisible captcha to registration screen
2024-02-05 10:44:41 +01:00
David Cook
133a9e6c7f
Show popout when press printable character
2024-02-01 11:18:15 +11:00
David Cook
da82b12ca7
Prevent negative values for stock on hand
...
Using browser validation. I didn't use model validation because the on_hand pseudo-attribute doesn't support it.
But.. it turned out to not be so simple. Browser validation can't work if the field is hidden, and breaks the javascript. So now I made the javascript smarter, and the end result is more helpful I think.
2024-02-01 11:18:15 +11:00
Konrad
a30da1f656
Merge pull request #12093 from cillian/generate-invoice-button-warning
...
Display a warning when clicking the generate invoice button if an ABN is required but not present
2024-01-31 21:52:15 +01:00
Konrad
60c18ffa85
Merge pull request #12084 from cyrillefr/Replace-toggle_controller-with-generic-toggle_control_controller
...
Replace toggle_controller with method inside generic controller
2024-01-31 21:17:47 +01:00
Konrad
9e6b8e0624
Merge pull request #12047 from rioug/12021-enterprise-fee-tax-on-invoice
...
Include Tax on enterprise fees on the invoice
2024-01-31 15:32:54 +01:00
David Cook
97ab41b47e
Merge pull request #12068 from mkllnk/dfc-enterprise-promo-image
...
Add promo image to DFC Enterprise API
2024-01-31 13:35:47 +11:00
Maikel
865394913b
Merge pull request #12098 from filipefurtad0/shopfront_message_redirect_pending_test_for_12076
...
[Pending spec] Updates distributor to have a shopfront message (reproduces #12076 )
2024-01-30 11:56:40 +11:00
Maikel
fff1a21688
Merge pull request #12074 from filipefurtad0/vcr_credit_card_clone_destroyer_spec
...
[Stripe, VCR] Updates credit_card_cloner_spec.rb
2024-01-30 11:24:04 +11:00
filipefurtad0
d2bb53da5b
Removes assertion on bogus_customer
...
When running the CI we actually assert on the bogus credentials, which breaks the spec
Removes unecessary StripeStubs inclusion
2024-01-29 20:04:38 +00:00
filipefurtad0
318a8113ed
Updates distributor to have a shopfront message
...
Doing so, enables a homepage for that enterprise, which surfaces issue #12076 . The test as been set as pending, which needs to be changed when the issue is fixed
2024-01-29 15:52:31 +00:00
Gaetan Craig-Riou
e129ef38c2
Refactor total method to use sum instead of reduce
...
Plus some extra specs to cover missing scenarios
2024-01-29 14:12:28 +11:00
Cillian O'Ruanaidh
f960dec0eb
Display a warning when clicking the generate invoice button if an ABN is required but not present
2024-01-26 14:28:42 +00:00
filipefurtad0
3e734f1e6b
Attaches customer to payment method and clones payment method
...
Improves naming of actors; improves assertions
2024-01-25 18:43:05 +00:00
filipefurtad0
baef7de663
Replaces stubs with real accounts and card ids
...
The second example on this sepec is commented out, and will be addressed on the following commit
Sets user email
We need to set an email for the user we're creating; if we don't, then each time we run the spec, a new user will be created with a random email - as per user factory. This will translate in a (slightly) different HTTP request each time the spec is ran, and will cause a VCR recording error as new cassettes cannot be recorded in under the CI.
Re-recordes cassette after rebase
2024-01-25 18:43:03 +00:00
Rachel Arnould
96d2021b72
Merge branch 'master' into buu/add-product-images-11065
2024-01-25 16:32:45 +01:00
cyrillefr
e6c0afa477
Replace toggle_controller with method inside generic ctrller
...
- move toggle method from toggle_controller inside toggle_control
ctrller
- change corresponding html attributes in view
- mode corresponding spec in toggle_controller ctrller spec
- delete now unused toggle controller + spec
2024-01-25 10:16:02 +01:00
David Cook
a005069394
Merge pull request #12041 from mkllnk/migrations
...
Remove migrations with faulty ids
2024-01-25 17:29:23 +11:00
David Cook
6ffe125820
Override default messages
...
Just in case any bots have been trained to handle the gem's default messages.
2024-01-25 17:24:27 +11:00
David Cook
2535435b55
Test success with invisible_captcha
2024-01-25 17:09:18 +11:00
David Cook
0638b9eea4
Use unique email address for test
...
Using the existing user email is only needed for the 'already registered' test.
:
2024-01-25 17:06:25 +11:00
David Cook
c3914bc7ae
Merge pull request #11759 from openfoodfoundation/dependabot/npm_and_yarn/tom-select-2.3.1
...
chore(deps): bump tom-select from 2.2.3 to 2.3.1
2024-01-25 16:26:10 +11:00
David Cook
a915182bf8
Add tests for image controller
2024-01-25 14:14:58 +11:00
David Cook
f72154e40c
Add image create form
...
Re-using the edit image form, because they're basically the same.
2024-01-25 14:14:58 +11:00
David Cook
07bef860b2
Add spec for updating image
2024-01-25 14:14:58 +11:00
David Cook
25f4954795
Combine spec
2024-01-25 14:14:58 +11:00
David Cook
e92f4a120a
Refactor: re-organise spec file
...
No code changes, just moving it around and renaming blocks. Best viewed with white-space ignored.
2024-01-25 14:14:58 +11:00
Konrad
ca12eab4bb
Merge pull request #11985 from chahmedejaz/task/11768-add-voucher-in-enterprise-fees-with-tax-by-order-report
...
Include vouchers in report: Enterprise Fees With Tax Report By Order
2024-01-24 22:57:48 +01:00
Konrad
5377304190
Merge pull request #12050 from cyrillefr/Replace-toggle_button_disabled_controller-with-generic-toggle_control_controller
...
Replace toggle_button_disable controller with generic toggle_control controller
2024-01-24 16:39:26 +01:00
Konrad
ec4bbe6241
Merge pull request #12038 from mkllnk/dfc-tax-category
...
Spec requiring tax category when creating products
2024-01-24 16:26:57 +01:00
